From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>
Subject: Re: [PATCH 17/19] mtd: rawnand: r852: Move the ECC initialization to ->attach_chip()
Date: Mon, 30 Nov 2020 09:04:12 +0100 [thread overview]
Message-ID: <20201130090412.5fac23d3@xps13> (raw)
In-Reply-To: <20201130010755.GA1956350@ubuntu-m3-large-x86>
Hi Nathan,
Nathan Chancellor <natechancellor@gmail.com> wrote on Sun, 29 Nov 2020
18:07:55 -0700:
> On Fri, Nov 13, 2020 at 01:34:22PM +0100, Miquel Raynal wrote:
> > The probe function is only supposed to initialize the controller
> > hardware but not the ECC engine. Indeed, we don't know anything about
> > the NAND chip(s) at this stage. Let's move the logic initializing the
> > ECC engine, even pretty simple, to the ->attach_chip() hook which gets
> > called during nand_scan() routine, after the NAND chip discovery. As
> > the previously mentioned logic is supposed to parse the DT for us, it
> > is likely that the chip->ecc.* entries be overwritten. So let's avoid
> > this by moving these lines to ->attach_chip().
> >
> > Fixes: d7157ff49a5b ("mtd: rawnand: Use the ECC framework user input parsing bits")
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Maxim Levitsky <maximlevitsky@gmail.com>
>
> Just as a heads up, this patch was applied to mtd/fixes as
> commit 7ef969a04228 ("mtd: rawnand: r852: Move the ECC
> initialization to ->attach_chip()") but it appears to also be applied to
> nand/next as commit 0c2b69f55132 ("mtd: rawnand: r852: Move the ECC
> initialization to ->attach_chip()"), where due to its mismerged nature,
> it causes a clang warning:
>
> ../drivers/mtd/nand/raw/r852.c:874:24: warning: variable 'dev' is uninitialized when used here [-Wuninitialized]
> nand_controller_init(&dev->controller);
> ^~~
> ../drivers/mtd/nand/raw/r852.c:847:25: note: initialize the variable 'dev' to silence this warning
> struct r852_device *dev;
> ^
> = NULL
> 1 warning generated.
>
> Cheers,
> Nathan Chancellor
Absolutely, this fix came late, nand/next was already set up and there
was conflicts between the two. I applied these same patches at the root
of nand/next to be sure the branch would still be valid until the next
-rc would come out (today).
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-11-30 8:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:34 [PATCH 00/19] Ensure good ECC settings Miquel Raynal
2020-11-13 12:34 ` [PATCH 01/19] mtd: rawnand: gpio: Move the ECC initialization to ->attach_chip() Miquel Raynal
2020-11-19 20:48 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 02/19] mtd: rawnand: xway: " Miquel Raynal
2020-11-19 20:48 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 03/19] mtd: rawnand: ams-delta: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 04/19] mtd: rawnand: au1550: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 05/19] mtd: rawnand: cs553x: " Miquel Raynal
2020-11-13 12:34 ` [PATCH 06/19] mtd: rawnand: davinci: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 07/19] mtd: rawnand: diskonchip: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 08/19] mtd: rawnand: fsmc: " Miquel Raynal
2020-11-13 12:34 ` [PATCH 09/19] mtd: rawnand: lpc32xx_mlc: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 10/19] mtd: rawnand: lpc32xx_slc: " Miquel Raynal
2020-11-13 12:34 ` [PATCH 11/19] mtd: rawnand: mpc5121: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 12/19] mtd: rawnand: orion: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 13/19] mtd: rawnand: txx9ndfmc: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 14/19] mtd: rawnand: tmio: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 15/19] mtd: rawnand: pasemi: " Miquel Raynal
2020-11-19 20:47 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 16/19] mtd: rawnand: plat_nand: " Miquel Raynal
2020-11-19 20:46 ` Miquel Raynal
2020-11-13 12:34 ` [PATCH 17/19] mtd: rawnand: r852: " Miquel Raynal
2020-11-19 20:46 ` Miquel Raynal
2020-11-30 1:07 ` Nathan Chancellor
2020-11-30 8:04 ` Miquel Raynal [this message]
2020-11-13 12:34 ` [PATCH 18/19] mtd: rawnand: sharpsl: " Miquel Raynal
2020-11-13 12:34 ` [PATCH 19/19] mtd: rawnand: socrates: " Miquel Raynal
2020-11-19 20:46 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130090412.5fac23d3@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=maximlevitsky@gmail.com \
--cc=natechancellor@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.