From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E58BC4361B for ; Fri, 4 Dec 2020 18:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F27AD22B4E for ; Fri, 4 Dec 2020 18:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728507AbgLDSS6 (ORCPT ); Fri, 4 Dec 2020 13:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgLDSS5 (ORCPT ); Fri, 4 Dec 2020 13:18:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947FAC0613D1; Fri, 4 Dec 2020 10:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nlb27gOIz2SmsAyu6K72xtrnZxBbjqGUhaedoDoNJ5U=; b=v81Nqn1QAIeCQWqVcMHNHb8ovS aCoM6YQ27ZI+zBYptGpbs7neLx847cQHyVkFNnKfjhuTbY6bhypvfgrFlgKoT2qLLK1sbKqwVwvzd WndUrufh1oGnrjOXDlD337yx9os+D61CZp1GEkPX5eQNmBB81IpDGe6bIjGDowzD2ZCsD3aKrCQC9 48WDG979Fw1IlzLDIYebxAwT8UL8259V7Nsmcuo6mbcysuqFp9/5LRk0N7XRbpgkjrXSaluSiOe1W KUvnZ7nOjPcbkLq9bxC1Cpi7NqZMVOUCRDy2qE3t9P7k8ufpzpsJAnh44FEPOAWIprwvGF6KLh/Ul VHLDxenw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1klFej-0006v1-1b; Fri, 04 Dec 2020 18:18:09 +0000 Date: Fri, 4 Dec 2020 18:18:08 +0000 From: Christoph Hellwig To: Will McVicker Cc: Christoph Hellwig , Jessica Yu , Masahiro Yamada , Michal Marek , Greg Kroah-Hartman , Saravana Kannan , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 0/2] Adds support to capture module's SCM version Message-ID: <20201204181808.GA26478@infradead.org> References: <20201125010541.309848-1-willmcvicker@google.com> <20201204075159.GA29752@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2020 at 10:13:56AM -0800, Will McVicker wrote: > On Fri, Dec 04, 2020 at 07:51:59AM +0000, Christoph Hellwig wrote: > > I think your decription still shows absolutely no benefit for the > > kernel, so I'not sure why anyone would want to waste time on this. > Hi Christoph, > > Did you get a chance to read my earlier responses regarding the uses for > in-tree modules? > > The biggest benefit for the upstream community is being about to get the SCM > version for *any* module (including in-tree modules) in the initramfs via the > sysfs node. Currently there is no way to do that and there is no guarantee that That assumes the SCM version of a module has any kind of meaning for an in-tree module. Which it doesn't. If you care about the SCM version of an in-tree module the only thing we need is one single global sysfs file.