From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9D3C4361A for ; Fri, 4 Dec 2020 20:10:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B07DF22CAD for ; Fri, 4 Dec 2020 20:10:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730819AbgLDUKQ (ORCPT ); Fri, 4 Dec 2020 15:10:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729147AbgLDUKQ (ORCPT ); Fri, 4 Dec 2020 15:10:16 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7ACFC061A51 for ; Fri, 4 Dec 2020 12:09:35 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klHOU-00044M-E8; Fri, 04 Dec 2020 21:09:30 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1klHOS-00028b-4u; Fri, 04 Dec 2020 21:09:28 +0100 Date: Fri, 4 Dec 2020 21:09:27 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Dmitry Torokhov , Russell King , Dominik Brodowski , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: <20201204200927.p354eli7uqr776sp@pengutronix.de> References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ylbalxyvhyuipbv3" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-input@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org --ylbalxyvhyuipbv3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Greg, On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-K=F6nig wrote: > > The driver core ignores the return value of struct device_driver::remove > > because there is only little that can be done. To simplify the quest to > > make this function return void, let struct sa1111_driver::remove return > > void, too. All users already unconditionally return 0, this commit makes > > it obvious that returning an error code is a bad idea and ensures future > > users behave accordingly. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > Reviewed-by: Greg Kroah-Hartman Thanks, can I interpret this also as an Ack to take the change affecting drivers/usb via Russell's tree? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --ylbalxyvhyuipbv3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl/Kl3QACgkQwfwUeK3K 7AlmhAf9F7NmYPLA9RAjwasWctkMau78khxkjBLaMDlVTgkU2ks5nm72b6Baizsn HKBguMwdF4uWzLd4LfifNzAsUtf3SWkcWxVpW20nH8NqFeLUuoz6u0i/JgqfaTdO mgeqyp3pZ2SrfQz6fq2Rp83YM7VAFvVCxFaNun248simpRrW+hPsKSybO2FIgDWU guqc8F23dbEStinvA7B5aUkvzHWvE4C4pDCBVzRWt4V8iSY8B6MbHCazRS0SKLhr sDA4sM9DCfiDTlDz5jrhkPkMIHiYa8oq8nAQ5Fd3B4i7OUIXOo+gp4PDTuxyW8kB 7BBjNp17gStSdxi8As6ZKCP+OFvoKQ== =8a5x -----END PGP SIGNATURE----- --ylbalxyvhyuipbv3-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D9B5C4361A for ; Fri, 4 Dec 2020 20:11:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D18B822A85 for ; Fri, 4 Dec 2020 20:11:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D18B822A85 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dWW6Yw7pTG6ZKWWmlzzGA9MAlt9vN8YVgVAsOTlKCTw=; b=p1DSQjqLjeTmKbQeCLUg49dyy cmDuRd+NC9U4kOl8blAdavaLaWSPSRSgBt9S4ypKG9QuAEF+VOF/V7Ur0lU9qIviSbgroe1xwaOze wK5hEe0b493/OWL5vCciUmsGIuQnDCdosQTvLP5YU5cfC8l6HjN7IYk/3jmxBoHSUz1NSmi866v1k +nRkv3xCfTWLgBAi321WN6s6oAbA4aqvHpLduk7+akKuVt+B/wIiLEh9EHqLFD+ndXZyXgtPMbLzH TrWskP9XI+/yVoIW5QpxC+dgzD2l6v1yGF488TwJgkbhLcEr++aj+3hm3uZDXWrj0/0uMWvvH4fqx 9STQufJEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klHOf-0000QN-4J; Fri, 04 Dec 2020 20:09:41 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klHOc-0000Pm-Ud for linux-arm-kernel@lists.infradead.org; Fri, 04 Dec 2020 20:09:39 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klHOU-00044M-E8; Fri, 04 Dec 2020 21:09:30 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1klHOS-00028b-4u; Fri, 04 Dec 2020 21:09:28 +0100 Date: Fri, 4 Dec 2020 21:09:27 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: <20201204200927.p354eli7uqr776sp@pengutronix.de> References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201204_150939_052030_3F6F052A X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , linux-usb@vger.kernel.org, Russell King , Dominik Brodowski , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4016892285448406502==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4016892285448406502== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ylbalxyvhyuipbv3" Content-Disposition: inline --ylbalxyvhyuipbv3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Greg, On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-K=F6nig wrote: > > The driver core ignores the return value of struct device_driver::remove > > because there is only little that can be done. To simplify the quest to > > make this function return void, let struct sa1111_driver::remove return > > void, too. All users already unconditionally return 0, this commit makes > > it obvious that returning an error code is a bad idea and ensures future > > users behave accordingly. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > Reviewed-by: Greg Kroah-Hartman Thanks, can I interpret this also as an Ack to take the change affecting drivers/usb via Russell's tree? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --ylbalxyvhyuipbv3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl/Kl3QACgkQwfwUeK3K 7AlmhAf9F7NmYPLA9RAjwasWctkMau78khxkjBLaMDlVTgkU2ks5nm72b6Baizsn HKBguMwdF4uWzLd4LfifNzAsUtf3SWkcWxVpW20nH8NqFeLUuoz6u0i/JgqfaTdO mgeqyp3pZ2SrfQz6fq2Rp83YM7VAFvVCxFaNun248simpRrW+hPsKSybO2FIgDWU guqc8F23dbEStinvA7B5aUkvzHWvE4C4pDCBVzRWt4V8iSY8B6MbHCazRS0SKLhr sDA4sM9DCfiDTlDz5jrhkPkMIHiYa8oq8nAQ5Fd3B4i7OUIXOo+gp4PDTuxyW8kB 7BBjNp17gStSdxi8As6ZKCP+OFvoKQ== =8a5x -----END PGP SIGNATURE----- --ylbalxyvhyuipbv3-- --===============4016892285448406502== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4016892285448406502==--