From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB694C4361B for ; Sat, 5 Dec 2020 23:50:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E26B23135 for ; Sat, 5 Dec 2020 23:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727477AbgLEXue (ORCPT ); Sat, 5 Dec 2020 18:50:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:55438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgLEXud (ORCPT ); Sat, 5 Dec 2020 18:50:33 -0500 Date: Sat, 5 Dec 2020 15:49:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607212193; bh=h0vaEYwFre3MPf6MHPuQ2v8JOABc6Vx+THCYEJwqZEg=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=CoulufPecNt5be0Hh33etS3OzTQxlnBJ7VBB2umi3YSs3TT6bAL3EyUHBgEj678S1 D4e7VYqm5pc2agH2C6uCN5zPOwbkvVwlH+Y2LwcMt4wYPnBdw1fXV95sYKffViOi82 y0gL1xUtGL6JHZ55vqfkxTlEJvulAsxDRMKJIl+uZORsFppIruc0DSGKJvS1xuNNnV arPEnpc1N7a7vSPwk9IxxpxwYLSRgD4a85MqeoZCZRlLf4Z+nzhwxkq4qHnj2Dp0Ve nMp1Nrg6/xjUA+Dj7oA/ei8fl0jd7Qlt8cw+URHJlwZLH8KqybD0pcvvwEZagDn2XM VXYVuq9MeuQVQ== From: Jakub Kicinski To: Alexander Duyck Cc: "Limonciello, Mario" , Jeff Kirsher , Tony Nguyen , intel-wired-lan , LKML , Linux PM , Netdev , Sasha Netfin , Aaron Brown , Stefan Assmann , David Miller , David Arcari , "Shen, Yijun" , "Yuan, Perry" , "anthony.wong@canonical.com" Subject: Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM Message-ID: <20201205154951.4dd92194@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: References: <20201204200920.133780-1-mario.limonciello@dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > The patches look good to me. Just need to address the minor issue that > > > seems to have been present prior to the introduction of this patch > > > set. > > > > > > Reviewed-by: Alexander Duyck > > > > Thanks for your review. Just some operational questions - since this previously > > existed do you want me to re-spin the series to a v4 for this, or should it be > > a follow up after the series? > > > > If I respin it, would you prefer that change to occur at the start or end > > of the series? > > I don't need a respin, but if you are going to fix it you should > probably put out the patch as something like a 8/7. If you respin it > should happen near the start of the series as it is a bug you are > addressing. Don't we need that patch to be before this series so it can be back ported easily? Or is it not really a bug? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Sat, 5 Dec 2020 15:49:51 -0800 Subject: [Intel-wired-lan] [PATCH v3 0/7] Improve s0ix flows for systems i219LM In-Reply-To: References: <20201204200920.133780-1-mario.limonciello@dell.com> Message-ID: <20201205154951.4dd92194@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, 4 Dec 2020 14:38:03 -0800 Alexander Duyck wrote: > > > The patches look good to me. Just need to address the minor issue that > > > seems to have been present prior to the introduction of this patch > > > set. > > > > > > Reviewed-by: Alexander Duyck > > > > Thanks for your review. Just some operational questions - since this previously > > existed do you want me to re-spin the series to a v4 for this, or should it be > > a follow up after the series? > > > > If I respin it, would you prefer that change to occur at the start or end > > of the series? > > I don't need a respin, but if you are going to fix it you should > probably put out the patch as something like a 8/7. If you respin it > should happen near the start of the series as it is a bug you are > addressing. Don't we need that patch to be before this series so it can be back ported easily? Or is it not really a bug?