From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 901A5C433FE for ; Tue, 8 Dec 2020 19:29:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B8B623BAB for ; Tue, 8 Dec 2020 19:29:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B8B623BAB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8D3A16B005C; Tue, 8 Dec 2020 14:29:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 884AA6B005D; Tue, 8 Dec 2020 14:29:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 772616B0068; Tue, 8 Dec 2020 14:29:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 61D1F6B005C for ; Tue, 8 Dec 2020 14:29:41 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0CE513626 for ; Tue, 8 Dec 2020 19:29:41 +0000 (UTC) X-FDA: 77571104562.02.verse20_3804abc273e9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id E257010097AA2 for ; Tue, 8 Dec 2020 19:29:40 +0000 (UTC) X-HE-Tag: verse20_3804abc273e9 X-Filterd-Recvd-Size: 4191 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Dec 2020 19:29:38 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id s6so1045122qvn.6 for ; Tue, 08 Dec 2020 11:29:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WvPDTcch2COuCFpjYkdsAJRk+S8cjlv2H+71oiFYxFo=; b=gQkYNDYmVAYT1PCt/2SguWD+erI8C4HgGSjC7nwa+14EuuOa6qv1cIO016WfUTF8A7 XEQ4bQv5JhdNjz+JoOheQ7ThqkP3E+J3gI5nixLNJcQi3DDlIurXWDNxj120NeCVpPWy ZvjrXKc45t3zCV9vh83MJ0V+GhL54a/wq4AaefH/XA1OMyOv1e73QcdRmMhKQmg0JAJH z5VXuTqHMpngSpYeXXHCi4wD8PXnDsWMX3KAyemFV753XLeM1YA2qQIcFR7/ko539G6n Rt9QVJE/PB15CG4tnyjFHvXzV7IoBKTIoSJWzKOHWQ+as7oWf+sTuagAMYLRP8jb2AY3 uZIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WvPDTcch2COuCFpjYkdsAJRk+S8cjlv2H+71oiFYxFo=; b=UixV8ExHM92kvZE0JK3sAHeyPxXMgUQjR2cUapICwYu7Hk3PSjymSwJiQwJUpMo0on 2Pcnf0n92/+W9ogl0CX8ylplPRNg8ypdxsK6E9LQ/INf7QzJJEepW/Klv6ILiwwPhjU0 Fq/z+yK+qUC1W0At7NAwklkS1xVdVwNBF+RiBCproatD50NT8UEdPak6j08sZr6GnPer CTx9YLXr7QgICWDmR1FA4+/Wl6RsMyN1+vGzZPaceTe6mSZMSG1fkBOKq2wXZM6O/h7f hkRuuR49+mrchUTvvuFdonNYRcakMT0vkJ1o98HMRwPRqBQAgbwfoMcgU0yZo8CRjz46 PbJQ== X-Gm-Message-State: AOAM5338Q8Y4mdvtVh/VgMDpCI4cWcxhAmSQwkbHfSCOYg5zSpf21DlB vUIW7bHmX/TTSUq7lUEO3rdMKw== X-Google-Smtp-Source: ABdhPJyIj664j5sFyq0sc2OrtzB5BhKXN4IpC/M5bcFP3OpWsvY13lpcwTBFb4dadPQSuebt5V7N2A== X-Received: by 2002:a05:6214:1467:: with SMTP id c7mr18305690qvy.51.1607455777189; Tue, 08 Dec 2020 11:29:37 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id h9sm1756652qkk.33.2020.12.08.11.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 11:29:36 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kmig3-0080Pu-ER; Tue, 08 Dec 2020 15:29:35 -0400 Date: Tue, 8 Dec 2020 15:29:35 -0400 From: Jason Gunthorpe To: Joao Martins Cc: linux-mm@kvack.org, Dan Williams , Ira Weiny , linux-nvdimm@lists.01.org, Matthew Wilcox , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton Subject: Re: [PATCH RFC 8/9] RDMA/umem: batch page unpin in __ib_mem_release() Message-ID: <20201208192935.GA1908088@ziepe.ca> References: <20201208172901.17384-1-joao.m.martins@oracle.com> <20201208172901.17384-10-joao.m.martins@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201208172901.17384-10-joao.m.martins@oracle.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 08, 2020 at 05:29:00PM +0000, Joao Martins wrote: > static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int dirty) > { > + bool make_dirty = umem->writable && dirty; > + struct page **page_list = NULL; > struct sg_page_iter sg_iter; > + unsigned long nr = 0; > struct page *page; > > + page_list = (struct page **) __get_free_page(GFP_KERNEL); Gah, no, don't do it like this! Instead something like: for_each_sg(umem->sg_head.sgl, sg, umem->nmap, i) unpin_use_pages_range_dirty_lock(sg_page(sg), sg->length/PAGE_SIZE, umem->writable && dirty); And have the mm implementation split the contiguous range of pages into pairs of (compound head, ntails) with a bit of maths. Jason