From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68430C4361B for ; Fri, 11 Dec 2020 23:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3760C23358 for ; Fri, 11 Dec 2020 23:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406992AbgLKWin (ORCPT ); Fri, 11 Dec 2020 17:38:43 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:49583 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2406972AbgLKWiQ (ORCPT ); Fri, 11 Dec 2020 17:38:16 -0500 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0BBMbN4S020852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Dec 2020 17:37:24 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4AA36420136; Fri, 11 Dec 2020 17:37:23 -0500 (EST) Date: Fri, 11 Dec 2020 17:37:23 -0500 From: "Theodore Y. Ts'o" To: Andreas Dilger Cc: Ext4 Developers List , Saranya Muruganandam , Wang Shilong Subject: Re: [PATCH RFC 5/5] Enable threaded support for e2fsprogs' applications. Message-ID: <20201211223723.GD575698@mit.edu> References: <20201205045856.895342-1-tytso@mit.edu> <20201205045856.895342-6-tytso@mit.edu> <89A599C9-4978-43C9-B2B4-82C9E746AC39@dilger.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89A599C9-4978-43C9-B2B4-82C9E746AC39@dilger.ca> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Dec 10, 2020 at 09:10:09PM -0700, Andreas Dilger wrote: > On Dec 4, 2020, at 9:58 PM, Theodore Ts'o wrote: > > > > Signed-off-by: Theodore Ts'o > > My understanding is that as soon as the EXT2_FLAG_THREADS is added, > and if the backend supports CHANNEL_FLAGS_THREADS, then the pthread > code in the previous patch will "autothread" based on the number of > CPUs in the system. Yep. > That will be nice for debugfs, which would otherwise take ages to > start on a large filesystem if "-c" was not used (which also > precludes any kind of modifications). > > Reviewed-by: Andreas Dilger Yes, that's an issue that our SRE's have run across as well while debugging customer problems, which is one of the reasons why I've been interested in getting this change upstream first, even it takes a bit longer to get all of the parallel fsck changes reviewed and upstream. - Ted