From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B93C2BB9A for ; Tue, 15 Dec 2020 16:21:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71C49224F4 for ; Tue, 15 Dec 2020 16:21:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731036AbgLOQVV (ORCPT ); Tue, 15 Dec 2020 11:21:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23357 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731018AbgLOQVG (ORCPT ); Tue, 15 Dec 2020 11:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608049179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MYw9qkE6do0WLmI3ecrnK4fZEA4hNDBBx290R86qwks=; b=cH1FuPzVan70s2dr0vdDG/0J1Ug7ggLT3VVCavkeTU8ONAUmDKpLKXihJztS/FItxNsycy kZemkH6PrEjIFmKpV6VcogErZakXwv95NrYB/fWDGCA1YEBeL1giIG2gTNTJDy/64RD6AX XmmjtHcTCY/HUeHMvdWO9VbQTymHz1s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-O4HAPn8PNomIiYN-XAUW0w-1; Tue, 15 Dec 2020 11:19:37 -0500 X-MC-Unique: O4HAPn8PNomIiYN-XAUW0w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9EDA84A5F3; Tue, 15 Dec 2020 16:18:42 +0000 (UTC) Received: from krava (ovpn-113-169.ams2.redhat.com [10.36.113.169]) by smtp.corp.redhat.com (Postfix) with SMTP id A27B45C224; Tue, 15 Dec 2020 16:18:39 +0000 (UTC) Date: Tue, 15 Dec 2020 17:18:38 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Ian Rogers , Stephane Eranian , Alexei Budankov Subject: Re: [PATCH 2/3] perf tools: Allow to enable/disable events via control file Message-ID: <20201215161838.GA698181@krava> References: <20201210204330.233864-1-jolsa@kernel.org> <20201210204330.233864-3-jolsa@kernel.org> <20201215151413.GE252952@kernel.org> <20201215152420.GC658008@krava> <20201215160332.GN258566@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201215160332.GN258566@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 15, 2020 at 01:03:32PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 15, 2020 at 04:24:20PM +0100, Jiri Olsa escreveu: > > On Tue, Dec 15, 2020 at 12:14:13PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Dec 10, 2020 at 09:43:29PM +0100, Jiri Olsa escreveu: > > > > Adding new control events to enable/disable specific event. > > > > The interface string for control file are: > > > > > > > > 'enable-' > > > > 'disable-' > > > > > > Wwy do we have "enable-" as the "tag" for this? > > > > the whole 'enable-' is prefix for command that enables specific event > > following '-' starts the event name > > > > > > > > Also is it possible to use "enable sched:*" and have that match what is > > > in the evlist and enable (or disable, if using "disable sched:*") what > > > matches? > > > > yep, that should be possible to add > > > > > > > > This second suggestion can be done on top of this, i.e. as an > > > enhancement, but mixing up the command (enable, disable) with its > > > arguments looks strange. > > > > the '-' determines that there's event name following, > > pure 'enable' switches on everything > > I see it, but why not use the more natural ' ' space to separate the > command from its arguments? Just like in a bash command line, say? > > I.e. why not: > > enable > > to enable everything, and: > > enable sched:sched_switch > > To enable just the "sched:sched_switch" event? right, that's we discussed in the other patch thread, I'll make the change thanks, jirka