From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Michael Petlan <mpetlan@redhat.com>,
Ian Rogers <irogers@google.com>,
Stephane Eranian <eranian@google.com>,
Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 3/3] perf tools: Add evlist/evlist-verbose control commands
Date: Tue, 15 Dec 2020 17:27:01 +0100 [thread overview]
Message-ID: <20201215162701.GB698181@krava> (raw)
In-Reply-To: <20201215160933.GO258566@kernel.org>
On Tue, Dec 15, 2020 at 01:09:33PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > instead of:
>
> > echo 'enable-cycles' > control
>
> > I'd like to avoid any elaborate parsing logic..
>
> > how about that?
>
> Use space to separate command from its arguments, keep the same
> experience as:
>
> [acme@quaco ~]$ perf evlist -h
>
> Usage: perf evlist [<options>]
>
> -f, --force don't complain, do it
> -F, --freq Show the sample frequency
> -g, --group Show event group information
> -i, --input <file> Input file name
> -v, --verbose Show all event attr details
> --trace-fields Show tracepoint fields
>
> [acme@quaco ~]$
>
> and:
>
> echo "evlist arguments"
>
> ?
>
> Fits the bill :-)
ok
>
> The experience users have on existing commands, the same arguments, etc.
>
> Even -h can have its uses, i.e. has this daemon support for some option
> or is it an old version?
Alexei just suggested to add 'stop' control command and use it
instead of kill signal, which is good idea
but other than that daemon just opens the control file and
shows its path
jirka
prev parent reply other threads:[~2020-12-15 16:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 20:43 [PATCHv2 0/3] perf tools: Allow to enable/disable events via control pipe Jiri Olsa
2020-12-10 20:43 ` [PATCH 1/3] perf tools: Add evlist__disable_evsel/evlist__enable_evsel Jiri Olsa
2020-12-15 15:17 ` Arnaldo Carvalho de Melo
2020-12-10 20:43 ` [PATCH 2/3] perf tools: Allow to enable/disable events via control file Jiri Olsa
2020-12-15 15:14 ` Arnaldo Carvalho de Melo
2020-12-15 15:24 ` Jiri Olsa
2020-12-15 16:03 ` Arnaldo Carvalho de Melo
2020-12-15 16:18 ` Jiri Olsa
2020-12-15 16:27 ` Arnaldo Carvalho de Melo
2020-12-10 20:43 ` [PATCH 3/3] perf tools: Add evlist/evlist-verbose control commands Jiri Olsa
2020-12-11 3:27 ` Namhyung Kim
2020-12-15 15:23 ` Arnaldo Carvalho de Melo
2020-12-15 15:59 ` Jiri Olsa
2020-12-15 16:09 ` Arnaldo Carvalho de Melo
2020-12-15 16:27 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215162701.GB698181@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=abudankov@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.