All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, david@redhat.com
Subject: Re: [PATCH v3 0/4] target/s390x: Improve carry computation
Date: Wed, 16 Dec 2020 18:09:27 +0100	[thread overview]
Message-ID: <20201216180927.54f57458.cohuck@redhat.com> (raw)
In-Reply-To: <20201214221356.68039-1-richard.henderson@linaro.org>

On Mon, 14 Dec 2020 16:13:52 -0600
Richard Henderson <richard.henderson@linaro.org> wrote:

> While testing the float128_muladd changes for s390x host,
> emulating under x86_64 of course, I noticed that the code
> we generate for strings of ALCGR and SLBGR is pretty awful.
> 
> I realized that we were missing a trick: the output cc is
> based only on the output (result and carry) and so we don't
> need to save the inputs.  And once we do that, we can use
> the output carry as a direct input to the next insn.
> 
> Changes for v3:
>   * Rebased.
> Changes for v2:
>   * Add a few more comments, and enhance the patch descriptions.
> 
> 
> r~
> 
> Richard Henderson (4):
>   target/s390x: Improve cc computation for ADD LOGICAL
>   target/s390x: Improve ADD LOGICAL WITH CARRY
>   target/s390x: Improve cc computation for SUBTRACT LOGICAL
>   target/s390x: Improve SUB LOGICAL WITH BORROW
> 
>  target/s390x/internal.h    |  11 +-
>  target/s390x/cc_helper.c   | 123 +++-------------
>  target/s390x/helper.c      |  10 +-
>  target/s390x/translate.c   | 289 ++++++++++++++++++++-----------------
>  target/s390x/insn-data.def |  76 +++++-----
>  5 files changed, 216 insertions(+), 293 deletions(-)
> 

Thanks, applied.



      parent reply	other threads:[~2020-12-16 17:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-14 22:13 [PATCH v3 0/4] target/s390x: Improve carry computation Richard Henderson
2020-12-14 22:13 ` [PATCH v3 1/4] target/s390x: Improve cc computation for ADD LOGICAL Richard Henderson
2020-12-14 22:13 ` [PATCH v3 2/4] target/s390x: Improve ADD LOGICAL WITH CARRY Richard Henderson
2020-12-14 22:13 ` [PATCH v3 3/4] target/s390x: Improve cc computation for SUBTRACT LOGICAL Richard Henderson
2020-12-14 22:13 ` [PATCH v3 4/4] target/s390x: Improve SUB LOGICAL WITH BORROW Richard Henderson
2020-12-16 14:44 ` [PATCH v3 0/4] target/s390x: Improve carry computation David Hildenbrand
2020-12-16 17:09 ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216180927.54f57458.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.