From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E20CBC433E0 for ; Fri, 8 Jan 2021 12:04:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7474D2388B for ; Fri, 8 Jan 2021 12:04:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7474D2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZR9E42yRk1vbXvwSGZfIki+OC12ZcnIx6I4/ee7TyAs=; b=YXPOSY//JewSgJejEXj+P9smV wMM5Cv7UNT6UDzE5kWj8n5TyJkSRddCVZBJH8Awx7gcgOrEQ3EjB3p8Q+bmnJVCrOhGHTcBRa6FyG f7WiEAhwP7SKhYzXyHceNqKYpzbx0e5XDyHUrHM+N5ZFeqd184uREr7FYKacHRfcimdDbGI6E/DPW kLeuYGG0U6OMCSIZbCyS4kNBDRZsAZOGNDCnhBnUG2pg0BPoWoSoj0C5dY2JFucSyEcZGsaH18mIp ICA8oAeLjvNtnIvtqKiG6XQkPua5S/5wiCByfrRz+2ftJuqVYsRayJyh2GQ5/uJuItlH1iU7ddIqA d6DC0VVKA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqTC-0001od-Iy; Fri, 08 Jan 2021 12:02:18 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxqSm-0001nc-Uq for linux-arm-kernel@lists.infradead.org; Fri, 08 Jan 2021 12:01:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bJOGiW3qLcM4/z6eIGxZ05/zggIOS4pzoU1ql39Q58k=; b=RVIQuaiT8Am+LgxFOhE1UBSjB 4/dvcEL2yZxFnCxdv3oebFL+V5qwAPOWWG0PfOTJMa+YQ5w4Z+uoMGwjxRRmuTprndinoE7TeOV2O Ku3K5lm2fwpevcW01A+h1jTMlap/FLcs10MgtcPETPm9DcEMKAduNO1WMSSIpHUOu2TlHAQnWBv9T ylish7Wvbawr0EERlhUmfyQ58y/2HbRnE8l2TcUZd8BtwL9naqDOnKg48A2WbAPwvueai0HwYHAiu APtM6RcrHch4aj1X/a1A3Qr4QIBWDb0vWQDSzVr6ZciGiD9WStNolosRueJZ7H1Qi3DR1UMwDnj7l 9qFS1VPiA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45292) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxqSj-0003vs-3o; Fri, 08 Jan 2021 12:01:49 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kxqSi-00027v-OS; Fri, 08 Jan 2021 12:01:48 +0000 Date: Fri, 8 Jan 2021 12:01:48 +0000 From: Russell King - ARM Linux admin To: Michael Walle Subject: Re: Broken ethernet on SolidRun cubox-i Message-ID: <20210108120148.GV1551@shell.armlinux.org.uk> References: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> <20201226123421.GD1551@shell.armlinux.org.uk> <1d79aa88e73b6e0118e570a64026817e@walle.cc> <20201227161114.GF1551@shell.armlinux.org.uk> <20210108115357.GU1551@shell.armlinux.org.uk> <6e3ae1175c71cd27f7578071a801a4fc@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6e3ae1175c71cd27f7578071a801a4fc@walle.cc> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210108_070153_024404_3C3F223F X-CRM114-Status: GOOD ( 27.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matus Ujhelyi , acmattheis@gmx.net, Christoph Mattheis , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 08, 2021 at 12:58:17PM +0100, Michael Walle wrote: > Am 2021-01-08 12:53, schrieb Russell King - ARM Linux admin: > > On Sun, Dec 27, 2020 at 04:11:14PM +0000, Russell King - ARM Linux admin > > wrote: > > > On Sun, Dec 27, 2020 at 04:59:39PM +0100, Michael Walle wrote: > > > > Am 2020-12-27 16:33, schrieb Michael Walle: > > > > > Am 2020-12-26 13:34, schrieb Russell King - ARM Linux admin: > > > > > > I'd forgotten that there were boards out there with this proble= m... > > > > > > the PHY address configuration is done via the LED_ACT pin, and > > > > > > SolidRun > > > > > > omitted a pull resistor on it, so it "floats" with the leakage = current > > > > > > of the LED/pin - resulting in it sometimes appearing at address= 0 and > > > > > > sometimes at address 4. > > > > > > > > > > Mh, I've guessed that too, but there must be more to it. The data= sheet > > > > > says it has an internal weak pull-up. Or Atheros messed up and it > > > > > doesn't > > > > > reliably work if there is actually an LED attached to it. But the= n, why > > > > > would any other stronger pull-up/down work.. > > > > > > > > Mhh, nevermind, from the commit log [1]. > > > > > > > > "The LED_ACT pin on the carrier-one boards had a pull down that > > > > forces the phy address to 0x0; where on CuBox-i and the production > > > > HummingBoard that pin is connected directly to LED that depending > > > > on the pull down strength of the LED it might be sampled as '0' o= r '1' > > > > thus > > > > the phy address might appear as either address 0x0 or 0x4." > > > > > > > > So it actually depends on the forward voltage of the LED and the > > > > hi/low thresholds of the AT8035.. nice! Oh and btw. this pin also > > > > switches between high and low-active LED output. So the missing > > > > pull-down might not only switch the PHY address to 4 but also invert > > > > the LED state. > > > = > > > Indeed. And whether it appears at address 0 or 4 will depend on many > > > factors, including temperature - LEDs have a decrease of 2mV/=B0C. > > > = > > > I wonder if we can just delete the phy-handle property, and list a > > > PHY at both address 0 and 4 with the appropriate configuration... > > = > > Michael, can you try the attached patch please? > = > I don't have a cubox. But it's just a device tree patch. I could > try to hack one based on Christophs dtb and he could just replace > it on his sd card and test. Seems easy enough. This sounds like a mess of indirection. What is "Christophs dtb"? Why are there different dtbs out there for the same platform? If there's changes necessary, why aren't they being submitted to the mainline kernel? In fact, why aren't users reporting these problems to mainline kernel developers? Why do we have to have this tortuous bug reporting route which makes testing fixes difficult? This rather makes me not want to care about this. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel