From: Steven Rostedt <rostedt@goodmis.org>
To: Liu Peibao <liupeibao@163.com>
Cc: mhiramat@kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] init/main.c: fix strings split across lines
Date: Mon, 11 Jan 2021 19:02:35 -0500 [thread overview]
Message-ID: <20210111190235.3e81770f@gandalf.local.home> (raw)
In-Reply-To: <20201230060424.29097-2-liupeibao@163.com>
On Wed, 30 Dec 2020 14:04:23 +0800
Liu Peibao <liupeibao@163.com> wrote:
> Fix warning found by checkpatch.pl.
>
> Signed-off-by: Liu Peibao <liupeibao@163.com>
> ---
> init/main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/init/main.c b/init/main.c
> index 6feee7f11eaf..1e492de770c8 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1470,8 +1470,7 @@ static int __ref kernel_init(void *unused)
> !try_to_run_init_process("/bin/sh"))
> return 0;
>
> - panic("No working init found. Try passing init= option to kernel. "
> - "See Linux Documentation/admin-guide/init.rst for guidance.");
> + panic("No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance.");
Sorry, we don't add changes to the kernel that checkpatch warns about.
checkpatch should only be run on new code. Please do not submit any patches
on existing code because checkpatch warns about it.
-- Steve
> }
>
> /* Open /dev/console, for stdin/stdout/stderr, this should never fail */
next prev parent reply other threads:[~2021-01-12 0:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 6:04 Review request 0/2: init/main.c: sink the kernel_init to the bottom Liu Peibao
2020-12-30 6:04 ` [PATCH 1/2] init/main.c: fix strings split across lines Liu Peibao
2021-01-12 0:02 ` Steven Rostedt [this message]
2021-01-12 14:26 ` Liu Peibao
2021-01-12 21:11 ` Steven Rostedt
2021-01-13 2:02 ` Liu Peibao
2020-12-30 6:04 ` [PATCH 2/2] init/main.c: sink the kernel_init to the bottom Liu Peibao
2021-01-12 0:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111190235.3e81770f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liupeibao@163.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.