From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5368C433DB for ; Mon, 18 Jan 2021 15:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E0F522573 for ; Mon, 18 Jan 2021 15:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393438AbhARPY0 (ORCPT ); Mon, 18 Jan 2021 10:24:26 -0500 Received: from mga02.intel.com ([134.134.136.20]:63424 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393430AbhARPYW (ORCPT ); Mon, 18 Jan 2021 10:24:22 -0500 IronPort-SDR: Hv8o6MDNpH3eIOv5DJb4r+7EmlxDHLm/vU0tf2uMYcJbl5q+5PfMVdltcof77mrC/vMDFhQa5E 8GDHxS8wujQA== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="165905457" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="165905457" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 07:22:28 -0800 IronPort-SDR: ey9MYaovfO4Cxa0p3PXuW/Ij57ursllGF9zE68jwOIjMt8T1cdZfRTVNo5ok9NGulZeFPoWuG6 Dj026CjwSatw== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="350241206" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 07:22:21 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1l1WNH-002Hbm-Ex; Mon, 18 Jan 2021 17:23:23 +0200 Date: Mon, 18 Jan 2021 17:23:23 +0200 From: "andriy.shevchenko@linux.intel.com" To: =?utf-8?Q?Barnab=C3=A1s_P=C5=91cze?= Cc: Daniel Scally , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "andy@kernel.org" , "mika.westerberg@linux.intel.com" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "wsa@kernel.org" , "lee.jones@linaro.org" , "hdegoede@redhat.com" , "mgross@linux.intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "sakari.ailus@linux.intel.com" , "laurent.pinchart@ideasonboard.com" , "kieran.bingham@ideasonboard.com" Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver Message-ID: <20210118152323.GV4077@smile.fi.intel.com> References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-7-djrscally@gmail.com> <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> <20210118135121.GM4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Jan 18, 2021 at 02:51:30PM +0000, Barnabás Pőcze wrote: > 2021. január 18., hétfő 14:51 keltezéssel, Andy Shevchenko írta: > > > On Mon, Jan 18, 2021 at 11:12:34AM +0000, Barnabás Pőcze wrote: > > > 2021. január 18., hétfő 1:34 keltezéssel, Daniel Scally írta: > > > > > Have you considered putting the source (and header) files into a dedicated > > > folder? I think it'd help manageability in the long run, and it'd be immediately > > > obvious that these source files form a single "unit". > > > > What would be the folder name? Because, for example, intel_cht_int33fe* have no > > folder (yet?) and here it's kinda similar case when HID describes something > > else than just one IP. > > I think "intel_skl_int3472" would not be a bad name for the folder. And I believe > "intel_cht_int33fe" could be given its own folder as well. I;m not objecting (at some point in the past I had proposed moving Intel stuff to a separate folder, but at that time PDx86 has no folders at all and Darren was kinda not in favour of creating ones, but things changed), just let's hear Hans on this. -- With Best Regards, Andy Shevchenko