From: Terry Bowman <terry.bowman@amd.com>
To: unlisted-recipients:; (no To-header on input)
Cc: rjw@rjwysocki.net, lenb@kernel.org, james.morse@arm.com,
tony.luck@intel.com, bp@alien8.de, yazen.ghannam@amd.com,
terry.bowman@amd.com, guohanjun@huawei.com,
colin.king@canonical.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, jon.grimm@amd.com
Subject: [PATCH] ACPI / APEI: Add is_ghes_type() to identify GHES sources
Date: Fri, 22 Jan 2021 12:03:22 -0600 [thread overview]
Message-ID: <20210122180322.1720413-1-terry.bowman@amd.com> (raw)
From: Yazen Ghannam <yazen.ghannam@amd.com>
Refactor duplicated GHES identity logic into is_ghes_type().
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
Signed-off-by: Terry Bowman <terry.bowman@amd.com>
---
drivers/acpi/apei/hest.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 6e980fe16772..bd702e0ef339 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -49,6 +49,12 @@ static const int hest_esrc_len_tab[ACPI_HEST_TYPE_RESERVED] = {
[ACPI_HEST_TYPE_IA32_DEFERRED_CHECK] = -1,
};
+static inline bool is_ghes_type(struct acpi_hest_header *hest_hdr)
+{
+ return hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
+ hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
+}
+
static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
{
u16 hest_type = hest_hdr->type;
@@ -141,8 +147,7 @@ static int __init hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void
{
int *count = data;
- if (hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
- hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2)
+ if (is_ghes_type(hest_hdr))
(*count)++;
return 0;
}
@@ -153,8 +158,7 @@ static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
struct ghes_arr *ghes_arr = data;
int rc, i;
- if (hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR &&
- hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR_V2)
+ if (!is_ghes_type(hest_hdr))
return 0;
if (!((struct acpi_hest_generic *)hest_hdr)->enabled)
--
2.27.0
next reply other threads:[~2021-01-22 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 18:03 Terry Bowman [this message]
2021-01-25 16:41 ` [PATCH] ACPI / APEI: Add is_ghes_type() to identify GHES sources Rafael J. Wysocki
2021-01-25 17:14 ` Borislav Petkov
2021-01-25 22:42 ` Terry Bowman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122180322.1720413-1-terry.bowman@amd.com \
--to=terry.bowman@amd.com \
--cc=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jon.grimm@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.