From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C891C433DB for ; Mon, 25 Jan 2021 03:15:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60087224B1 for ; Mon, 25 Jan 2021 03:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726884AbhAYDPg (ORCPT ); Sun, 24 Jan 2021 22:15:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbhAYDOq (ORCPT ); Sun, 24 Jan 2021 22:14:46 -0500 Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC94EC06174A for ; Sun, 24 Jan 2021 19:14:05 -0800 (PST) Received: by mail-pj1-x102f.google.com with SMTP id md11so7497395pjb.0 for ; Sun, 24 Jan 2021 19:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fv/Vky7VFm1rltfdk/uW9VJjxFj6h7S+3peZRA6VmK4=; b=ONt2ctS2r6+gdTUGauF4KDHMMjNs4o1+EEOOKWV+b1aRsybyGD7LvWmgzB6RMbVZRU Liy7uBpfAvBSvQC4139zEHKth8hSk3A9duRcJedtQLzwB0kvwuprI5q3FCsWVwjqYbGH Sgudy/BHGhLiwAuK8CGrAUhJtJwUbcnoLY2TjDrBoSpZbqcDSTi6+Jw4XpqSj5ZNOrwX PQR/2kTs1O82swWCPcgVJSq3bzg1y2R3trldcKxpIkQ+hMkpdh6yhyh4l5EAqivwUVlB pIaV3A3caecW+YcKxf4HKxYUy6Qrqik0Ji3rximBJ5vKLG4ZQyTqZkyAWg+D1930Q8lg L7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fv/Vky7VFm1rltfdk/uW9VJjxFj6h7S+3peZRA6VmK4=; b=cgMphA7kMU2Zysm/4T7roTeQdi1k9nU1g4PmXlL+Xz5TrfxNkXlSdF3sQ05kePvk/g HyOvPnxeDlgQCew57kXZjUi6BsiFTMuQLJPp2uQR1TAZoEOcgzi7XGJ73S8vyAqO/2Di fgjXVaY01hiSPvyTbiMrndwNhvItR2I8ubFyfGSWDkMTqe3rkbhqGTUNPaNPFGglzo6O 2jCCnk/msDAsqnufGU7pTzU8GKuMWkKmByjfXtNgesyZQcgxqY+HpaE/39YorXRvc1qM +2MM6jXl/QO3FiDv2maKC4Ul/jndzJMPMV+ZxqqahFNbAw6zl1XTQ58lY+sFhrRYhb2d jWpw== X-Gm-Message-State: AOAM530WWduK8ozfxavE/NQKV8LZjaDGJe0STWg1fQVidMD9ObfP8Vtc AfyGRGAR52c1N+UnaK7BN+Vbrg== X-Google-Smtp-Source: ABdhPJx4sy7iiTC8WR6f/YSHtq6fKmuH/YAA5pa1K04GTf1kXOR1QF1XbdaKvtqwkRuURwGS1g7aOQ== X-Received: by 2002:a17:90a:4088:: with SMTP id l8mr1063445pjg.106.1611544445506; Sun, 24 Jan 2021 19:14:05 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id a21sm14746508pgd.57.2021.01.24.19.14.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jan 2021 19:14:04 -0800 (PST) Date: Mon, 25 Jan 2021 08:44:02 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Message-ID: <20210125031402.aqiwhlsozvakehxd@vireshk-i7> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 22-01-21, 18:28, Dmitry Osipenko wrote: > Either way will work, but maybe keeping the dev_pm_opp_set_bw() is a bit > more straightforward variant for now since it will avoid the code's > changes and it's probably a bit more obvious variant for the OPP users. The problem is it creates unnecessary paths which we need to support. For example, in case of bandwidth itself we may want to update regulator/pm domain/required OPPs and this should all be done for everyone. I really do not want to keep separate paths for such stuff, it makes it hard to maintain.. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2AAC433E0 for ; Mon, 25 Jan 2021 03:15:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 542D821D79 for ; Mon, 25 Jan 2021 03:15:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 542D821D79 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XVK1Pw14/i8pRBQslcOFfgdAvFtz8pq/LynX1nEL3Ng=; b=nbsufzkCNnxhj1rwNj1rJ2TK2 3ZGn2E1md6BkIm8c9S8uSuDjgddnTZWiOwS9DRnLmtdze4jLjcUByHF/vVNGnK6sAnxPyS4Ta1z2y 3Nhsf1NBtnWGJeBOdh+/4oXc3gTCosc+cBnvx3PGZ4hAOLypIQHk538rT3fNMRS5Z+UVNqxRyW+y2 mt4KNeWWN0C+sX1MbusrZxybydLrOZajqlC1tUr0e3nMZM0iPI/eWMBY4iY8UYsS6T9zNycxDWyGL WdfWg/xoy2KgcO76LNQWduSMWsCuzl01aDDqTqM1uvxZO/jRv12AJkqK6WXYXAHBPOtzrHunqUFt+ nMpXr3Yzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3sKQ-0006PJ-NB; Mon, 25 Jan 2021 03:14:10 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3sKN-0006Nq-FZ for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 03:14:08 +0000 Received: by mail-pj1-x102c.google.com with SMTP id gx1so1995836pjb.1 for ; Sun, 24 Jan 2021 19:14:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fv/Vky7VFm1rltfdk/uW9VJjxFj6h7S+3peZRA6VmK4=; b=ONt2ctS2r6+gdTUGauF4KDHMMjNs4o1+EEOOKWV+b1aRsybyGD7LvWmgzB6RMbVZRU Liy7uBpfAvBSvQC4139zEHKth8hSk3A9duRcJedtQLzwB0kvwuprI5q3FCsWVwjqYbGH Sgudy/BHGhLiwAuK8CGrAUhJtJwUbcnoLY2TjDrBoSpZbqcDSTi6+Jw4XpqSj5ZNOrwX PQR/2kTs1O82swWCPcgVJSq3bzg1y2R3trldcKxpIkQ+hMkpdh6yhyh4l5EAqivwUVlB pIaV3A3caecW+YcKxf4HKxYUy6Qrqik0Ji3rximBJ5vKLG4ZQyTqZkyAWg+D1930Q8lg L7iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fv/Vky7VFm1rltfdk/uW9VJjxFj6h7S+3peZRA6VmK4=; b=EqbrJL9GgDxO4qPvwXzqoC2ifFRIz/OeQvc36+3Zxqyl9fQ3ccZYBTPDoQRN34KyvX xMrmS09CbpYhAaaStlA5NjtfThlSbzoNfhp7Vhm+jNERa0tmCV2gfqbw2fQLStKIRYSV xwQftTBzhtaHYFkwZbuGWx6+uLCqEuxuWaRE+vHixEflTvrIODrigaXdhF2Y0tV9s2tk xou4q8Xmr1ZD/5e2ZcOGN0UtZ98K45do9f9X5d05k1K7q7QJOj93eE40Z+9g+qIicHNO n24+WmlwhND0yOzWcz5MwE+0RSFziRDFlkr6bw1JJPaMk2ivUoCtCy9JnpBz+GAhQmQR UMdQ== X-Gm-Message-State: AOAM531mwPIXeUKmJdP7jY9z0gb0CvbTU/Xz+1E5EMbfrkWy1AIuhtAZ fluoF2Kqk64AfUx8OOid/onmKA== X-Google-Smtp-Source: ABdhPJx4sy7iiTC8WR6f/YSHtq6fKmuH/YAA5pa1K04GTf1kXOR1QF1XbdaKvtqwkRuURwGS1g7aOQ== X-Received: by 2002:a17:90a:4088:: with SMTP id l8mr1063445pjg.106.1611544445506; Sun, 24 Jan 2021 19:14:05 -0800 (PST) Received: from localhost ([122.172.59.240]) by smtp.gmail.com with ESMTPSA id a21sm14746508pgd.57.2021.01.24.19.14.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jan 2021 19:14:04 -0800 (PST) Date: Mon, 25 Jan 2021 08:44:02 +0530 From: Viresh Kumar To: Dmitry Osipenko Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() Message-ID: <20210125031402.aqiwhlsozvakehxd@vireshk-i7> References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_221407_564130_66D4F2D8 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Rafael Wysocki , linux-kernel@vger.kernel.org, Jonathan Hunter , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Thierry Reding , Sibi Sankar , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-01-21, 18:28, Dmitry Osipenko wrote: > Either way will work, but maybe keeping the dev_pm_opp_set_bw() is a bit > more straightforward variant for now since it will avoid the code's > changes and it's probably a bit more obvious variant for the OPP users. The problem is it creates unnecessary paths which we need to support. For example, in case of bandwidth itself we may want to update regulator/pm domain/required OPPs and this should all be done for everyone. I really do not want to keep separate paths for such stuff, it makes it hard to maintain.. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel