All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ido Schimmel <idosch@idosch.org>,
	Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
	netdev@vger.kernel.org, jiri@nvidia.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP
Date: Mon, 25 Jan 2021 13:12:34 +0100	[thread overview]
Message-ID: <20210125121234.GJ3565223@nanopsycho.orion> (raw)
In-Reply-To: <20210121093605.49ba26ba@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

Thu, Jan 21, 2021 at 06:36:05PM CET, kuba@kernel.org wrote:
>On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote:
>> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote:
>> > Add new trap action HARD_DROP, which can be used by the
>> > drivers to register traps, where it's impossible to get
>> > packet reported to the devlink subsystem by the device
>> > driver, because it's impossible to retrieve dropped packet
>> > from the device itself.
>> > In order to use this action, driver must also register
>> > additional devlink operation - callback that is used
>> > to retrieve number of packets that have been dropped by
>> > the device.  
>> 
>> Are these global statistics about number of packets the hardware dropped
>> for a specific reason or are these per-port statistics?
>> 
>> It's a creative use of devlink-trap interface, but I think it makes
>> sense. Better to re-use an existing interface than creating yet another
>> one.
>
>Not sure if I agree, if we can't trap why is it a trap?
>It's just a counter.

+1

  reply	other threads:[~2021-01-25 12:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 11:29 [PATCH net-next] net: core: devlink: add new trap action HARD_DROP Oleksandr Mazur
2021-01-21 12:21 ` Ido Schimmel
2021-01-21 17:36   ` Jakub Kicinski
2021-01-25 12:12     ` Jiri Pirko [this message]
2021-01-25 12:24       ` Oleksandr Mazur
2021-01-25 14:56         ` Jiri Pirko
2021-01-25 17:40           ` Ido Schimmel
2021-01-22  8:30   ` Oleksandr Mazur
2021-01-22  8:36 Oleksandr Mazur
2021-01-23  1:12 ` Jakub Kicinski
2021-01-23 16:03 ` Ido Schimmel
2021-01-23 20:14   ` Jakub Kicinski
2021-01-24  8:45     ` Ido Schimmel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125121234.GJ3565223@nanopsycho.orion \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=idosch@idosch.org \
    --cc=jiri@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr.mazur@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.