From: Borislav Petkov <bp@alien8.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: x86-ml <x86@kernel.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation/submitting-patches: Add blurb about backtraces in commit messages
Date: Tue, 2 Feb 2021 16:43:39 +0100 [thread overview]
Message-ID: <20210202154339.GE18075@zn.tnic> (raw)
In-Reply-To: <20210105104805.GC28649@zn.tnic>
On Tue, Jan 05, 2021 at 11:48:05AM +0100, Borislav Petkov wrote:
> On Mon, Jan 04, 2021 at 04:19:11PM -0700, Jonathan Corbet wrote:
> > So I have some questions, I guess... How often is a backtrace *in a commit
> > message* really helpful at all? The value in problem reports is clear, but
> > I'm not sure how often having a backtrace in a commit message will really
> > help the reader understand why the patch was written. But perhaps I'm
> > wrong?
>
> Does the subthread here with Sean shed some light on the matter or... ?
>
> > If we do want this advice in our already-too-long submitting-patches
> > document,
>
> Thought the same thing when looking at that doc - it is a *lot* and I
> guess we should put only very globally relevant info in there...
>
> > we should perhaps give some advice as to what is "relevant
> > information" and what is not?
>
> Right, in that subthread, the gist of what we wanna say is to almost
> always put the splat in the commit message - except for the example I
> gave there and other early boot cases - but leave it to the committer to
> do the final decision whether to keep or ditch the splat.
>
> Something like that. Yah, I know, it is fuzzy :-\
Lemme ping here quick - my TODO list still has it. :-)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-02-02 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 18:37 [PATCH] Documentation/submitting-patches: Document the SoB chain Borislav Petkov
2020-12-21 16:54 ` Jonathan Corbet
2020-12-22 13:05 ` [PATCH] Documentation/submitting-patches: Add blurb about backtraces in commit messages Borislav Petkov
2020-12-22 18:59 ` Sean Christopherson
2020-12-22 19:25 ` Borislav Petkov
2020-12-28 17:59 ` Sean Christopherson
2020-12-28 18:15 ` Borislav Petkov
2020-12-28 19:02 ` Sean Christopherson
2021-01-04 23:19 ` Jonathan Corbet
2021-01-05 10:48 ` Borislav Petkov
2021-02-02 15:43 ` Borislav Petkov [this message]
2021-02-04 21:20 ` Jonathan Corbet
2021-02-15 14:19 ` [PATCH] Documentation/submitting-patches: Extend commit message layout description Borislav Petkov
2021-02-25 11:40 ` Robert Richter
2021-03-01 22:10 ` Jonathan Corbet
2021-04-13 11:38 ` [PATCH] Documentation/submitting-patches: Document RESEND tag on patches Borislav Petkov
2021-04-13 21:02 ` Jonathan Corbet
2021-04-15 6:05 ` Borislav Petkov
2021-05-31 14:35 ` Borislav Petkov
2021-06-01 22:27 ` Jonathan Corbet
2021-06-01 22:31 ` Randy Dunlap
2021-06-01 22:37 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202154339.GE18075@zn.tnic \
--to=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.