From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Aaron Conole <aconole@redhat.com>
Subject: [dpdk-dev] [PATCH] devtools: add llx format specifier check
Date: Tue, 9 Feb 2021 15:26:43 +0000 [thread overview]
Message-ID: <20210209152643.1832506-1-ferruh.yigit@intel.com> (raw)
%llx tends to be wrong when used for fixed size, like uint64_t,
variables, adding a warning to double check them.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: David Marchand <david.marchand@redhat.com>
Cc: Aaron Conole <aconole@redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 78a408ef9823..68005389820a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -118,6 +118,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # check %llx usage
+ awk -v FOLDERS='lib drivers app examples' \
+ -v EXPRESSIONS='%ll*[xud]' \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Please check %llx usage which tends to be wrong most of the times' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# svg figures must be included with wildcard extension
# because of png conversion for pdf docs
awk -v FOLDERS='doc' \
--
2.29.2
next reply other threads:[~2021-02-09 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:26 Ferruh Yigit [this message]
2021-02-09 16:38 ` [dpdk-dev] [PATCH] devtools: add llx format specifier check Thomas Monjalon
2021-05-19 19:24 ` [dpdk-dev] [PATCH v2] devtools: check %l format specifier Thomas Monjalon
2021-05-21 12:01 ` Ferruh Yigit
2021-05-21 13:09 ` Thomas Monjalon
2021-05-21 13:30 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2021-05-21 13:33 ` Ferruh Yigit
2021-05-21 13:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209152643.1832506-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.