From: Jonathan Tan <jonathantanmy@google.com>
To: peff@peff.net
Cc: jonathantanmy@google.com, git@vger.kernel.org, stolee@gmail.com,
gitster@pobox.com, jeffhost@microsoft.com
Subject: Re: [PATCH v2] usage: trace2 BUG() invocations
Date: Tue, 9 Feb 2021 11:34:59 -0800 [thread overview]
Message-ID: <20210209193459.3100734-1-jonathantanmy@google.com> (raw)
In-Reply-To: <YCJ6D1wGgmo1a+KT@coredump.intra.peff.net>
> > +# Verb 007bug
> > +#
> > +# Check that BUG writes to trace2
> > +
> > +test_expect_success 'normal stream, exit code 1' '
>
> Is this description accurate? It doesn't really seem like "exit code 1".
> Maybe "99", though BUG is probably more accurate.
Ah...you're right. Maybe 'BUG messages are written to trace2' is better.
If Junio doesn't do it locally (or if there are other issues that need
fixing), I'll send out v3.
next prev parent reply other threads:[~2021-02-09 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 5:49 [PATCH] usage: trace2 BUG() invocations Jonathan Tan
2021-02-05 6:17 ` Junio C Hamano
2021-02-05 9:01 ` Jeff King
2021-02-05 12:51 ` Derrick Stolee
2021-02-05 13:44 ` Jeff King
2021-02-05 16:34 ` Jeff Hostetler
2021-02-05 20:09 ` [PATCH v2] " Jonathan Tan
2021-02-09 12:03 ` Jeff King
2021-02-09 19:34 ` Jonathan Tan [this message]
2021-02-09 21:18 ` Junio C Hamano
2021-02-09 22:15 ` Junio C Hamano
2021-03-27 17:56 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209193459.3100734-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.