Re: [PATCH] clk: Mark fwnodes when their clock provider is added

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3275 bytes --]

Hi Tudor,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on v5.11-rc7 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: nds32-randconfig-r014-20210209 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/383fe519868d52331467f2a7f00c0cf258ea142d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tudor-Ambarus/clk-Mark-fwnodes-when-their-clock-provider-is-added/20210210-195223
        git checkout 383fe519868d52331467f2a7f00c0cf258ea142d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/clk/clk.c: In function 'of_clk_add_hw_provider':
>> drivers/clk/clk.c:4595:2: error: implicit declaration of function 'fwnode_dev_initialized'; did you mean 'zone_is_initialized'? [-Werror=implicit-function-declaration]
    4595 |  fwnode_dev_initialized(&np->fwnode, true);
         |  ^~~~~~~~~~~~~~~~~~~~~~
         |  zone_is_initialized
   cc1: some warnings being treated as errors


vim +4595 drivers/clk/clk.c

  4561	
  4562	/**
  4563	 * of_clk_add_hw_provider() - Register a clock provider for a node
  4564	 * @np: Device node pointer associated with clock provider
  4565	 * @get: callback for decoding clk_hw
  4566	 * @data: context pointer for @get callback.
  4567	 */
  4568	int of_clk_add_hw_provider(struct device_node *np,
  4569				   struct clk_hw *(*get)(struct of_phandle_args *clkspec,
  4570							 void *data),
  4571				   void *data)
  4572	{
  4573		struct of_clk_provider *cp;
  4574		int ret;
  4575	
  4576		cp = kzalloc(sizeof(*cp), GFP_KERNEL);
  4577		if (!cp)
  4578			return -ENOMEM;
  4579	
  4580		cp->node = of_node_get(np);
  4581		cp->data = data;
  4582		cp->get_hw = get;
  4583	
  4584		mutex_lock(&of_clk_mutex);
  4585		list_add(&cp->link, &of_clk_providers);
  4586		mutex_unlock(&of_clk_mutex);
  4587		pr_debug("Added clk_hw provider from %pOF\n", np);
  4588	
  4589		clk_core_reparent_orphans();
  4590	
  4591		ret = of_clk_set_defaults(np, true);
  4592		if (ret < 0)
  4593			of_clk_del_provider(np);
  4594	
> 4595		fwnode_dev_initialized(&np->fwnode, true);
  4596	
  4597		return ret;
  4598	}
  4599	EXPORT_SYMBOL_GPL(of_clk_add_hw_provider);
  4600	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24099 bytes --]