From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: davem@davemloft.net, gregory.clement@bootlin.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
thomas.petazzoni@bootlin.com
Subject: Re: [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700
Date: Mon, 15 Feb 2021 16:06:54 +0100 [thread overview]
Message-ID: <20210215160654.7ff1a145@bootlin.com> (raw)
In-Reply-To: <20210214235058.aicn6aqsm66chrxi@pali>
Hi Pali,
On Mon, 15 Feb 2021 00:50:58 +0100
Pali Rohár <pali@kernel.org> wrote:
>> According to Errata #23 "The per-CPU GbE interrupt is limited to Core
>> 0", we can't use the per-cpu interrupt mechanism on the Armada 3700
>> familly.
>>
>> This is correctly checked for RSS configuration, but the initial queue
>> mapping is still done by having the queues spread across all the CPUs in
>> the system, both in the init path and in the cpu_hotplug path.
>
>Hello Maxime!
>
>This patch looks like a bug fix for Armada 3700 SoC. What about marking
>this commit with Fixes line? E.g.:
>
> Fixes: 2636ac3cc2b4 ("net: mvneta: Add network support for Armada 3700 SoC")
Yes you're correct, I'll add that to the V2 !
Thanks for the review,
Maxime
--
Maxime Chevallier, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-02-15 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 15:12 [PATCH net-next 0/2] net: mvneta: Implement basic MQPrio support Maxime Chevallier
2021-02-12 15:12 ` [PATCH net-next 1/2] net: mvneta: Remove per-cpu queue mapping for Armada 3700 Maxime Chevallier
2021-02-14 23:50 ` Pali Rohár
2021-02-15 15:06 ` Maxime Chevallier [this message]
2021-02-12 15:12 ` [PATCH net-next 2/2] net: mvneta: Implement mqprio support Maxime Chevallier
2021-02-12 17:53 ` kernel test robot
2021-02-12 17:53 ` kernel test robot
2021-02-13 19:45 ` Andrew Lunn
2021-02-15 15:08 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215160654.7ff1a145@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.