From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v3] auxdisplay: Remove in_interrupt() usage.
Date: Tue, 16 Feb 2021 11:28:56 +0100 [thread overview]
Message-ID: <20210216102856.dnaycukt3oqxoszp@linutronix.de> (raw)
In-Reply-To: <CANiq72mkkSfbnNM_mmXE-TNKO1orsAeyByMKFy1N6hm+EBA40A@mail.gmail.com>
On 2021-02-16 10:32:15 [+0100], Miguel Ojeda wrote:
> Hi Sebastian,
Hi,
> On Sat, Feb 13, 2021 at 5:50 PM Sebastian Andrzej Siewior
> <bigeasy@linutronix.de> wrote:
> >
> > charlcd_write() is invoked as a VFS->write() callback and as such it is
> > always invoked from preemptible context and may sleep.
>
> Can we put this sentence as a comment in the code, right before the
> call to cond_resched()?
>
> > charlcd_puts() is invoked from register/unregister callback which is
> > preemtible. The reboot notifier callback is also invoked from
>
> Same for this one.
Could we please avoid documenting the obvious? It is more or less common
knowledge that the write callback (like any other) is preemptible user
context (in which write occurs). The same is true for register/probe
functions. The non-preemptible / atomic is mostly the exception because
of the callback. Like from a timer or an interrupt.
> In addition, somehow the spelling fixes got lost from the previous version.
>
> Same for the "code quotes": some have no quotes, others have `` or `'.
> No big deal, I can fix it on my side if needed, but just letting you
> know! :-)
I'm so sorry. I must have taken the wrong patch while doing the update.
My apologies. Once we sorted out the above, I will provide an update.
> Thanks!
>
> Cheers,
> Miguel
Sebastian
next prev parent reply other threads:[~2021-02-16 10:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 17:58 [PATCH] auxdisplay: Remove in_interrupt() usage Sebastian Andrzej Siewior
2021-02-08 18:38 ` Miguel Ojeda
2021-02-08 19:07 ` Sebastian Andrzej Siewior
2021-02-08 20:14 ` Miguel Ojeda
2021-02-08 20:41 ` Sebastian Andrzej Siewior
2021-02-08 22:26 ` Miguel Ojeda
2021-02-09 9:01 ` Sebastian Andrzej Siewior
2021-02-10 21:46 ` Miguel Ojeda
2021-02-13 16:50 ` [PATCH v3] " Sebastian Andrzej Siewior
2021-02-16 9:32 ` Miguel Ojeda
2021-02-16 10:28 ` Sebastian Andrzej Siewior [this message]
2021-02-16 12:42 ` Miguel Ojeda
2021-02-16 18:26 ` Sebastian Andrzej Siewior
2021-02-16 18:27 ` [PATCH v4] " Sebastian Andrzej Siewior
2021-02-16 20:21 ` [PATCH v3] " Miguel Ojeda
2021-03-10 17:51 ` Sebastian Andrzej Siewior
2021-03-10 18:04 ` Miguel Ojeda
2021-02-08 19:37 ` [PATCH v2] " Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216102856.dnaycukt3oqxoszp@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=tglx@linutronix.de \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.