From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F1EC43381 for ; Thu, 18 Feb 2021 18:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4069164ED6 for ; Thu, 18 Feb 2021 18:03:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234986AbhBRSCv (ORCPT ); Thu, 18 Feb 2021 13:02:51 -0500 Received: from foss.arm.com ([217.140.110.172]:52464 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232284AbhBRP1R (ORCPT ); Thu, 18 Feb 2021 10:27:17 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8F81ED1; Thu, 18 Feb 2021 07:26:27 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.48.237]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DAA73F73D; Thu, 18 Feb 2021 07:26:24 -0800 (PST) Date: Thu, 18 Feb 2021 15:26:18 +0000 From: Mark Rutland To: Hector Martin Cc: Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Subject: Re: [PATCH v2 08/25] arm64: Always keep DAIF.[IF] in sync Message-ID: <20210218152618.GA91307@C02TD0UTHF1T.local> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-9-marcan@marcan.st> <20210217122200.GC5556@C02TD0UTHF1T.local> <20210218142205.GB89209@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 11:42:01PM +0900, Hector Martin wrote: > On 18/02/2021 23.22, Mark Rutland wrote: > > I think that for consistency we always want to keep IRQ and FIQ in-sync, > > even when using GIC priorities. So when handling a pseudo-NMI we should > > unmask DAIF.DA and leave DAIF.IF masked. > > In that case there's one more, in daifflags.h:local_daif_restore(): > > /* > * If interrupts are disabled but we can take > * asynchronous errors, we can take NMIs > */ > flags &= PSR_I_BIT; > pmr = GIC_PRIO_IRQOFF; Good spot, yes! I did a quick scan with `git grep 'PSR_[IF]_BIT' -- arch/arm64`, and AFAICT that's the last one. > > > And a minor related one: should init_gic_priority_masking() WARN if FIQ is > > > masked too? This probably goes with the above. > > > > I think it should, yes. > > Done for v3 then. Thanks! Cool! Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EDAC433DB for ; Thu, 18 Feb 2021 15:28:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7B8064E5F for ; Thu, 18 Feb 2021 15:28:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7B8064E5F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M+7scH51BtDsdZv6DeF42AHrb87HTOq4y0ZJNYVyOH8=; b=cgnd0+D1x1RjIhIIDm5gcWokg fy4lhRJYP4Lj2AKlkc0OEgqM7lLyts3/gUUz3YHcHGgB8ugmJf9Dz80Hscw3Juelr6zlgh2Qd3aHf 7eL+rTCWB59rkqsmI910CYwR5Hqz/OE0pkth/taHUY7ctQ5MPyD/ejL/Wfx/ILECpApyuNvVfhuZp gR4mM/2OZhzpKIt1Sf3YgVreTvXBuox3xIKf6zBBhOSyvlMgUEk5ndScxGl9ldBhipis+UnosaUNY lLAtEvbOaTwv7ClCybAFAFoursnP6E5qc3HR6S1FzMrCLBCvnAY/fxz9rcysnJBKx4RHQ6OO+PDVg Ssl3qogYA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lClCL-0004MF-8r; Thu, 18 Feb 2021 15:26:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lClCJ-0004Lp-4I for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 15:26:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8F81ED1; Thu, 18 Feb 2021 07:26:27 -0800 (PST) Received: from C02TD0UTHF1T.local (unknown [10.57.48.237]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8DAA73F73D; Thu, 18 Feb 2021 07:26:24 -0800 (PST) Date: Thu, 18 Feb 2021 15:26:18 +0000 From: Mark Rutland To: Hector Martin Subject: Re: [PATCH v2 08/25] arm64: Always keep DAIF.[IF] in sync Message-ID: <20210218152618.GA91307@C02TD0UTHF1T.local> References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-9-marcan@marcan.st> <20210217122200.GC5556@C02TD0UTHF1T.local> <20210218142205.GB89209@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_102631_296119_7A03ED9B X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Mark Kettenis , Will Deacon , linux-arm-kernel@lists.infradead.org, Stan Skowronek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 18, 2021 at 11:42:01PM +0900, Hector Martin wrote: > On 18/02/2021 23.22, Mark Rutland wrote: > > I think that for consistency we always want to keep IRQ and FIQ in-sync, > > even when using GIC priorities. So when handling a pseudo-NMI we should > > unmask DAIF.DA and leave DAIF.IF masked. > > In that case there's one more, in daifflags.h:local_daif_restore(): > > /* > * If interrupts are disabled but we can take > * asynchronous errors, we can take NMIs > */ > flags &= PSR_I_BIT; > pmr = GIC_PRIO_IRQOFF; Good spot, yes! I did a quick scan with `git grep 'PSR_[IF]_BIT' -- arch/arm64`, and AFAICT that's the last one. > > > And a minor related one: should init_gic_priority_masking() WARN if FIQ is > > > masked too? This probably goes with the above. > > > > I think it should, yes. > > Done for v3 then. Thanks! Cool! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel