From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 2/5] ASoC: soc-dai: Add sysclk source to snd_soc_dai_set_sysclk()
Date: Fri, 26 Feb 2021 04:48:14 +0800 [thread overview]
Message-ID: <202102260449.qLZZ2M5B-lkp@intel.com> (raw)
In-Reply-To: <1614276364-13655-3-git-send-email-spujar@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 14222 bytes --]
Hi Sameer,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on asoc/for-next]
[also build test ERROR on next-20210225]
[cannot apply to tegra/for-next shawnguo/for-next rockchip/for-next v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sameer-Pujar/Flexible-sysclk-pll-configuration/20210226-021219
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: ia64-randconfig-r003-20210225 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/226d9afb94ceeabe52db6971498a8a029f125bed
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sameer-Pujar/Flexible-sysclk-pll-configuration/20210226-021219
git checkout 226d9afb94ceeabe52db6971498a8a029f125bed
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:154,
from include/linux/pgtable.h:6,
from arch/ia64/include/asm/uaccess.h:40,
from include/linux/uaccess.h:11,
from include/linux/sched/task.h:11,
from include/linux/sched/signal.h:9,
from include/linux/rcuwait.h:6,
from include/linux/percpu-rwsem.h:7,
from include/linux/fs.h:33,
from include/linux/input.h:20,
from sound/soc/intel/boards/cht_bsw_rt5672.c:12:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:127:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
sound/soc/intel/boards/cht_bsw_rt5672.c: In function 'platform_clock_control':
>> sound/soc/intel/boards/cht_bsw_rt5672.c:94:3: error: too few arguments to function 'snd_soc_dai_set_sysclk'
94 | snd_soc_dai_set_sysclk(codec_dai, RT5670_SCLK_S_RCCLK,
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/sound/soc.h:1250,
from sound/soc/intel/boards/cht_bsw_rt5672.c:19:
include/sound/soc-dai.h:122:5: note: declared here
122 | int snd_soc_dai_set_sysclk(struct snd_soc_dai *dai, int clk_id, int source,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +/snd_soc_dai_set_sysclk +94 sound/soc/intel/boards/cht_bsw_rt5672.c
f8fc397e13107f sound/soc/intel/boards/cht_bsw_rt5672.c Hans de Goede 2018-08-21 @12 #include <linux/input.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 13 #include <linux/module.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 14 #include <linux/platform_device.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 15 #include <linux/slab.h>
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 16 #include <linux/clk.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 17 #include <sound/pcm.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 18 #include <sound/pcm_params.h>
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 19 #include <sound/soc.h>
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 20 #include <sound/jack.h>
7feb2f786a46d3 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-10-12 21 #include <sound/soc-acpi.h>
e56c72d5f20104 sound/soc/intel/boards/cht_bsw_rt5672.c Jie Yang 2015-04-02 22 #include "../../codecs/rt5670.h"
b97169da06992e sound/soc/intel/boards/cht_bsw_rt5672.c Jie Yang 2015-04-02 23 #include "../atom/sst-atom-controls.h"
7feb2f786a46d3 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-10-12 24
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 25
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 26 /* The platform clock #3 outputs 19.2Mhz clock to codec as I2S MCLK */
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 27 #define CHT_PLAT_CLK_3_HZ 19200000
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 28 #define CHT_CODEC_DAI "rt5670-aif1"
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 29
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 30 struct cht_mc_private {
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 31 struct snd_soc_jack headset;
2be2d579864316 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2018-01-11 32 char codec_name[SND_ACPI_I2C_ID_LEN];
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 33 struct clk *mclk;
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 34 };
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 35
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 36 /* Headset jack detection DAPM pins */
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 37 static struct snd_soc_jack_pin cht_bsw_headset_pins[] = {
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 38 {
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 39 .pin = "Headset Mic",
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 40 .mask = SND_JACK_MICROPHONE,
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 41 },
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 42 {
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 43 .pin = "Headphone",
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 44 .mask = SND_JACK_HEADPHONE,
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 45 },
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 46 };
6b3b58d97fb2d0 sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-17 47
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 48 static int platform_clock_control(struct snd_soc_dapm_widget *w,
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 49 struct snd_kcontrol *k, int event)
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 50 {
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 51 struct snd_soc_dapm_context *dapm = w->dapm;
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 52 struct snd_soc_card *card = dapm->card;
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 53 struct snd_soc_dai *codec_dai;
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 54 struct cht_mc_private *ctx = snd_soc_card_get_drvdata(card);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 55 int ret;
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 56
dfb6ec7ae57d33 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-10-12 57 codec_dai = snd_soc_card_get_codec_dai(card, CHT_CODEC_DAI);
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 58 if (!codec_dai) {
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 59 dev_err(card->dev, "Codec dai not found; Unable to set platform clock\n");
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 60 return -EIO;
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 61 }
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 62
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 63 if (SND_SOC_DAPM_EVENT_ON(event)) {
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 64 if (ctx->mclk) {
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 65 ret = clk_prepare_enable(ctx->mclk);
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 66 if (ret < 0) {
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 67 dev_err(card->dev,
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 68 "could not configure MCLK state");
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 69 return ret;
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 70 }
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 71 }
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 72
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 73 /* set codec PLL source to the 19.2MHz platform clock (MCLK) */
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 74 ret = snd_soc_dai_set_pll(codec_dai, 0, RT5670_PLL1_S_MCLK,
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 75 CHT_PLAT_CLK_3_HZ, 48000 * 512);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 76 if (ret < 0) {
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 77 dev_err(card->dev, "can't set codec pll: %d\n", ret);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 78 return ret;
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 79 }
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 80
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 81 /* set codec sysclk source to PLL */
226d9afb94ceea sound/soc/intel/boards/cht_bsw_rt5672.c Sameer Pujar 2021-02-25 82 ret = snd_soc_dai_set_sysclk(codec_dai, RT5670_SCLK_S_PLL1, 0,
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 83 48000 * 512, SND_SOC_CLOCK_IN);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 84 if (ret < 0) {
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 85 dev_err(card->dev, "can't set codec sysclk: %d\n", ret);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 86 return ret;
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 87 }
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 88 } else {
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 89 /* Set codec sysclk source to its internal clock because codec
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 90 * PLL will be off when idle and MCLK will also be off by ACPI
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 91 * when codec is runtime suspended. Codec needs clock for jack
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 92 * detection and button press.
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 93 */
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 @94 snd_soc_dai_set_sysclk(codec_dai, RT5670_SCLK_S_RCCLK,
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 95 48000 * 512, SND_SOC_CLOCK_IN);
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 96
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 97 if (ctx->mclk)
c25695ae88ce26 sound/soc/intel/boards/cht_bsw_rt5672.c Pierre-Louis Bossart 2017-06-23 98 clk_disable_unprepare(ctx->mclk);
8d0c38a3f2a6bb sound/soc/intel/cht_bsw_rt5672.c Jin Yao 2015-03-10 99 }
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 100 return 0;
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 101 }
026da220c512f6 sound/soc/intel/cht_bsw_rt5672.c Mengdong Lin 2014-11-21 102
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35544 bytes --]
next prev parent reply other threads:[~2021-02-25 20:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 18:05 [RFC PATCH 0/5] Flexible sysclk/pll configuration Sameer Pujar
2021-02-25 18:05 ` Sameer Pujar
2021-02-25 18:06 ` [RFC PATCH 1/5] ASoC: soc-component: Fix return value of snd_soc_component_set_pll() Sameer Pujar
2021-02-25 18:06 ` Sameer Pujar
2021-02-25 18:06 ` [RFC PATCH 2/5] ASoC: soc-dai: Add sysclk source to snd_soc_dai_set_sysclk() Sameer Pujar
2021-02-25 18:06 ` Sameer Pujar
2021-02-25 20:48 ` kernel test robot [this message]
2021-02-25 18:06 ` [RFC PATCH 3/5] ASoC: audio-graph-card: Add bindings for sysclk and pll Sameer Pujar
2021-02-25 18:06 ` Sameer Pujar
2021-03-02 2:10 ` Rob Herring
2021-03-02 2:10 ` Rob Herring
2021-03-02 7:03 ` Sameer Pujar
2021-03-02 7:03 ` Sameer Pujar
2021-03-02 16:12 ` Mark Brown
2021-03-02 16:12 ` Mark Brown
2021-02-25 18:06 ` [RFC PATCH 4/5] ASoC: simple-card-utils: Parse sysclk id and source Sameer Pujar
2021-02-25 18:06 ` Sameer Pujar
2021-02-25 18:06 ` [RFC PATCH 5/5] ASoC: simple-card-utils: Support pll configuration Sameer Pujar
2021-02-25 18:06 ` Sameer Pujar
2021-02-26 5:24 ` [RFC PATCH 0/5] Flexible sysclk/pll configuration Sameer Pujar
2021-02-26 5:24 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102260449.qLZZ2M5B-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.