From: Piyush Mehta <piyush.mehta@xilinx.com>
To: <axboe@kernel.dk>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<git@xilinx.com>, <sgoud@xilinx.com>, <michal.simek@xilinx.com>,
Piyush Mehta <piyush.mehta@xilinx.com>
Subject: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
Date: Fri, 5 Mar 2021 14:40:29 +0530 [thread overview]
Message-ID: <20210305091029.23378-1-piyush.mehta@xilinx.com> (raw)
Updated code with already prepared dev_err_probe(). It reduces code size
and simplifies EPROBE_DEFER handling.
Also, unify message format for similar error cases.
Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
---
This patch is based on ahci-ceva patches:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
Changes for V2:
- Address review comment- remove curly brackets {}.
---
drivers/ata/ahci_ceva.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
index b980218..50b56cd 100644
--- a/drivers/ata/ahci_ceva.c
+++ b/drivers/ata/ahci_ceva.c
@@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
NULL);
- if (IS_ERR(cevapriv->rst)) {
- if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get reset: %ld\n",
- PTR_ERR(cevapriv->rst));
- }
+ if (IS_ERR(cevapriv->rst))
+ dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
+ "failed to get reset\n");
hpriv = ahci_platform_get_resources(pdev, 0);
if (IS_ERR(hpriv))
--
2.7.4
next reply other threads:[~2021-03-05 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:10 Piyush Mehta [this message]
2021-04-06 14:11 ` [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe() Michal Simek
2021-04-06 15:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305091029.23378-1-piyush.mehta@xilinx.com \
--to=piyush.mehta@xilinx.com \
--cc=axboe@kernel.dk \
--cc=git@xilinx.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=sgoud@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.