All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Cline <jcline@redhat.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 2/2] kms_hdr: Fix bpc-switch tests on AMD hardware
Date: Fri,  5 Mar 2021 11:42:53 -0500	[thread overview]
Message-ID: <20210305164253.11788-3-jcline@redhat.com> (raw)
In-Reply-To: <20210305164253.11788-1-jcline@redhat.com>

Kernel commit b836a274b797 ("drm/amdgpu/dc: Require primary plane to be
enabled whenever the CRTC is") causes the bpc-switch tests to fail,
since the primary plane fb is being removed, which leads to the next
atomic commit failing with -EINVAL.

This stops the removal of the primary plane fb before switching to 10
bits per component and the test now runs successfully.

Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
 tests/kms_hdr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
index 7617e8a5..8aa3ea78 100644
--- a/tests/kms_hdr.c
+++ b/tests/kms_hdr.c
@@ -223,8 +223,6 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,
 			data->h = afb.height;
 		}
 
-		igt_plane_set_fb(data->primary, NULL);
-
 		/*
 		 * i915 driver doesn't expose max bpc as debugfs entry,
 		 * so limiting assert only for amd driver.
-- 
2.30.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-03-05 16:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 17:27 [igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix bpc-switch tests on AMD hardware Jeremy Cline
2021-02-19 18:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-19 19:35 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-19 22:00   ` Jeremy Cline
2021-03-05 16:42 ` [igt-dev] [PATCH i-g-t v2 0/2] Fix up the HDR tests for AMD devices Jeremy Cline
2021-03-05 16:42   ` [igt-dev] [PATCH i-g-t v2 1/2] kms_hdr: Skip HDR tests on pre-Kaby Lake Intel devices Jeremy Cline
2021-03-08  8:47     ` Petri Latvala
2021-03-08 12:41       ` Sharma, Swati2
2021-03-08 12:53         ` Petri Latvala
2021-03-08 15:06           ` Jeremy Cline
2021-03-09 14:01             ` Petri Latvala
2021-03-10 12:48               ` Shankar, Uma
2021-03-10 12:53                 ` Petri Latvala
2021-03-10 14:55                   ` Sharma, Swati2
2021-03-05 16:42   ` Jeremy Cline [this message]
2021-03-05 16:48     ` [igt-dev] [PATCH i-g-t v2 2/2] kms_hdr: Fix bpc-switch tests on AMD hardware Kazlauskas, Nicholas
2021-03-05 17:17 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_hdr: Fix bpc-switch tests on AMD hardware (rev2) Patchwork
2021-03-05 21:42 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-10 16:34 ` [igt-dev] [PATCH i-g-t v3] tests/kms_hdr: Fix bpc-switch tests on AMD hardware Jeremy Cline
2021-03-10 16:38   ` Shankar, Uma
2021-03-10 16:45 ` [igt-dev] ✗ Fi.CI.BUILD: failure for tests/kms_hdr: Fix bpc-switch tests on AMD hardware (rev3) Patchwork
2021-03-11  9:01   ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305164253.11788-3-jcline@redhat.com \
    --to=jcline@redhat.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.