From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07746C433DB for ; Wed, 10 Mar 2021 11:19:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A962664FD7 for ; Wed, 10 Mar 2021 11:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231958AbhCJLSa (ORCPT ); Wed, 10 Mar 2021 06:18:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbhCJLR7 (ORCPT ); Wed, 10 Mar 2021 06:17:59 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22FE9C06174A for ; Wed, 10 Mar 2021 03:17:59 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id u14so22874721wri.3 for ; Wed, 10 Mar 2021 03:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8/BvaC/nK4OARL6liXjkIyGeKizu5NW5s37p+jzN3rQ=; b=Psywx4DhVt3ugx3PIxZeB43//KWnVK4bTpb2dRxGAtIDzQ9t/VwoqLeTXFxEuYSBpX CMpuokQ6B+5jaKqmQP0KA4n9ha86S9L55WvCW3bmITc56n2AmeOV+/Z4rhSMpwRBwSEt BTspTOBFMnm6ftya42im4dgEPRLD9KzI83DFx5A0y7gJC6VBeGZgfvBJjBy27oDVk4mz PfKzL72xoDzNzYkkqn55uMjaFBw+jJbIZ8NlM59TxZBQjq18is1nRhjXUGCfFuonFcp7 UYCmvR4PeEIxdVeS7RyasXbzymv+eRKk5KAaI4fNR0iEYuzU+tPZih/J5b9KKUJQx+Qo Gipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8/BvaC/nK4OARL6liXjkIyGeKizu5NW5s37p+jzN3rQ=; b=c97Ez1H4CjokrKdMXzWzCvSrmVdiNktcrIFEUj4mgSaTk1Wg0QQmgSZQQvausTtt5f uSMT6trvfNk1rsmXYUUy33oS448yQNDRa54I52oClP/d3qk0bwSqdamfF4ulR0MN4rQ1 72eTuVHds/1oHf5aMxq9c4dwAs2FYB73YPxKHmMpEitYb6raBT1RNxIDXaW1E/HvQRtM KL9eQ+wak6k+jfhMISXMTKFVGqBm/eI9PIOHSzcrlavLJm8O3wu+NObLljaindsOVSVb 99Vloj8qrlyKrMcfYqMQC0gIEanwQ343gzilo/Dy5pxpcOungtVstmcuhti6x51peBdh dLbw== X-Gm-Message-State: AOAM532Rb4KYQf35so3pA7Gvj3jsW0+RyXINqkyDhJxrMTiG/Ob89eBw 2aXCgpV75LEapxMevCeKO6juRw== X-Google-Smtp-Source: ABdhPJx3IYKM3QBCdZT4QUUshLK1DxO4Zo6U2/nM97niWViFKQGFICLI7dFD9eafmhr+BAl2HPBtEA== X-Received: by 2002:adf:ed12:: with SMTP id a18mr3016460wro.249.1615375077845; Wed, 10 Mar 2021 03:17:57 -0800 (PST) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id h25sm3711077wml.32.2021.03.10.03.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 03:17:57 -0800 (PST) Date: Wed, 10 Mar 2021 11:17:55 +0000 From: Lee Jones To: "Vaittinen, Matti" Cc: linux-power , "linux-gpio@vger.kernel.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" Subject: Re: [PATCH v3 06/15] mfd: Add ROHM BD71815 ID Message-ID: <20210310111755.GN701493@dell> References: <20210310103639.GG701493@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, 10 Mar 2021, Vaittinen, Matti wrote: > Hello Lee, > > On Wed, 2021-03-10 at 10:36 +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Matti Vaittinen wrote: > > > > > Add chip ID for ROHM BD71815 and PMIC so that drivers can identify > > > this IC. > > > > > > Signed-off-by: Matti Vaittinen > > > Acked-for-MFD-by: Lee Jones > > > --- > > > include/linux/mfd/rohm-generic.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/linux/mfd/rohm-generic.h > > > b/include/linux/mfd/rohm-generic.h > > > index 66f673c35303..e5392bcbc098 100644 > > > --- a/include/linux/mfd/rohm-generic.h > > > +++ b/include/linux/mfd/rohm-generic.h > > > @@ -14,6 +14,7 @@ enum rohm_chip_type { > > > ROHM_CHIP_TYPE_BD71828, > > > ROHM_CHIP_TYPE_BD9571, > > > ROHM_CHIP_TYPE_BD9574, > > > + ROHM_CHIP_TYPE_BD71815, > > > > Is there a technical reason why these can't be re-ordered? > > No, I don't think so. > > BTW. there will probably be a (trivial) conflict here as both this > series and the BD9576/BD9573 series add an ID here. Let me guess, you'd That's fine. I will resolve that manually. > like to see them sorted? Wouldn't that be nice? :) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog