From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CCDC433DB for ; Wed, 10 Mar 2021 13:33:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E02E465000 for ; Wed, 10 Mar 2021 13:33:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E02E465000 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJyxe-0003q4-Ak for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 08:33:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJyu7-00018I-Uv for qemu-devel@nongnu.org; Wed, 10 Mar 2021 08:29:35 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJyu6-0007B0-0F for qemu-devel@nongnu.org; Wed, 10 Mar 2021 08:29:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615382970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ScCgNxIqd6sDHI2X3m9zVzuFaT/EbwN3SJtZcuNZOs=; b=TF5vT4upci6BY2Sp3UPFeGJDM4TgU2vU6s/VeiXwnsQazLbYXo9Ksv5kXOzBVvt8P3DUim ipeMGqE4oZbPyw9asiG3zGwkkID+H/y693iJccpWzJzmHkJeoI+JrazoMlqb6sRbjsfQz4 rzZJ9DFIWoFTUw/fxaL0rlf+d7MThmw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-Dot55fPuPren7dHkeTzhxQ-1; Wed, 10 Mar 2021 08:29:27 -0500 X-MC-Unique: Dot55fPuPren7dHkeTzhxQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA0FB57; Wed, 10 Mar 2021 13:29:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FE565C648; Wed, 10 Mar 2021 13:29:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8741F18000AC; Wed, 10 Mar 2021 14:29:20 +0100 (CET) Date: Wed, 10 Mar 2021 14:29:20 +0100 From: Gerd Hoffmann To: Akihiko Odaki Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID Message-ID: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> References: <20210303152948.59943-1-akihiko.odaki@gmail.com> <20210303152948.59943-2-akihiko.odaki@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210303152948.59943-2-akihiko.odaki@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Paul Durrant , "Michael S . Tsirkin" , qemu Developers , Anthony Perard , xen-devel@lists.xenproject.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > -static void xenfb_update_interval(void *opaque, uint64_t interval) > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) > - .update_interval = xenfb_update_interval, > + .ui_info = xenfb_ui_info, Hmm, I suspect xenfb really wants the actual refresh rate, even in case vnc/sdl change it dynamically. Anthony? Stefano? I guess we should just leave the update_interval callback as-is, for those who want know, and use ui_info->refresh_rate for the virtual edid refresh rate (which may not match the actual update interval in case of dynamic changes). Adding a comment explaining the difference to console.h is a good idea too. Otherwise looks good to me overall. Splitting the ui/gtk update to a separate patch is probably a good idea. take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61244C433E6 for ; Wed, 10 Mar 2021 13:29:46 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F61964E54 for ; Wed, 10 Mar 2021 13:29:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F61964E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.96060.181524 (Exim 4.92) (envelope-from ) id 1lJyu5-0003Ht-ID; Wed, 10 Mar 2021 13:29:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 96060.181524; Wed, 10 Mar 2021 13:29:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJyu5-0003Hm-Es; Wed, 10 Mar 2021 13:29:33 +0000 Received: by outflank-mailman (input) for mailman id 96060; Wed, 10 Mar 2021 13:29:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lJyu3-0003HV-Nb for xen-devel@lists.xenproject.org; Wed, 10 Mar 2021 13:29:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [63.128.21.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 4b0afa24-8af7-415b-ab02-b21d7528ff3a; Wed, 10 Mar 2021 13:29:31 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-380-Dot55fPuPren7dHkeTzhxQ-1; Wed, 10 Mar 2021 08:29:27 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA0FB57; Wed, 10 Mar 2021 13:29:25 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-141.ams2.redhat.com [10.36.112.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FE565C648; Wed, 10 Mar 2021 13:29:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8741F18000AC; Wed, 10 Mar 2021 14:29:20 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b0afa24-8af7-415b-ab02-b21d7528ff3a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615382971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8ScCgNxIqd6sDHI2X3m9zVzuFaT/EbwN3SJtZcuNZOs=; b=NglhDWUSJrq9TsrtcgHY7P6+KI+gjn10vZK4KsLHq/XHbBpScJ/jwybjhFclXOZBnkSRdF 6a/MvPjOOKwLDe41XeGcqjZYMLymQ9AmbFVvIsbEeHwJqTBXX3S3sqiJ88/nF3HU0MI47R 0zzK8+RN0tJRtnw9IKrNTXu8aIk9T5A= X-MC-Unique: Dot55fPuPren7dHkeTzhxQ-1 Date: Wed, 10 Mar 2021 14:29:20 +0100 From: Gerd Hoffmann To: Akihiko Odaki Cc: qemu Developers , xen-devel@lists.xenproject.org, "Michael S . Tsirkin" , Stefano Stabellini , Anthony Perard , Paul Durrant Subject: Re: [PATCH v2 2/2] virtio-gpu: Respect UI refresh rate for EDID Message-ID: <20210310132920.6rv5f62ineowzscq@sirius.home.kraxel.org> References: <20210303152948.59943-1-akihiko.odaki@gmail.com> <20210303152948.59943-2-akihiko.odaki@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210303152948.59943-2-akihiko.odaki@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > -static void xenfb_update_interval(void *opaque, uint64_t interval) > +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) > - .update_interval = xenfb_update_interval, > + .ui_info = xenfb_ui_info, Hmm, I suspect xenfb really wants the actual refresh rate, even in case vnc/sdl change it dynamically. Anthony? Stefano? I guess we should just leave the update_interval callback as-is, for those who want know, and use ui_info->refresh_rate for the virtual edid refresh rate (which may not match the actual update interval in case of dynamic changes). Adding a comment explaining the difference to console.h is a good idea too. Otherwise looks good to me overall. Splitting the ui/gtk update to a separate patch is probably a good idea. take care, Gerd