From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43DD9C433E6 for ; Wed, 10 Mar 2021 18:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C0AF64FD2 for ; Wed, 10 Mar 2021 18:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232875AbhCJStv (ORCPT ); Wed, 10 Mar 2021 13:49:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231858AbhCJStR (ORCPT ); Wed, 10 Mar 2021 13:49:17 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44223C061760; Wed, 10 Mar 2021 10:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4HgOUtZioTDMKUvW4dyz8tRE+AffCXG+nsSseXdbPJk=; b=P1Bdb0fRml2tffwzopV3LbuQkD XiK+O7Tn0dk24d5j4uLS37+YCyyHyF+OzWpE2WQ4j21wKUZ3s1bWAoGqsSm+u1yBzszeCgZ6Ne+3t L2Z6/sUTX4fqGXjHSwHwgQTiz8zodMisx9vQj9oOS9jjijt1TuElXLy+NYrybZaR4m2GpepX84laF OOtPDEjY3QNJpRE04Os1zOb/8/dLOqIY4hEQ0EPZkBLdyi7nfVXQajaWWEplm25vUVt5Oqm4Npoxr JAR3BcPz0JxaHZYrxaw9zt6NkR+HjFDjkHE8/yvTlOLpjdyLqW6m7PQwWfmacwqh/smZmoyS4VNQQ QlTzrJIA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lK3tI-004PX6-LW; Wed, 10 Mar 2021 18:49:07 +0000 Date: Wed, 10 Mar 2021 18:49:04 +0000 From: Matthew Wilcox To: William Kucharski Cc: "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Daniel Vetter , Ian Campbell , Jaya Kumar , Jani Nikula , Christoph Hellwig , "linux-mm@kvack.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations Message-ID: <20210310184904.GS3479805@casper.infradead.org> References: <20210310135128.846868-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote: > Looks good, just one super minor nit inline. > > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) > > > > BUG_ON(!fbdefio); > > cancel_delayed_work_sync(&info->deferred_work); > > - > > - /* clear out the mapping that we setup */ > > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) { > > - page = fb_deferred_io_page(info, i); > > - page->mapping = NULL; > > - } > > - > > mutex_destroy(&fbdefio->lock); > > } > > We no longer need the definition of "int i" right before the BUG_ON(). Huh. Usually gcc warns about that. let me figure that out and post a v2. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F5AC433E0 for ; Wed, 10 Mar 2021 18:49:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 771FB64DF4 for ; Wed, 10 Mar 2021 18:49:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 771FB64DF4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE1456E237; Wed, 10 Mar 2021 18:49:14 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id BA1156E237 for ; Wed, 10 Mar 2021 18:49:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4HgOUtZioTDMKUvW4dyz8tRE+AffCXG+nsSseXdbPJk=; b=P1Bdb0fRml2tffwzopV3LbuQkD XiK+O7Tn0dk24d5j4uLS37+YCyyHyF+OzWpE2WQ4j21wKUZ3s1bWAoGqsSm+u1yBzszeCgZ6Ne+3t L2Z6/sUTX4fqGXjHSwHwgQTiz8zodMisx9vQj9oOS9jjijt1TuElXLy+NYrybZaR4m2GpepX84laF OOtPDEjY3QNJpRE04Os1zOb/8/dLOqIY4hEQ0EPZkBLdyi7nfVXQajaWWEplm25vUVt5Oqm4Npoxr JAR3BcPz0JxaHZYrxaw9zt6NkR+HjFDjkHE8/yvTlOLpjdyLqW6m7PQwWfmacwqh/smZmoyS4VNQQ QlTzrJIA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lK3tI-004PX6-LW; Wed, 10 Mar 2021 18:49:07 +0000 Date: Wed, 10 Mar 2021 18:49:04 +0000 From: Matthew Wilcox To: William Kucharski Subject: Re: [PATCH] fb_defio: Remove custom address_space_operations Message-ID: <20210310184904.GS3479805@casper.infradead.org> References: <20210310135128.846868-1-willy@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-fbdev@vger.kernel.org" , Jani Nikula , Daniel Vetter , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , Ian Campbell , "linux-fsdevel@vger.kernel.org" , Jaya Kumar , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Mar 10, 2021 at 06:38:07PM +0000, William Kucharski wrote: > Looks good, just one super minor nit inline. > > @@ -228,13 +202,6 @@ void fb_deferred_io_cleanup(struct fb_info *info) > > > > BUG_ON(!fbdefio); > > cancel_delayed_work_sync(&info->deferred_work); > > - > > - /* clear out the mapping that we setup */ > > - for (i = 0 ; i < info->fix.smem_len; i += PAGE_SIZE) { > > - page = fb_deferred_io_page(info, i); > > - page->mapping = NULL; > > - } > > - > > mutex_destroy(&fbdefio->lock); > > } > > We no longer need the definition of "int i" right before the BUG_ON(). Huh. Usually gcc warns about that. let me figure that out and post a v2. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel