All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Winkler <danielwinkler@google.com>
To: linux-bluetooth@vger.kernel.org
Cc: chromeos-bluetooth-upstreaming@chromium.org,
	Daniel Winkler <danielwinkler@google.com>,
	Miao-chen Chou <mcchou@chromium.org>
Subject: [Bluez PATCH v4 2/3] client: Add adv SupportedFeatures to bluetoothctl
Date: Tue, 16 Mar 2021 16:22:16 -0700	[thread overview]
Message-ID: <20210316162044.Bluez.v4.2.I33cf8432f94675b635ab429b3125f54048c5b66a@changeid> (raw)
In-Reply-To: <20210316232217.3344489-1-danielwinkler@google.com>

This change adds SupportedFeatures to be shown in "show" option of
bluetoothctl. It was tested with and without kernel support for features
to verify that they are shown or not shown correctly.

Change was tested by verifying SupportedFeatures were populated
correctly in bluetoothctl on hatch and kukui chromebooks

Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
---

Changes in v4: None
Changes in v3: None
Changes in v2: None

 client/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/main.c b/client/main.c
index 79658a463..1669d2c89 100644
--- a/client/main.c
+++ b/client/main.c
@@ -942,6 +942,7 @@ static void cmd_show(int argc, char *argv[])
 		print_property(adapter->ad_proxy, "SupportedIncludes");
 		print_property(adapter->ad_proxy, "SupportedSecondaryChannels");
 		print_property(adapter->ad_proxy, "SupportedCapabilities");
+		print_property(adapter->ad_proxy, "SupportedFeatures");
 	}
 
 	if (adapter->adv_monitor_proxy) {
-- 
2.31.0.rc2.261.g7f71774620-goog


  parent reply	other threads:[~2021-03-16 23:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-16 23:22 [Bluez PATCH v4 0/3] Expose extended adv feature support via bluez API Daniel Winkler
2021-03-16 23:22 ` [Bluez PATCH v4 1/3] advertising: Add SupportedFeatures to LEAdvertisingManager1 Daniel Winkler
2021-03-16 23:37   ` Expose extended adv feature support via bluez API bluez.test.bot
2021-03-16 23:22 ` Daniel Winkler [this message]
2021-03-16 23:22 ` [Bluez PATCH v4 3/3] doc/advertising-api: Add adv SupportedFeatures to doc Daniel Winkler
2021-03-17 18:34 ` [Bluez PATCH v4 0/3] Expose extended adv feature support via bluez API Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316162044.Bluez.v4.2.I33cf8432f94675b635ab429b3125f54048c5b66a@changeid \
    --to=danielwinkler@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mcchou@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.