From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28196C433E5 for ; Thu, 25 Mar 2021 15:34:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F9E161A17 for ; Thu, 25 Mar 2021 15:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230436AbhCYPdr (ORCPT ); Thu, 25 Mar 2021 11:33:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbhCYPdU (ORCPT ); Thu, 25 Mar 2021 11:33:20 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42B1CC06174A for ; Thu, 25 Mar 2021 08:33:20 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id r12so3620739ejr.5 for ; Thu, 25 Mar 2021 08:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g9GEKEx/zawMMQH3jE5N7jL7nSXjAaXut7/DjvpdxrE=; b=ccQUKXxhuMdqCfExCIcK1He+UfmaJW8Y9RjuoHJQamxeaNNvZogOnvRuS2Mh61ga+P 5dsPKy3NgIzqeOnOSX0G1R9x89mqYPjrWjyQ8N8rS8g4/nz+cXzoXWasHTsniSIsqNRo YeA/2tsOCdY4BvAidGtFrl2Og5RsI3kEDGzj/zKgSheuez867u7g77gUzWSTkLO/V5ag jtlv8j7Jn+tR9CzVR0NV4q3qHqzvqxYL3w0yz8T/OAb+03A4xhXWBCoLG/FECjgcQbQJ /9P4QhzDG4nPTqjNaVxFTzWXXdzQ5Ys9Gzrs+eu7mI11S4dBzF6s0P2RTGAjVC35F50g JfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g9GEKEx/zawMMQH3jE5N7jL7nSXjAaXut7/DjvpdxrE=; b=G9Kcaz1ro7/qKtHweXDEGadNypxuX+Jmy6FGYolxt/E0+nYZOsYlNT77/PbrCkGKPG 8Zsr/iCFgsYu8HLdkXyj3CcowK1PCOFvBZmYIBwJjxWlX8B/wmBg58MSjjbnmvyO7oFx yI1onRNk+6Kixtp9QlkekssjG1D1OS1V2/GGiCsfjccgg704wxnFDH+TKRyvKdHoVofW cMMWzVyjTdE8oL7K3lp9zb8VzZlF3M3MOEriM23iy5HrIeUq0WwOUXEtzClmkwCnsQv+ ZuwkWObbxXEwCjpq42iGIK3twsP9/R13B3j6SVuyYEv46ykrGQOMT2t4mB1hOWkTe9l9 rJGA== X-Gm-Message-State: AOAM533kwIysnhzbCTc56MgOg44kK569hY5Q4A4Fyoyef7/hiKIFaCYY 9+OnxsEyP3uo0xTG1tnODHyFgnpYP82/KZjD X-Google-Smtp-Source: ABdhPJyJrFJ6rssqZH7KnlaI3l5upBsMBery1EpBIE6S8dnFhkRMBVvX3u5aJ6hqMvATr6BSSPQy1Q== X-Received: by 2002:a17:906:a86:: with SMTP id y6mr10322474ejf.354.1616686398875; Thu, 25 Mar 2021 08:33:18 -0700 (PDT) Received: from gkim-laptop.fkb.profitbricks.net (ip5f5aeee5.dynamic.kabel-deutschland.de. [95.90.238.229]) by smtp.googlemail.com with ESMTPSA id n26sm2854750eds.22.2021.03.25.08.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 08:33:18 -0700 (PDT) From: Gioh Kim To: linux-rdma@vger.kernel.org Cc: bvanassche@acm.org, leon@kernel.org, dledford@redhat.com, jgg@ziepe.ca, haris.iqbal@ionos.com, jinpu.wang@ionos.com, Guoqing Jiang , Guoqing Jiang , Danil Kipnis , Gioh Kim Subject: [PATCH for-next 07/22] RDMA/rtrs-clt: Remove redundant code from rtrs_clt_read_req Date: Thu, 25 Mar 2021 16:32:53 +0100 Message-Id: <20210325153308.1214057-8-gi-oh.kim@ionos.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210325153308.1214057-1-gi-oh.kim@ionos.com> References: <20210325153308.1214057-1-gi-oh.kim@ionos.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Guoqing Jiang There is no need to dereference 's' from 'sess', since we have "sess = to_clt_sess(s)" before. And we can deference 'dev' from 's' earlier. Signed-off-by: Guoqing Jiang Reviewed-by: Danil Kipnis Signed-off-by: Gioh Kim Signed-off-by: Jack Wang --- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c index bfb5be5481e7..dd841121dc2c 100644 --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c @@ -1055,7 +1055,7 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req) struct rtrs_sess *s = con->c.sess; struct rtrs_clt_sess *sess = to_clt_sess(s); struct rtrs_msg_rdma_read *msg; - struct rtrs_ib_dev *dev; + struct rtrs_ib_dev *dev = sess->s.dev; struct ib_reg_wr rwr; struct ib_send_wr *wr = NULL; @@ -1065,9 +1065,6 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req) const size_t tsize = sizeof(*msg) + req->data_len + req->usr_len; - s = &sess->s; - dev = sess->s.dev; - if (unlikely(tsize > sess->chunk_size)) { rtrs_wrn(s, "Read request failed, message size is %zu, bigger than CHUNK_SIZE %d\n", -- 2.25.1