Re: [Intel-gfx] [PATCH v5 16/16] of: Add plumbing for restricted DMA pool

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2492 bytes --]

Hi Claire,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20210421]
[cannot apply to swiotlb/linux-next robh/for-next xen-tip/linux-next linus/master v5.12-rc8 v5.12-rc7 v5.12-rc6 v5.12-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Claire-Chang/Restricted-DMA/20210422-161942
base:    b74523885a715463203d4ccc3cf8c85952d3701a
config: um-allmodconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/2c0a859fc4095e12d1119617c6fd60037cfde731
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Claire-Chang/Restricted-DMA/20210422-161942
        git checkout 2c0a859fc4095e12d1119617c6fd60037cfde731
        # save the attached .config to linux build tree
        make W=1 W=1 ARCH=um 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/of/address.c:1113:5: warning: no previous prototype for 'of_dma_set_restricted_buffer' [-Wmissing-prototypes]
    1113 | int of_dma_set_restricted_buffer(struct device *dev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/of_dma_set_restricted_buffer +1113 drivers/of/address.c

  1112	
> 1113	int of_dma_set_restricted_buffer(struct device *dev)
  1114	{
  1115		struct device_node *node;
  1116		int count, i;
  1117	
  1118		if (!dev->of_node)
  1119			return 0;
  1120	
  1121		count = of_property_count_elems_of_size(dev->of_node, "memory-region",
  1122							sizeof(phandle));
  1123		for (i = 0; i < count; i++) {
  1124			node = of_parse_phandle(dev->of_node, "memory-region", i);
  1125			/* There might be multiple memory regions, but only one
  1126			 * restriced-dma-pool region is allowed.
  1127			 */
  1128			if (of_device_is_compatible(node, "restricted-dma-pool") &&
  1129			    of_device_is_available(node))
  1130				return of_reserved_mem_device_init_by_idx(
  1131					dev, dev->of_node, i);
  1132		}
  1133	
  1134		return 0;
  1135	}
  1136	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24602 bytes --]