All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tong Zhang <ztong0001@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tong Zhang <ztong0001@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge
Date: Mon, 26 Apr 2021 18:07:27 -0400	[thread overview]
Message-ID: <20210426220728.1230340-1-ztong0001@gmail.com> (raw)

the PCI bridge might be NULL, so we'd better check before use it

[    1.246492] BUG: kernel NULL pointer dereference, address: 00000000000000c0
[    1.248731] RIP: 0010:pci_read_config_byte+0x5/0x40
[    1.253998] Call Trace:
[    1.254131]  ? alcor_pci_find_cap_offset.isra.0+0x3a/0x100 [alcor_pci]
[    1.254476]  alcor_pci_probe+0x169/0x2d5 [alcor_pci]

Signed-off-by: Tong Zhang <ztong0001@gmail.com>
---
 drivers/misc/cardreader/alcor_pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/misc/cardreader/alcor_pci.c b/drivers/misc/cardreader/alcor_pci.c
index cd402c89189e..1c33453fd5c7 100644
--- a/drivers/misc/cardreader/alcor_pci.c
+++ b/drivers/misc/cardreader/alcor_pci.c
@@ -102,6 +102,9 @@ static int alcor_pci_find_cap_offset(struct alcor_pci_priv *priv,
 	u8 val8;
 	u32 val32;
 
+	if (!pci)
+		return 0;
+
 	where = ALCOR_CAP_START_OFFSET;
 	pci_read_config_byte(pci, where, &val8);
 	if (!val8)
-- 
2.25.1


             reply	other threads:[~2021-04-26 22:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 22:07 Tong Zhang [this message]
2021-05-10 14:36 ` [PATCH] misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge Greg Kroah-Hartman
2021-05-10 22:20   ` Tong Zhang
2021-05-11  7:03     ` Greg Kroah-Hartman
2021-05-11 17:17       ` Tong Zhang
2021-05-11 17:57         ` Greg Kroah-Hartman
2021-05-11 21:29           ` [PATCH v2] " Tong Zhang
2021-05-12  6:24             ` Greg Kroah-Hartman
2021-05-12 16:24               ` Tong Zhang
2021-05-12 16:41                 ` Greg Kroah-Hartman
2021-05-13  4:07                   ` [PATCH v3] " Tong Zhang
2021-05-19  8:40                     ` Dan Carpenter
2021-05-19 20:20                       ` Tong Zhang
2021-05-13  4:09                   ` [PATCH v2] " Tong Zhang
2021-05-11 21:32           ` [PATCH] " Tong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426220728.1230340-1-ztong0001@gmail.com \
    --to=ztong0001@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.