From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Stefan Berger <stefanb@linux.ibm.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/3] ima-evm-utils: Allow manual setting keyid for signing
Date: Wed, 5 May 2021 02:43:18 +0300 [thread overview]
Message-ID: <20210504234318.GC10037@altlinux.org> (raw)
In-Reply-To: <20210504231804.wxewx6wvc5rezxm7@altlinux.org>
On Wed, May 05, 2021 at 02:18:04AM +0300, Vitaly Chikunov wrote:
> Stefan,
>
> On Tue, May 04, 2021 at 08:51:03AM -0400, Stefan Berger wrote:
> > > @@ -932,8 +932,10 @@ static int sign_hash_v2(const char *algo, const unsigned char *hash,
> > > return -1;
> > > }
> > > - calc_keyid_v2(&keyid, name, pkey);
> > > - hdr->keyid = keyid;
> > > + if (imaevm_params.keyid)
> > > + hdr->keyid = htonl(imaevm_params.keyid);
> >
> >
> > Nit: Since existing code uses __be32_to_cpup I would use __cpu_to_be32 here.
>
> That __be32_to_cpup usage is highly dubious. Perhaps, it should be
> converted to some user-space and standard functions like be32toh(3).
By the way, be32toh() is identical to ntohl().
I wonder what was the reason for the existing code to use these obscure
linux-specific functions instead of posix interface described in
byteorder(3)?
--
ldv
next prev parent reply other threads:[~2021-05-04 23:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 4:33 [PATCH v2 0/3] ima-evm-utils: Add --keyid option Vitaly Chikunov
2021-05-04 4:33 ` [PATCH v2 1/3] ima-evm-utils: Allow manual setting keyid for signing Vitaly Chikunov
2021-05-04 12:51 ` Stefan Berger
2021-05-04 23:18 ` Vitaly Chikunov
2021-05-04 23:43 ` Dmitry V. Levin [this message]
2021-05-06 1:15 ` Vitaly Chikunov
2021-05-04 4:33 ` [PATCH v2 2/3] ima-evm-utils: Allow manual setting keyid from a cert file Vitaly Chikunov
2021-05-04 13:04 ` Stefan Berger
2021-05-04 23:21 ` Vitaly Chikunov
2021-05-04 13:28 ` Stefan Berger
2021-05-04 4:33 ` [PATCH v2 3/3] ima-evm-utils: Read keyid from the cert appended to the key file Vitaly Chikunov
2021-05-04 13:38 ` Stefan Berger
2021-05-04 22:27 ` Vitaly Chikunov
2021-05-05 1:04 ` Stefan Berger
2021-05-05 1:15 ` Vitaly Chikunov
2021-05-05 5:15 ` Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504234318.GC10037@altlinux.org \
--to=ldv@altlinux.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=vt@altlinux.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.