From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808AAC43461 for ; Wed, 5 May 2021 12:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DEAB611AC for ; Wed, 5 May 2021 12:28:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233278AbhEEM3w (ORCPT ); Wed, 5 May 2021 08:29:52 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3023 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231633AbhEEM3v (ORCPT ); Wed, 5 May 2021 08:29:51 -0400 Received: from fraeml735-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FZwm33Mzmz6rlcW; Wed, 5 May 2021 20:20:51 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml735-chm.china.huawei.com (10.206.15.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 14:28:53 +0200 Received: from localhost (10.52.120.138) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 13:28:52 +0100 Date: Wed, 5 May 2021 13:27:13 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: , , Ezequiel Garcia , Hans Verkuil , "Krzysztof Kozlowski" , Mauro Carvalho Chehab , Sylwester Nawrocki , , , , Subject: Re: [PATCH 07/25] media: exynos-gsc: don't resume at remove time Message-ID: <20210505132713.000000ba@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.120.138] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 May 2021 11:41:57 +0200 Mauro Carvalho Chehab wrote: > Calling pm_runtime_get_sync() at driver's removal time is not > needed, as this will resume PM runtime. Also, the PM runtime > code at pm_runtime_disable() already calls it, if it detects > the need. > > So, change the logic in order to disable PM runtime earlier. > > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab Seems sensible and a lot more along the lines of what I'd expect to see than was originally here. Reviewed-by: Jonathan Cameron > --- > drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c > index 9f41c2e7097a..f49f3322f835 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-core.c > +++ b/drivers/media/platform/exynos-gsc/gsc-core.c > @@ -1210,18 +1210,19 @@ static int gsc_remove(struct platform_device *pdev) > struct gsc_dev *gsc = platform_get_drvdata(pdev); > int i; > > - pm_runtime_get_sync(&pdev->dev); > - > gsc_unregister_m2m_device(gsc); > v4l2_device_unregister(&gsc->v4l2_dev); > > vb2_dma_contig_clear_max_seg_size(&pdev->dev); > - for (i = 0; i < gsc->num_clocks; i++) > - clk_disable_unprepare(gsc->clock[i]); > > - pm_runtime_put_noidle(&pdev->dev); > pm_runtime_disable(&pdev->dev); > > + if (!pm_runtime_status_suspended(&pdev->dev)) > + for (i = 0; i < gsc->num_clocks; i++) > + clk_disable_unprepare(gsc->clock[i]); > + > + pm_runtime_set_suspended(&pdev->dev); > + > dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name); > return 0; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ABAC433ED for ; Wed, 5 May 2021 12:31:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64E4A613B3 for ; Wed, 5 May 2021 12:31:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64E4A613B3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1Wwb7zxAP9S9/SpOxb4+2qwGs8QPYRLK+CiICwFHi5o=; b=GBrmGCdMuNi7/SUpsJPY3n67I jNusrsun7HYyOmfbq5/vzQ7sQ+CWwWOGHSsWG+o15O3fBv3tIO9/h5gFW1l73eAoH09Kf3MyhCsor JZgGWRAdU4O9kV3Jbnyk6OPy7vTTju0wScBzNJ/NIFKtI3oio3Ov1f3J4gqsJzaNs7X+hApmM/xRE 9/MweCFkIgodfgBmOP4c3uD3icWm/2xHyxwfy0EQmEJekwlYKNZEawo3atI+ODIA6BlCzuohyHX/P GCFQJ2QMquejswoq2ZW8wrUP8/vQPUAjQdP7LV7AAjiwKkAzrUSW4f+pZRIbSOqXCcW6ZkKtzgzUr 6vN3rvnHQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leGeC-001CEJ-I7; Wed, 05 May 2021 12:29:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leGe9-001CDo-Oo for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 12:28:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=adtEaEJOlwo0FnI6tsqTkFg+lti7RtSdybIwYZgblGc=; b=V0wTNWCkI7dgjtpKJ4NWTorvkh d++pMgwAAXOzA2vpIQ1lHRTpX3d6ZSQnlpu0nSaK0/aUEPeQ2/sBT8/OcITnJUFPLXVlYSUOeb7i0 Ka+KqcDmD3O6XgZ0efKOHO0krvJNiDyOPJug9D1uOxGbCXev3qMhscmYS2YPi5TTWzQoSnKgKlfMC vfIxe6PK9ZuklpNCRdMIXBZzgqWwOrwWsQSRuJ7hu9Yzd0YgqfFsNtZvSnLUv7Siuvzxrp3GgXwng sh73O5qHvKujquY4FG8eDWm0X4J/gfsy/H94JiY6uMp/P4vorp1nConpxrme3TAqIpkKmBkZ+gpVZ B7h6FLDA==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leGe7-004kBX-5d for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 12:28:56 +0000 Received: from fraeml735-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FZwm33Mzmz6rlcW; Wed, 5 May 2021 20:20:51 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml735-chm.china.huawei.com (10.206.15.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 14:28:53 +0200 Received: from localhost (10.52.120.138) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 13:28:52 +0100 Date: Wed, 5 May 2021 13:27:13 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: , , Ezequiel Garcia , Hans Verkuil , "Krzysztof Kozlowski" , Mauro Carvalho Chehab , Sylwester Nawrocki , , , , Subject: Re: [PATCH 07/25] media: exynos-gsc: don't resume at remove time Message-ID: <20210505132713.000000ba@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.120.138] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_052855_391430_CCC7C529 X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 5 May 2021 11:41:57 +0200 Mauro Carvalho Chehab wrote: > Calling pm_runtime_get_sync() at driver's removal time is not > needed, as this will resume PM runtime. Also, the PM runtime > code at pm_runtime_disable() already calls it, if it detects > the need. > > So, change the logic in order to disable PM runtime earlier. > > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab Seems sensible and a lot more along the lines of what I'd expect to see than was originally here. Reviewed-by: Jonathan Cameron > --- > drivers/media/platform/exynos-gsc/gsc-core.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c > index 9f41c2e7097a..f49f3322f835 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-core.c > +++ b/drivers/media/platform/exynos-gsc/gsc-core.c > @@ -1210,18 +1210,19 @@ static int gsc_remove(struct platform_device *pdev) > struct gsc_dev *gsc = platform_get_drvdata(pdev); > int i; > > - pm_runtime_get_sync(&pdev->dev); > - > gsc_unregister_m2m_device(gsc); > v4l2_device_unregister(&gsc->v4l2_dev); > > vb2_dma_contig_clear_max_seg_size(&pdev->dev); > - for (i = 0; i < gsc->num_clocks; i++) > - clk_disable_unprepare(gsc->clock[i]); > > - pm_runtime_put_noidle(&pdev->dev); > pm_runtime_disable(&pdev->dev); > > + if (!pm_runtime_status_suspended(&pdev->dev)) > + for (i = 0; i < gsc->num_clocks; i++) > + clk_disable_unprepare(gsc->clock[i]); > + > + pm_runtime_set_suspended(&pdev->dev); > + > dev_dbg(&pdev->dev, "%s driver unloaded\n", pdev->name); > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel