From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A7AC433ED for ; Thu, 13 May 2021 15:58:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C44861358 for ; Thu, 13 May 2021 15:58:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C44861358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=X/gGu2k8KJXA0C7mV3b81RtlAc+VaF5SDA+nmJaJwV8=; b=WWE5SCWwfMgHZwprbpdxuW4/R nTzg5iFkklw2iPsx6hOCpb2KvKRWKlb3mEVGlx4bq/5Zg/e822cp/Fk97vSzWFaGs5M4jeo4yUfIq 4J9AdsLTEy4IvqBBHClWPBdlDHRDooD3sJY7ujkS4OqGJoeYaEsWeZRPTB+TitZ5FlzhWyXV6Wm9+ FVpcLit8XFZSNIKa1OuQ39uIrlvbUofLB5WoOochscwFraChsIUYvg776H7eHHgLt8Qhk/r3m+v4M ZpzhsL3g9CbSldh4Wf2T0EDoKFQ8Jkn3r1kIJ04/inO0JXT0RUQ14c2cjXMBj9if207tfh3ySL/Eh uX1hHh9HA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhDhc-005vWR-Ht; Thu, 13 May 2021 15:56:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhDhX-005vVx-HN for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 15:56:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ifPJCcWCVT69xqfGXj2fK/dDLia8qfOL8hR6i6t59mY=; b=3VeNdFRhsojsnPsm4A+z7SFciN 6a6lkf/fT2nSnBZk5ubkd0mXQOnnVpEuitpiS80U+VT0o3gRZNJovMo4IGpxNkzvbdHVTWOqUjLIQ cPKZOrmaObY3795bXJW3PhXncxUqV20ai6x0UQdAA4NZnkzQeb6ghx+CWaDAfovG4Otb4eR/dj35e 4s9qEWuYCAdTz1+hn493ySoJeEFjI9ffnxBScIb3O/obHd7Q2cpOiUpyPA4tURa/owwmtCNFiUV6u 15CCXqhGfbsltcZXDJdrtyisg4EAno9UAYh57WzCYBM0DF6nkqHb6/a8u0SlqlJIvrdNOUqdX7qBf /V7KlsdQ==; Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhDhU-00BN0T-Lm for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 15:56:38 +0000 Received: by mail-pg1-x532.google.com with SMTP id m124so21786082pgm.13 for ; Thu, 13 May 2021 08:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ifPJCcWCVT69xqfGXj2fK/dDLia8qfOL8hR6i6t59mY=; b=wQppmLS165jeFIPHSwM+yQPVM8+/jm0oz1WKTbJv2Aa0IL+101QKHkIKUuOsbpgSjK Ye7sv3aLHOrmJF5keHaO9VG5YpSk07i7m86aODJvcizilR/Lo+Ko2sm6m95+floJ5cRt L6xGiKtO51eLhJmnYVViVZQSU/5Wo/Xk28Yi0nUVYsvYgzL3gfpygIIZ+xvwM4463qqH 4Wm0u8ejd7VgxgyD5Dw2lE8GeZ2QYskUo8hE8KggmtvXw2+/tlwYuREPFG+TkTR062Ny GkkwQCu45Mra0uASPxDpaPT89XK5ZfC8CxPIpxU/dQ5QT0idHPZX3KhDLEMfgUVoyKHl h43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ifPJCcWCVT69xqfGXj2fK/dDLia8qfOL8hR6i6t59mY=; b=pGq1JBA1Qz8CLjdnbht9iodM8dL85dNB3OBwvk70xgk1hc/VmxETUE7wVQa7DnhaIh NQ1nftHFjY0qdHUNfII7L8ogk5Pt9UsY2UokbndU0EqCUXVk/tN8V1Ar3/KLsarJuvT2 Zn+/ZHaW306FOuVI82RGXufd5aO2HDOTqXpvl/4MCP2g0U7wko6R5gWaD1klnD5ZXgDc 6KJrfkcRa/MTvzL8vnWpZ6N2VDBNKv0tWSLZeBUVWu06v6UOvqcEDM9WTuaoupUgV4CT mh9f2SfMCqPJ2SMEK9zaDDqUtKQILH9oROctMu2szVChlCdoBXqgFwil6dgRfcbi0yu8 jjRA== X-Gm-Message-State: AOAM531jZd1Aw+v+SoAQgc85hDDKrHzJIgHs+ur8ADJyaNElBuj5XLuf Kjyu+JZwGpBzOV3xYsFnIqkNlQ== X-Google-Smtp-Source: ABdhPJzOQIqFTZWPOUic9Rva46CLmbb96/QirS+8DRhvYO5MfA5iZFXSdA0sJWFr6t/mWhJpulQEbQ== X-Received: by 2002:aa7:8501:0:b029:2cf:c0b8:4b88 with SMTP id v1-20020aa785010000b02902cfc0b84b88mr6757359pfn.61.1620921395739; Thu, 13 May 2021 08:56:35 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id x10sm2449457pfp.177.2021.05.13.08.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 08:56:34 -0700 (PDT) Date: Thu, 13 May 2021 09:56:33 -0600 From: Mathieu Poirier To: Mike Leach Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, leo.yan@linaro.org Subject: Re: [RFC PATCH 0/8] coresight: syscfg: dynamic load, resource management Message-ID: <20210513155633.GA225418@xps15> References: <20210512211752.4103-1-mike.leach@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210512211752.4103-1-mike.leach@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_085636_804883_FE4B8339 X-CRM114-Status: GOOD ( 23.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Mike, On Wed, May 12, 2021 at 10:17:44PM +0100, Mike Leach wrote: > This patchset represents the second phase of CoreSight configuration > management. > > 1) API updated to allow dynamic load and unload of configurations and > features. Dependency management between loaded sets is added. > > 2) New configuration and feature sets can be added using a loadable module. > An example in /samples/coresight is provided to demonstrate this. > I tried to compile the sample module and I get: samples/coresight/coresight-cfg-sample.c:7:10: fatal error: coresight-config.h: No such file or directory #include "coresight-config.h" ^~~~~~~~~~~~~~~~~~~~ compilation terminated. Can you reproduce on your side? Thanks, Mathieu > 3) Resource management API is added. This allows the system to ensure that > loaded configurations and features are only loaded onto devices that can > support them. > > Further - it ensures that configurations with multiple features cannot over > allocate resources. > > 4) configfs can be used to activate a configuration which will then be used > when controlling tracing using sysfs. > > 5) Resource management is added to ETMv4 configurations. This allows current > and future features and configurations to be defined in terms of resources > used as well as registers to be programmed. > > Defining features in this way allows the resource management to operate > correctly. > > The perf event parsing is also adjusted to allow the ETM resources requested > on the command line (e.g. address filters, etc) to be correctly handled > using resoruce management alongside the complex configurations such as > autofdo. > > Applies to coresight/next - which is 5.13-rc1 + initial Coresight configuration > patchset. > > To follow in future revisions / sets:- > a) load of additional config and features by configfs > b) ECT and CTI and other Coresight components support for configuration and > features. > > > Mike Leach (8): > coresight: syscfg: Update API to allow dynamic load and unload > coresight: syscfg: Update load API for config loadable modules > coresight: syscfg: Example CoreSight configuration loadable module > coresight: configfs: Allow configfs to activate configuration. > coresight: syscfg: Add API to check and validate device resources. > coresight: etm4x: syscfg: Add resource management to etm4x. > coresight: etm4x: Update perf event resource handling. > coresight: etm4x: Update configuration example. > > MAINTAINERS | 1 + > .../hwtracing/coresight/coresight-cfg-afdo.c | 38 +- > .../coresight/coresight-cfg-preload.c | 9 +- > .../hwtracing/coresight/coresight-config.c | 71 ++- > .../hwtracing/coresight/coresight-config.h | 45 +- > .../hwtracing/coresight/coresight-etm4x-cfg.c | 533 ++++++++++++++++++ > .../hwtracing/coresight/coresight-etm4x-cfg.h | 196 ++++++- > .../coresight/coresight-etm4x-core.c | 250 +++----- > .../coresight/coresight-syscfg-configfs.c | 87 +++ > .../coresight/coresight-syscfg-configfs.h | 4 + > .../hwtracing/coresight/coresight-syscfg.c | 390 +++++++++++-- > .../hwtracing/coresight/coresight-syscfg.h | 38 +- > include/linux/coresight.h | 2 + > samples/Kconfig | 9 + > samples/Makefile | 1 + > samples/coresight/Makefile | 4 + > samples/coresight/coresight-cfg-sample.c | 73 +++ > 17 files changed, 1511 insertions(+), 240 deletions(-) > create mode 100644 samples/coresight/Makefile > create mode 100644 samples/coresight/coresight-cfg-sample.c > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel