All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Shen <shenyang39@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Yang Shen <shenyang39@huawei.com>, Bin Luo <luobin9@huawei.com>
Subject: [PATCH v2 12/24] net: huawei: hinic: Fix wrong function name in comments
Date: Mon, 17 May 2021 12:45:23 +0800	[thread overview]
Message-ID: <20210517044535.21473-13-shenyang39@huawei.com> (raw)
In-Reply-To: <20210517044535.21473-1-shenyang39@huawei.com>

Fixes the following W=1 kernel build warning(s):
 drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c:604: warning: expecting prototype for cmdq_arm_ceq_handler(). Prototype was for cmdq_sync_cmd_handler() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:59: warning: expecting prototype for get_capability(). Prototype was for parse_capability() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:101: warning: expecting prototype for get_cap_from_fw(). Prototype was for get_capability() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:355: warning: expecting prototype for clear_io_resource(). Prototype was for clear_io_resources() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c:1100: warning: expecting prototype for hinic_hwdev_get_sq(). Prototype was for hinic_hwdev_get_rq() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_if.c:341: warning: expecting prototype for dma_attr_table_init(). Prototype was for dma_attr_init() instead
 drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c:904: warning: expecting prototype for hinic_put_wqe(). Prototype was for hinic_rq_put_wqe() instead
 drivers/net/ethernet/huawei/hinic/hinic_main.c:241: warning: expecting prototype for create_txqs(). Prototype was for create_rxqs() instead
 drivers/net/ethernet/huawei/hinic/hinic_main.c:295: warning: expecting prototype for free_txqs(). Prototype was for free_rxqs() instead
 drivers/net/ethernet/huawei/hinic/hinic_tx.c:667: warning: expecting prototype for free_all_rx_skbs(). Prototype was for free_all_tx_skbs() instead

Cc: Bin Luo <luobin9@huawei.com>
Signed-off-by: Yang Shen <shenyang39@huawei.com>
---
 drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c  | 8 ++++----
 drivers/net/ethernet/huawei/hinic/hinic_hw_if.c   | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c   | 2 +-
 drivers/net/ethernet/huawei/hinic/hinic_main.c    | 4 ++--
 drivers/net/ethernet/huawei/hinic/hinic_tx.c      | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
index 577cb2cffff2..307a6d4af993 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c
@@ -594,7 +594,7 @@ static void cmdq_update_errcode(struct hinic_cmdq *cmdq, u16 prod_idx,
 }
 
 /**
- * cmdq_arm_ceq_handler - cmdq completion event handler for sync command
+ * cmdq_sync_cmd_handler - cmdq completion event handler for sync command
  * @cmdq: the cmdq of the command
  * @cons_idx: the consumer index to update the error code for
  * @errcode: the error code
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
index 19a91c0223a7..428108eb10d2 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c
@@ -48,7 +48,7 @@ enum io_status {
 };
 
 /**
- * get_capability - convert device capabilities to NIC capabilities
+ * parse_capability - convert device capabilities to NIC capabilities
  * @hwdev: the HW device to set and convert device capabilities for
  * @dev_cap: device capabilities from FW
  *
@@ -92,7 +92,7 @@ static int parse_capability(struct hinic_hwdev *hwdev,
 }
 
 /**
- * get_cap_from_fw - get device capabilities from FW
+ * get_capability - get device capabilities from FW
  * @pfhwdev: the PF HW device to get capabilities for
  *
  * Return 0 - Success, negative - Failure
@@ -346,7 +346,7 @@ static int wait_for_db_state(struct hinic_hwdev *hwdev)
 }
 
 /**
- * clear_io_resource - set the IO resources as not active in the NIC
+ * clear_io_resources - set the IO resources as not active in the NIC
  * @hwdev: the NIC HW device
  *
  * Return 0 - Success, negative - Failure
@@ -1090,7 +1090,7 @@ struct hinic_sq *hinic_hwdev_get_sq(struct hinic_hwdev *hwdev, int i)
 }
 
 /**
- * hinic_hwdev_get_sq - get RQ
+ * hinic_hwdev_get_rq - get RQ
  * @hwdev: the NIC HW device
  * @i: the position of the RQ
  *
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
index 55b327eebe64..0428faa68e80 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_if.c
@@ -334,7 +334,7 @@ static void set_dma_attr(struct hinic_hwif *hwif, u32 entry_idx,
 }
 
 /**
- * dma_attr_table_init - initialize the default dma attributes
+ * dma_attr_init - initialize the default dma attributes
  * @hwif: the HW interface of a pci function device
  **/
 static void dma_attr_init(struct hinic_hwif *hwif)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
index dcba4d009bad..336248aa2e48 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_qp.c
@@ -894,7 +894,7 @@ struct hinic_rq_wqe *hinic_rq_read_next_wqe(struct hinic_rq *rq,
 }
 
 /**
- * hinic_put_wqe - release the ci for new wqes
+ * hinic_rq_put_wqe - release the ci for new wqes
  * @rq: recv queue
  * @cons_idx: consumer index of the wqe
  * @wqe_size: the size of the wqe
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_main.c b/drivers/net/ethernet/huawei/hinic/hinic_main.c
index 1da5997f034c..405ee4d2d2b1 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_main.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_main.c
@@ -232,7 +232,7 @@ static void free_txqs(struct hinic_dev *nic_dev)
 }
 
 /**
- * create_txqs - Create the Logical Rx Queues of specific NIC device
+ * create_rxqs - Create the Logical Rx Queues of specific NIC device
  * @nic_dev: the specific NIC device
  *
  * Return 0 - Success, negative - Failure
@@ -288,7 +288,7 @@ static int create_rxqs(struct hinic_dev *nic_dev)
 }
 
 /**
- * free_txqs - Free the Logical Rx Queues of specific NIC device
+ * free_rxqs - Free the Logical Rx Queues of specific NIC device
  * @nic_dev: the specific NIC device
  **/
 static void free_rxqs(struct hinic_dev *nic_dev)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_tx.c b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
index 7bd414aed6ff..c5bdb0d374ef 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_tx.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_tx.c
@@ -660,7 +660,7 @@ static void tx_free_skb(struct hinic_dev *nic_dev, struct sk_buff *skb,
 }
 
 /**
- * free_all_rx_skbs - free all skbs in tx queue
+ * free_all_tx_skbs - free all skbs in tx queue
  * @txq: tx queue
  **/
 static void free_all_tx_skbs(struct hinic_txq *txq)
-- 
2.17.1


  parent reply	other threads:[~2021-05-17  7:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  4:45 [PATCH v2 00/24] Rid W=1 warnings in net Yang Shen
2021-05-17  4:45 ` [PATCH v2 01/24] net: arc: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 02/24] net: atheros: atl1c: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 03/24] net: atheros: atl1e: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 04/24] net: atheros: atl1x: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 05/24] net: broadcom: bnx2x: " Yang Shen
2021-05-19  9:30   ` [EXT] " Sudarsana Reddy Kalluru
2021-05-17  4:45 ` [PATCH v2 06/24] net: brocade: bna: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 07/24] net: cadence: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 08/24] net: calxeda: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 09/24] net: chelsio: cxgb3: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 10/24] net: chelsio: cxgb4: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 11/24] net: chelsio: cxgb4vf: " Yang Shen
2021-05-17  4:45 ` Yang Shen [this message]
2021-05-17  4:45 ` [PATCH v2 13/24] net: micrel: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 14/24] net: microchip: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 15/24] net: neterion: Fix wrong function name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 16/24] net: neterion: vxge: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 17/24] net: netronome: nfp: " Yang Shen
2021-05-17 10:00   ` Simon Horman
2021-05-17  4:45 ` [PATCH v2 18/24] net: calxeda: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 19/24] net: samsung: sxgbe: " Yang Shen
2021-05-17  4:45 ` [PATCH v2 20/24] net: socionext: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 21/24] net: ti: Fix wrong struct name in comments Yang Shen
2021-05-17  4:45 ` [PATCH v2 22/24] net: via: Fix wrong function " Yang Shen
2021-05-17  4:45 ` [PATCH v2 23/24] net: phy: Demote non-compliant kernel-doc headers Yang Shen
2021-05-17  4:45 ` [PATCH v2 24/24] net: hisilicon: hns: Fix wrong function name in comments Yang Shen
2021-05-17 21:20 ` [PATCH v2 00/24] Rid W=1 warnings in net patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210517044535.21473-13-shenyang39@huawei.com \
    --to=shenyang39@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luobin9@huawei.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.