From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Hannes Reinecke <hare@suse.de>,
Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@wdc.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCHv4] nvme: allow to re-attach namespaces after all paths are down
Date: Tue, 18 May 2021 08:57:10 +0200 [thread overview]
Message-ID: <20210518065710.GA8255@lst.de> (raw)
In-Reply-To: <21fc1351-51e2-2d66-d988-b07763a7ae5d@grimberg.me>
On Mon, May 17, 2021 at 11:20:36AM -0700, Sagi Grimberg wrote:
>
>>> That is because we keep the device node around even though it doesn't
>>> have any bottom devices. Which is what I think Hannes tried to fix
>>> in an earlier patch.
>>>
>>> Also, if an NVM subsystem happens to recycle nsids, it will trigger
>>> pretty surely. So I'm not sure this is an obscure case...
>>
>> I'm not very concerned because (1) deleting an in-use namespace is
>> surely a user error, and (2) it currently doesn't work either, and no
>> one's complained yet AFAIK.
>
> You're not wrong. It's just that one error (on ns X) can manifest in
> other potentially completely different namespaces created. I guess
> this kind of thing can happen when ns administration is done by
> adminX (or scriptX) and the ns mounting is done by userY where what each
> is doing is unknown to each other.
We also check for the matching identifiers in nvme_init_ns_head, so
we'll error out there.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-05-18 6:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 8:18 [PATCHv4] nvme: allow to re-attach namespaces after all paths are down Hannes Reinecke
2021-05-17 15:26 ` Keith Busch
2021-05-17 15:36 ` Hannes Reinecke
2021-05-17 15:49 ` Keith Busch
2021-05-17 17:58 ` Sagi Grimberg
2021-05-17 18:01 ` Keith Busch
2021-05-17 18:20 ` Sagi Grimberg
2021-05-18 6:57 ` Christoph Hellwig [this message]
2021-05-18 7:18 ` Hannes Reinecke
2021-05-25 7:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518065710.GA8255@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.