From: Vinod Koul <vkoul@kernel.org> To: Rob Clark <robdclark@gmail.com> Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Jonathan Marek <jonathan@marek.ca>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Abhinav Kumar <abhinavk@codeaurora.org>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology Date: Fri, 21 May 2021 18:19:44 +0530 [thread overview] Message-ID: <20210521124946.3617862-16-vkoul@kernel.org> (raw) In-Reply-To: <20210521124946.3617862-1-vkoul@kernel.org> For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Furthermore, we can use 1 DSC encoder in lesser resulutions, but that is not power efficient according to Abhinav, so it is recommended to always use 2 encoders. So for now we blindly create 2,2,1 topology when DSC is enabled Co-developed-by: Abhinav Kumar <abhinavk@codeaurora.org> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 18cb1274a8bb..bffb40085c67 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -609,8 +609,22 @@ static struct msm_display_topology dpu_encoder_get_topology( topology.num_enc = 0; topology.num_intf = intf_count; + drm_enc = &dpu_enc->base; + priv = drm_enc->dev->dev_private; + if (priv && priv->dsc) { + /* In case of Display Stream Compression DSC, we would use + * 2 encoders, 2 line mixers and 1 interface + * this is power optimal and can drive upto (including) 4k + * screens + */ + topology.num_enc = 2; + topology.num_intf = 1; + topology.num_lm = 2; + } + return topology; } + static int dpu_encoder_virt_atomic_check( struct drm_encoder *drm_enc, struct drm_crtc_state *crtc_state, -- 2.26.3
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Rob Clark <robdclark@gmail.com> Cc: Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, dri-devel@lists.freedesktop.org, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno@lists.freedesktop.org Subject: [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology Date: Fri, 21 May 2021 18:19:44 +0530 [thread overview] Message-ID: <20210521124946.3617862-16-vkoul@kernel.org> (raw) In-Reply-To: <20210521124946.3617862-1-vkoul@kernel.org> For DSC to work we typically need a 2,2,1 configuration. This should suffice for resolutions upto 4k. For more resolutions like 8k this won't work. Furthermore, we can use 1 DSC encoder in lesser resulutions, but that is not power efficient according to Abhinav, so it is recommended to always use 2 encoders. So for now we blindly create 2,2,1 topology when DSC is enabled Co-developed-by: Abhinav Kumar <abhinavk@codeaurora.org> Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org> Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 18cb1274a8bb..bffb40085c67 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -609,8 +609,22 @@ static struct msm_display_topology dpu_encoder_get_topology( topology.num_enc = 0; topology.num_intf = intf_count; + drm_enc = &dpu_enc->base; + priv = drm_enc->dev->dev_private; + if (priv && priv->dsc) { + /* In case of Display Stream Compression DSC, we would use + * 2 encoders, 2 line mixers and 1 interface + * this is power optimal and can drive upto (including) 4k + * screens + */ + topology.num_enc = 2; + topology.num_intf = 1; + topology.num_lm = 2; + } + return topology; } + static int dpu_encoder_virt_atomic_check( struct drm_encoder *drm_enc, struct drm_crtc_state *crtc_state, -- 2.26.3
next prev parent reply other threads:[~2021-05-21 12:51 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 12:49 [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 15:29 ` Daniel Vetter 2021-05-21 15:29 ` Daniel Vetter 2021-05-24 7:26 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:23 ` Vinod Koul 2021-05-21 13:23 ` Vinod Koul 2021-05-21 14:42 ` Bjorn Andersson 2021-05-21 14:42 ` Bjorn Andersson 2021-05-24 7:30 ` Vinod Koul 2021-05-24 7:30 ` Vinod Koul 2021-05-24 15:08 ` Bjorn Andersson 2021-05-24 15:08 ` Bjorn Andersson 2021-05-26 5:32 ` Vinod Koul 2021-05-26 5:32 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:45 ` Dmitry Baryshkov 2021-05-27 23:45 ` Dmitry Baryshkov 2021-06-02 11:06 ` Vinod Koul 2021-06-02 11:06 ` Vinod Koul 2021-05-28 10:29 ` Dmitry Baryshkov 2021-05-28 10:29 ` Dmitry Baryshkov 2021-06-02 11:17 ` Vinod Koul 2021-06-02 11:17 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 06/13] drm/msm/disp/dpu1: Add DSC support in RM Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 07/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 08/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Dont " Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 10/13] drm/msm/disp/dpu1: Add support for DSC in encoder Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` Vinod Koul [this message] 2021-05-21 12:49 ` [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology Vinod Koul 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 22:23 ` abhinavk 2021-05-28 22:23 ` abhinavk 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 12/13] drm/msm/dsi: Add support for DSC configuration Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 13/13] drm/msm/dsi: Pass DSC params to drm_panel Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 14:09 ` [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Jeffrey Hugo 2021-05-21 14:09 ` Jeffrey Hugo 2021-05-26 5:46 ` Vinod Koul 2021-05-26 5:46 ` Vinod Koul 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-27 23:30 ` Rob Clark 2021-05-27 23:30 ` Rob Clark 2021-06-02 11:01 ` Vinod Koul 2021-06-02 11:01 ` Vinod Koul 2021-06-03 23:40 ` abhinavk 2021-06-03 23:40 ` abhinavk 2021-06-17 8:06 ` Vinod Koul 2021-06-17 8:06 ` Vinod Koul 2021-06-04 2:36 ` Rob Clark 2021-06-04 2:36 ` Rob Clark 2021-06-02 10:56 ` Vinod Koul 2021-06-02 10:56 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210521124946.3617862-16-vkoul@kernel.org \ --to=vkoul@kernel.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.