From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653B6C2B9F8 for ; Mon, 24 May 2021 13:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4301E613AD for ; Mon, 24 May 2021 13:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232938AbhEXNkk (ORCPT ); Mon, 24 May 2021 09:40:40 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:58813 "EHLO wnew3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232456AbhEXNki (ORCPT ); Mon, 24 May 2021 09:40:38 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 1B53C2685; Mon, 24 May 2021 09:39:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 24 May 2021 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s/NM62L3Og2Ajx92SsKLLhMAsWU lDMHJJUgar/CuuyY=; b=AH+1x3mWyzoPAuqEmOjSdf9NVKXPq4ESFoEih3CtgKq 91w//vo4s3/NB3tRwvoHyucf0T8J2F4ErGm+SwbRoFYbz2FHqSMtQzbGPxTRe1yH MtFD+8PIQ2RHqJVWuPrgLRRg67jDjd/Tvzl9lh4NSHVKovUp0e/A5nQYpVay7LwI 7h0tFdBTjCz5rVaKbWZNRNu+ZlymcWuQ8RI+/ZUFWyFmYdw8J9j+0d+Y4gpxGPVW IX1N4X+bukknM8DrGdwUGR+FtWV2b1zEj4EqcSNhx6HMnyl9eSxvUGNI2U8MZ+/4 9jTeg9m1+c0uDbIykYpdd1IKzGzPI3kXkcKGneDp2ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s/NM62 L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; b=diD59LTdjW4BEsvkAdgJl9 ZMNasLZ6FLNm+bbeKBMBXEOAXzUHJqrucsikh/TNwhuX9aIv0uZ5tOrCwD/Nezqk /lAcrkNiNfou1WTPaL+c/IEwX4XwGCIRAw9gVrFav2rewtZWxTpJ24N7VPTSAOLr 7a05iIoVEg9xCd98WRtRB1hhIdu2eDyc2N+EgVQVZ3cHdTALJGPsh+qLzsMl8RaZ rxZWyhIGT6Vi1uGfwEgGi5fSMYVI6R7F+PNIf0FTrfXK56vivT2pRc4DoEXLI79g 79CLE3JPda8iXOqKdpvm9BOml1LrDguVoKoUtYMM3c5AmJpqKnOa7ZsmaCIxfOUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 09:39:05 -0400 (EDT) Date: Mon, 24 May 2021 15:39:04 +0200 From: Maxime Ripard To: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Cc: Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , Daniel Vetter , linux-rpi-kernel@lists.infradead.org, Eric Anholt Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Message-ID: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmkkjaxkjbof4vya" Content-Disposition: inline In-Reply-To: <20210507140334.204865-1-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tmkkjaxkjbof4vya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, >=20 > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in p= lace, > it's missing a few controls to be able to provide HBR passthrough. This s= eries > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. >=20 > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-d= river.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two dif= ferent > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation? Any comments on this series? Thanks! Maxime --tmkkjaxkjbof4vya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKusdwAKCRDj7w1vZxhR xVj3AP4uZTPoREfuFK3oXQIWtdDspcef5aq6+8o5wrl7gjJzFwD9GbDNuVOSZ62m P4t+tqoRf1AhEyG+nYTwbpCM/Pkkqwc= =nosZ -----END PGP SIGNATURE----- --tmkkjaxkjbof4vya-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24952C04FF3 for ; Mon, 24 May 2021 13:40:28 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FCC26108D for ; Mon, 24 May 2021 13:40:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FCC26108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F0C2B843; Mon, 24 May 2021 15:39:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F0C2B843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621863626; bh=s/NM62L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eTTKuiUb3P4jbddvLSPd3ugNCY5uFxZwsiQQij+lxBQYzcviYOkF7drTt7qJHzUSy 7J44ZkvJUuWja6SX3ovXZrkIGUXtjEOLHJw8ON3GZFLIjrjJZIDhe6aIcoHkOkeA6r aIQMQIxwcH6/zIO9Y3TeLpgKCbLigpfkueXdozUc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C4AE8F80425; Mon, 24 May 2021 15:39:22 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9EC2DF8042F; Mon, 24 May 2021 15:39:21 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EED9EF80424 for ; Mon, 24 May 2021 15:39:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EED9EF80424 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="AH+1x3mW"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="diD59LTd" Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 1B53C2685; Mon, 24 May 2021 09:39:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 24 May 2021 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s/NM62L3Og2Ajx92SsKLLhMAsWU lDMHJJUgar/CuuyY=; b=AH+1x3mWyzoPAuqEmOjSdf9NVKXPq4ESFoEih3CtgKq 91w//vo4s3/NB3tRwvoHyucf0T8J2F4ErGm+SwbRoFYbz2FHqSMtQzbGPxTRe1yH MtFD+8PIQ2RHqJVWuPrgLRRg67jDjd/Tvzl9lh4NSHVKovUp0e/A5nQYpVay7LwI 7h0tFdBTjCz5rVaKbWZNRNu+ZlymcWuQ8RI+/ZUFWyFmYdw8J9j+0d+Y4gpxGPVW IX1N4X+bukknM8DrGdwUGR+FtWV2b1zEj4EqcSNhx6HMnyl9eSxvUGNI2U8MZ+/4 9jTeg9m1+c0uDbIykYpdd1IKzGzPI3kXkcKGneDp2ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s/NM62 L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; b=diD59LTdjW4BEsvkAdgJl9 ZMNasLZ6FLNm+bbeKBMBXEOAXzUHJqrucsikh/TNwhuX9aIv0uZ5tOrCwD/Nezqk /lAcrkNiNfou1WTPaL+c/IEwX4XwGCIRAw9gVrFav2rewtZWxTpJ24N7VPTSAOLr 7a05iIoVEg9xCd98WRtRB1hhIdu2eDyc2N+EgVQVZ3cHdTALJGPsh+qLzsMl8RaZ rxZWyhIGT6Vi1uGfwEgGi5fSMYVI6R7F+PNIf0FTrfXK56vivT2pRc4DoEXLI79g 79CLE3JPda8iXOqKdpvm9BOml1LrDguVoKoUtYMM3c5AmJpqKnOa7ZsmaCIxfOUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 09:39:05 -0400 (EDT) Date: Mon, 24 May 2021 15:39:04 +0200 From: Maxime Ripard To: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Message-ID: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmkkjaxkjbof4vya" Content-Disposition: inline In-Reply-To: <20210507140334.204865-1-maxime@cerno.tech> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Eric Anholt , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Daniel Vetter , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --tmkkjaxkjbof4vya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, >=20 > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in p= lace, > it's missing a few controls to be able to provide HBR passthrough. This s= eries > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. >=20 > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-d= river.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two dif= ferent > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation? Any comments on this series? Thanks! Maxime --tmkkjaxkjbof4vya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKusdwAKCRDj7w1vZxhR xVj3AP4uZTPoREfuFK3oXQIWtdDspcef5aq6+8o5wrl7gjJzFwD9GbDNuVOSZ62m P4t+tqoRf1AhEyG+nYTwbpCM/Pkkqwc= =nosZ -----END PGP SIGNATURE----- --tmkkjaxkjbof4vya-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FD6DC04FF3 for ; Mon, 24 May 2021 19:16:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 134C5610FA for ; Mon, 24 May 2021 19:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 134C5610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A+J29pX2y6rYqGLEYmjgqTvVZz3J8CzSJ+XP7ZhUTqs=; b=C6Hu3j4xV499o0yHbEePGtcxm qlreQtFIYd2lrryHUepP70UbZ7yrZ5MXy/Dt8t3Scfo4ZfRysItPffK6chfxracKmlkdmZsjVFK9+ 3LfGAE2+Wkti3OiCaXR6pozOOBsePwnliIKiWkFPmIULHJZLLlHN0MRnj7hr4wjiQSNlqhk3rg5um eRYQbQoDi2KrZLrbznsLfHLiFI1jGrBcxcOMwJwdGIZrYH5fqOhppouhTzIkjbZTqhR++F0KxVBJl ZLkP0B166/cCuBFHGTc8iSGOf6oZWcyS+Bq+vDusV7Qk5vQ/H6O6KP5KMrFTI5fr3buPyu84Dxhyr wL3gU+5sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llG1j-001co3-AX; Mon, 24 May 2021 19:14:14 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llAnd-000xkV-Sx; Mon, 24 May 2021 13:39:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 1B53C2685; Mon, 24 May 2021 09:39:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 24 May 2021 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s/NM62L3Og2Ajx92SsKLLhMAsWU lDMHJJUgar/CuuyY=; b=AH+1x3mWyzoPAuqEmOjSdf9NVKXPq4ESFoEih3CtgKq 91w//vo4s3/NB3tRwvoHyucf0T8J2F4ErGm+SwbRoFYbz2FHqSMtQzbGPxTRe1yH MtFD+8PIQ2RHqJVWuPrgLRRg67jDjd/Tvzl9lh4NSHVKovUp0e/A5nQYpVay7LwI 7h0tFdBTjCz5rVaKbWZNRNu+ZlymcWuQ8RI+/ZUFWyFmYdw8J9j+0d+Y4gpxGPVW IX1N4X+bukknM8DrGdwUGR+FtWV2b1zEj4EqcSNhx6HMnyl9eSxvUGNI2U8MZ+/4 9jTeg9m1+c0uDbIykYpdd1IKzGzPI3kXkcKGneDp2ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s/NM62 L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; b=diD59LTdjW4BEsvkAdgJl9 ZMNasLZ6FLNm+bbeKBMBXEOAXzUHJqrucsikh/TNwhuX9aIv0uZ5tOrCwD/Nezqk /lAcrkNiNfou1WTPaL+c/IEwX4XwGCIRAw9gVrFav2rewtZWxTpJ24N7VPTSAOLr 7a05iIoVEg9xCd98WRtRB1hhIdu2eDyc2N+EgVQVZ3cHdTALJGPsh+qLzsMl8RaZ rxZWyhIGT6Vi1uGfwEgGi5fSMYVI6R7F+PNIf0FTrfXK56vivT2pRc4DoEXLI79g 79CLE3JPda8iXOqKdpvm9BOml1LrDguVoKoUtYMM3c5AmJpqKnOa7ZsmaCIxfOUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 09:39:05 -0400 (EDT) Date: Mon, 24 May 2021 15:39:04 +0200 From: Maxime Ripard To: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Cc: Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , Daniel Vetter , linux-rpi-kernel@lists.infradead.org, Eric Anholt Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Message-ID: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20210507140334.204865-1-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_063917_968616_E158B98D X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2906572825568480195==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2906572825568480195== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmkkjaxkjbof4vya" Content-Disposition: inline --tmkkjaxkjbof4vya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, >=20 > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in p= lace, > it's missing a few controls to be able to provide HBR passthrough. This s= eries > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. >=20 > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-d= river.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two dif= ferent > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation? Any comments on this series? Thanks! Maxime --tmkkjaxkjbof4vya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKusdwAKCRDj7w1vZxhR xVj3AP4uZTPoREfuFK3oXQIWtdDspcef5aq6+8o5wrl7gjJzFwD9GbDNuVOSZ62m P4t+tqoRf1AhEyG+nYTwbpCM/Pkkqwc= =nosZ -----END PGP SIGNATURE----- --tmkkjaxkjbof4vya-- --===============2906572825568480195== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2906572825568480195==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EEEC04FF3 for ; Mon, 24 May 2021 13:39:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CF13613AD for ; Mon, 24 May 2021 13:39:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CF13613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 888FA6E7FE; Mon, 24 May 2021 13:39:13 +0000 (UTC) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 641366E5D4 for ; Mon, 24 May 2021 13:39:11 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 1B53C2685; Mon, 24 May 2021 09:39:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 24 May 2021 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s/NM62L3Og2Ajx92SsKLLhMAsWU lDMHJJUgar/CuuyY=; b=AH+1x3mWyzoPAuqEmOjSdf9NVKXPq4ESFoEih3CtgKq 91w//vo4s3/NB3tRwvoHyucf0T8J2F4ErGm+SwbRoFYbz2FHqSMtQzbGPxTRe1yH MtFD+8PIQ2RHqJVWuPrgLRRg67jDjd/Tvzl9lh4NSHVKovUp0e/A5nQYpVay7LwI 7h0tFdBTjCz5rVaKbWZNRNu+ZlymcWuQ8RI+/ZUFWyFmYdw8J9j+0d+Y4gpxGPVW IX1N4X+bukknM8DrGdwUGR+FtWV2b1zEj4EqcSNhx6HMnyl9eSxvUGNI2U8MZ+/4 9jTeg9m1+c0uDbIykYpdd1IKzGzPI3kXkcKGneDp2ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s/NM62 L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; b=diD59LTdjW4BEsvkAdgJl9 ZMNasLZ6FLNm+bbeKBMBXEOAXzUHJqrucsikh/TNwhuX9aIv0uZ5tOrCwD/Nezqk /lAcrkNiNfou1WTPaL+c/IEwX4XwGCIRAw9gVrFav2rewtZWxTpJ24N7VPTSAOLr 7a05iIoVEg9xCd98WRtRB1hhIdu2eDyc2N+EgVQVZ3cHdTALJGPsh+qLzsMl8RaZ rxZWyhIGT6Vi1uGfwEgGi5fSMYVI6R7F+PNIf0FTrfXK56vivT2pRc4DoEXLI79g 79CLE3JPda8iXOqKdpvm9BOml1LrDguVoKoUtYMM3c5AmJpqKnOa7ZsmaCIxfOUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 09:39:05 -0400 (EDT) Date: Mon, 24 May 2021 15:39:04 +0200 From: Maxime Ripard To: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Message-ID: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmkkjaxkjbof4vya" Content-Disposition: inline In-Reply-To: <20210507140334.204865-1-maxime@cerno.tech> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Dom Cobley , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --tmkkjaxkjbof4vya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, >=20 > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in p= lace, > it's missing a few controls to be able to provide HBR passthrough. This s= eries > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. >=20 > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-d= river.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two dif= ferent > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation? Any comments on this series? Thanks! Maxime --tmkkjaxkjbof4vya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKusdwAKCRDj7w1vZxhR xVj3AP4uZTPoREfuFK3oXQIWtdDspcef5aq6+8o5wrl7gjJzFwD9GbDNuVOSZ62m P4t+tqoRf1AhEyG+nYTwbpCM/Pkkqwc= =nosZ -----END PGP SIGNATURE----- --tmkkjaxkjbof4vya--