Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip v5.13-rc3 next-20210526] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-a001-20210526 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/80157be9e8542ce9a835e6f159408b951590b578 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Vetter/drm-i915-Use-generic_access_phys/20210526-231425 git checkout 80157be9e8542ce9a835e6f159408b951590b578 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/gpu/drm/i915/gem/i915_gem_mman.c:755:2: error: request for member 'open' in something not a structure or union 755 | .open = vm_open, | ^ drivers/gpu/drm/i915/gem/i915_gem_mman.c:764:2: error: request for member 'open' in something not a structure or union 764 | .open = vm_open, | ^ vim +/open +755 drivers/gpu/drm/i915/gem/i915_gem_mman.c cc662126b4134e2 Abdiel Janulgue 2019-12-04 749 cc662126b4134e2 Abdiel Janulgue 2019-12-04 750 static const struct vm_operations_struct vm_ops_gtt = { cc662126b4134e2 Abdiel Janulgue 2019-12-04 751 .fault = vm_fault_gtt, 80157be9e8542ce Daniel Vetter 2021-05-26 752 #ifdef CONFIG_HAVE_IOREMAP_PROT 80157be9e8542ce Daniel Vetter 2021-05-26 753 .access = generic_access_phys 80157be9e8542ce Daniel Vetter 2021-05-26 754 #endif cc662126b4134e2 Abdiel Janulgue 2019-12-04 @755 .open = vm_open, cc662126b4134e2 Abdiel Janulgue 2019-12-04 756 .close = vm_close, cc662126b4134e2 Abdiel Janulgue 2019-12-04 757 }; cc662126b4134e2 Abdiel Janulgue 2019-12-04 758 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org