All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Martens <gmc@sonologic.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/capnproto: fix build on riscv32
Date: Fri, 28 May 2021 08:59:49 +0200	[thread overview]
Message-ID: <20210528065949.GA2170022@sunra> (raw)
In-Reply-To: <20210527210402.555334-1-fontaine.fabrice@gmail.com>

Hi,

Thanks for diving into this. I've had emails about this for months, and briefly
looked at it, but never found the time to properly figure it out.

I see the patch below is also present upstream. Do you know whether this has
already been released or when it will be?

Given that this exact patch is also applied upstream, your patch below seems fine
to me.

Cheers,

Koen

On Thu, May 27, 2021 at 11:04:02PM +0200, Fabrice Fontaine wrote:
> Fixes:
>  - http://autobuild.buildroot.org/results/1c1cd4775241ee57d878cad5c978413d4b4a8736
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...it-architectures-using-64-bit-time_t.patch | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 package/capnproto/0001-mutex-Fix-build-on-32-bit-architectures-using-64-bit-time_t.patch
> 
> diff --git a/package/capnproto/0001-mutex-Fix-build-on-32-bit-architectures-using-64-bit-time_t.patch b/package/capnproto/0001-mutex-Fix-build-on-32-bit-architectures-using-64-bit-time_t.patch
> new file mode 100644
> index 0000000000..ce70ab8f29
> --- /dev/null
> +++ b/package/capnproto/0001-mutex-Fix-build-on-32-bit-architectures-using-64-bit-time_t.patch
> @@ -0,0 +1,37 @@
> +From e2a05a19e9dc51287e19cc9f11fd91449219e361 Mon Sep 17 00:00:00 2001
> +From: Khem Raj <raj.khem@gmail.com>
> +Date: Sun, 15 Nov 2020 12:10:28 -0800
> +Subject: [PATCH] mutex: Fix build on 32-bit architectures using 64-bit time_t
> +
> +mutex code uses SYS_futex, which it expects from system C library.
> +in glibc (/usr/include/bits/syscall.h defines it in terms of of NR_futex)
> +rv32 is using 64bit time_t from get go unlike other 32bit architectures
> +in glibc, therefore it wont have NR_futex defined but just NR_futex_time64
> +this aliases it to NR_futex so that SYS_futex is then defined for rv32
> +
> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
> +[Retrieved from:
> +https://github.com/capnproto/capnproto/commit/e2a05a19e9dc51287e19cc9f11fd91449219e361]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + c++/src/kj/mutex.c++ | 6 ++++++
> + 1 file changed, 6 insertions(+)
> +
> +diff --git a/c++/src/kj/mutex.c++ b/c++/src/kj/mutex.c++
> +index c81cead7b..e1594b117 100644
> +--- a/c++/src/kj/mutex.c++
> ++++ b/c++/src/kj/mutex.c++
> +@@ -39,7 +39,13 @@
> + 
> + #ifndef SYS_futex
> + // Missing on Android/Bionic.
> ++#ifdef __NR_futex
> + #define SYS_futex __NR_futex
> ++#elif defined(SYS_futex_time64)
> ++#define SYS_futex SYS_futex_time64
> ++#else
> ++#error "Need working SYS_futex"
> ++#endif
> + #endif
> + 
> + #ifndef FUTEX_WAIT_PRIVATE
> -- 
> 2.30.2
> 

  reply	other threads:[~2021-05-28  6:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 21:04 [Buildroot] [PATCH 1/1] package/capnproto: fix build on riscv32 Fabrice Fontaine
2021-05-28  6:59 ` Koen Martens [this message]
2021-05-28  7:11   ` Fabrice Fontaine
2021-05-28 14:17     ` Arnout Vandecappelle
2021-05-28 14:33       ` Fabrice Fontaine
2021-05-28 15:25         ` Arnout Vandecappelle
2021-05-28 15:26           ` Fabrice Fontaine
2021-07-02 21:10       ` Alexandre Belloni
2021-07-03 12:21         ` Arnout Vandecappelle
2021-06-10  8:47 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528065949.GA2170022@sunra \
    --to=gmc@sonologic.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.