From: Kees Cook <keescook@chromium.org>
To: Joe Perches <joe@perches.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Bradley Grove <linuxdrivers@attotech.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH 1/3] scsi: fcoe: Statically initialize flogi_maddr
Date: Fri, 28 May 2021 11:29:59 -0700 [thread overview]
Message-ID: <202105281129.530BBAF694@keescook> (raw)
In-Reply-To: <8a64b62949477b85576ab47e4705ca13fb555a9c.camel@perches.com>
On Fri, May 28, 2021 at 11:28:59AM -0700, Joe Perches wrote:
> On Fri, 2021-05-28 at 11:13 -0700, Kees Cook wrote:
> > In preparation for FORTIFY_SOURCE performing compile-time and run-time
> > field bounds checking for memcpy() using memcpy() with an inline const
> > buffer and instead just statically initialize the destination array
> > directly.
> []
> > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> []
> > @@ -293,7 +293,7 @@ static int fcoe_interface_setup(struct fcoe_interface *fcoe,
> > struct fcoe_ctlr *fip = fcoe_to_ctlr(fcoe);
> > struct netdev_hw_addr *ha;
> > struct net_device *real_dev;
> > - u8 flogi_maddr[ETH_ALEN];
> > + u8 flogi_maddr[ETH_ALEN] = FC_FCOE_FLOGI_MAC;
>
> static const
>
> > @@ -442,7 +441,7 @@ static void fcoe_interface_remove(struct fcoe_interface *fcoe)
> > {
> > struct net_device *netdev = fcoe->netdev;
> > struct fcoe_ctlr *fip = fcoe_to_ctlr(fcoe);
> > - u8 flogi_maddr[ETH_ALEN];
> > + u8 flogi_maddr[ETH_ALEN] = FC_FCOE_FLOGI_MAC;
>
> etc...
Hm, good point.
--
Kees Cook
next prev parent reply other threads:[~2021-05-28 18:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 18:13 [PATCH 0/3] scsi: Fix a handful of memcpy() field overflows Kees Cook
2021-05-28 18:13 ` [PATCH 1/3] scsi: fcoe: Statically initialize flogi_maddr Kees Cook
2021-05-28 18:28 ` Joe Perches
2021-05-28 18:29 ` Kees Cook [this message]
2021-05-28 18:13 ` [PATCH 2/3] scsi: esas2r: Switch to flexible array member Kees Cook
2021-05-28 20:26 ` Gustavo A. R. Silva
2021-05-28 18:13 ` [PATCH 3/3] scsi: isci: Use correctly sized target buffer for memcpy() Kees Cook
2021-05-28 20:29 ` Gustavo A. R. Silva
2021-06-02 3:38 ` [PATCH 0/3] scsi: Fix a handful of memcpy() field overflows Martin K. Petersen
2021-06-02 18:00 ` Kees Cook
2021-06-08 3:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105281129.530BBAF694@keescook \
--to=keescook@chromium.org \
--cc=artur.paszkiewicz@intel.com \
--cc=gustavoars@kernel.org \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=joe@perches.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxdrivers@attotech.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.