From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0469AC47080 for ; Tue, 1 Jun 2021 13:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0A74610A1 for ; Tue, 1 Jun 2021 13:22:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233823AbhFANXn (ORCPT ); Tue, 1 Jun 2021 09:23:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26552 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233758AbhFANXn (ORCPT ); Tue, 1 Jun 2021 09:23:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622553721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=UJR7GtPI22bYDieQRkOQP5b0jdBIHRfEETEjU13DSu/xMYUEs3VpmCk5gIDvLx+/5ie24E ioIaXtfrPOe0bBncJZbCT/dRvSFmmQ/HnR7Jp/bmJ83oUxjtfNTRxitBhuW1PiP0CwxQXW T4m4fG7Cty/tI9RLrV6yMI0GWZH+2xE= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-465-BcLfYdDjOVSfYufOFlYFJw-1; Tue, 01 Jun 2021 09:22:00 -0400 X-MC-Unique: BcLfYdDjOVSfYufOFlYFJw-1 Received: by mail-ed1-f69.google.com with SMTP id q7-20020aa7cc070000b029038f59dab1c5so7849240edt.23 for ; Tue, 01 Jun 2021 06:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=qNdWc6XeDBsTduTCt5jvNu6qOhwHPruNrJprU28qfO+FzZIDZdy2mTd7YS45voBACM z8lB1jVPsiA3DiHYvN4iXHMQ+YWAqybh2XkpCLudEiD36//u0TMMGkyWzxhdxGsZAEVU VkAbhZ08mp4YrCzWwyJV/frG9Dwp+O5xIiAKcDkgOi3fgC8YNIBxDBCWoG7iRyd9nQW2 8QCQXVOeNBqhf0NKyS2rqWx0ejsXvjDLc1vMqXoKohvQZSmae7i79QhUB+aYBKQDUp1X kqGtEiYJ7DBjnQLq3fr3rrssELEbJbl/yqkeC/aEALSQuxaUI44KU6AA53kEmzjgIU+Z Sw/g== X-Gm-Message-State: AOAM530lI4IOTwNJCUNcJ8uX95U4rQ0Bo9awizgunBug2d8cTOzfos6D ayExQJhvWa5KpiilgeXTZmynYmVdRJbeYkypVXJIN8a+X1zP/5A9DtbuAjSD1l6OUK4GLL4Ijml JaaFfiTiJyZ8z X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558988eds.280.1622553719256; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwib9IzYrXbEw79+Z8nE2OguJl12IzGR+VIrSFD6C5CbyzCFWlk9D3q1IvxJWKKa0r/vLCqGw== X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558970eds.280.1622553719129; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id nc26sm1596965ejc.106.2021.06.01.06.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 06:21:58 -0700 (PDT) Date: Tue, 1 Jun 2021 15:21:56 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants Message-ID: <20210601132156.qtgcfkvlr7i7rf2d@gator.home> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-5-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210525172628.2088-5-alex.bennee@linaro.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 25, 2021 at 06:26:28PM +0100, Alex Bennée wrote: > When running the test in TCG we are basically running on bare metal so > don't rely on having a particular kernel errata applied. > > You might wonder why we handle this with a totally new test name > instead of adjusting the append to take an extra parameter? Well the > run_migration shell script uses eval "$@" which unwraps the -append > leading to any second parameter being split and leaving QEMU very > confused and the test hanging. This seemed simpler than re-writing all > the test running logic in something sane ;-) Yes, bash is a pain for this. I may try to get migration with more than one parameter to work at some point though. But, for generally determining if a unit test is running with tcg or with kvm, we have the QEMU_ACCEL environment variable. So you could just do getenv("QEMU_ACCEL") in the unit test. However, I wouldn't use it for this case, since the purpose is just to force errata to be ignored. We have the "ERRATA_FORCE" environment variable for that already. You can set it yourself, e.g. $ ERRATA_FORCE=y tests/its-migration or, if you plan to run all tests, then with $ ./run_tests.sh -a but that also runs nodefault tests. Maybe we should teach run_tests.sh to always set ERRATA_FORCE=y when running with TCG? Thanks, drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96677C47080 for ; Tue, 1 Jun 2021 13:22:11 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0B34F610C9 for ; Tue, 1 Jun 2021 13:22:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B34F610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 712474A193; Tue, 1 Jun 2021 09:22:10 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tDm4RPfriXMM; Tue, 1 Jun 2021 09:22:07 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D07EE4A198; Tue, 1 Jun 2021 09:22:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF25F4A17F for ; Tue, 1 Jun 2021 09:22:06 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y4xLxIxZd2MX for ; Tue, 1 Jun 2021 09:22:04 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0C1A849F92 for ; Tue, 1 Jun 2021 09:22:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622553723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=OAJ8O2B05uAS8ccRNbLzO0JW7waWSFZQc+Jswr3lNZZ51u5YG5O6UP6FJbZ1jbCvk9RFJF Oa//xopwZ2TfnPhJ95JvDOiWlh5Mdet5oWZeMikG+h4GTWOLpBZ404d+EN+/A2rLMA+0bs KS+5lqcck6IOjEjrUUnu8+j7qAzgdNI= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-b3sRS6oyMha-PD6DzBtAKA-1; Tue, 01 Jun 2021 09:22:00 -0400 X-MC-Unique: b3sRS6oyMha-PD6DzBtAKA-1 Received: by mail-ed1-f72.google.com with SMTP id x8-20020aa7d3880000b029038fe468f5f4so2869151edq.10 for ; Tue, 01 Jun 2021 06:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=UWChPX9sL5kiJi05fzPxlcArWzV1qLItD79o437MaAbUbnYLPF8lDlVdFAftg+U4d7 6NsX34wL2pxRj2aMNLWIxCumgy4R3MbuJeRFL4EqzsOrvAA7yaJCg+f7I0N7wW/EtWX2 8+dF9hq18yJk4VFN68gQrf+RBC5efN8vYtOArNvK7bPnpO/9ZrV70pvYgHgC48HGDz2r lhFWPT+cgc2U1EpcKFAeRP+RzcQxdzyLRoWXgb6hf8vGG4dqoYd0t8h0AeSeMn7DnxMx c/dpbH7kAFHssxKweVUDC03p4D566qtzn1oLC+ol4car+viqioxpp+CuAgSIcNFTxL2Q ehiQ== X-Gm-Message-State: AOAM530nQaSca49qYQeBNkkk+iKammh5YfJw9NJvF/73n0bVO4Bq6xd9 i7WWZwxOxgHPYLLkczOvMSFRvACWCNlm88pg+Id//M6VIN1FOHTi7ZMeW7/3jrcc7YR1F3M4uTu 4SIOzYRJwTnH6vp5tFaw5pwyu X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558995eds.280.1622553719289; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwib9IzYrXbEw79+Z8nE2OguJl12IzGR+VIrSFD6C5CbyzCFWlk9D3q1IvxJWKKa0r/vLCqGw== X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558970eds.280.1622553719129; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id nc26sm1596965ejc.106.2021.06.01.06.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 06:21:58 -0700 (PDT) Date: Tue, 1 Jun 2021 15:21:56 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants Message-ID: <20210601132156.qtgcfkvlr7i7rf2d@gator.home> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-5-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20210525172628.2088-5-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, May 25, 2021 at 06:26:28PM +0100, Alex Benn=E9e wrote: > When running the test in TCG we are basically running on bare metal so > don't rely on having a particular kernel errata applied. > = > You might wonder why we handle this with a totally new test name > instead of adjusting the append to take an extra parameter? Well the > run_migration shell script uses eval "$@" which unwraps the -append > leading to any second parameter being split and leaving QEMU very > confused and the test hanging. This seemed simpler than re-writing all > the test running logic in something sane ;-) Yes, bash is a pain for this. I may try to get migration with more than one parameter to work at some point though. But, for generally determining if a unit test is running with tcg or with kvm, we have the QEMU_ACCEL environment variable. So you could just do getenv("QEMU_ACCEL") in the unit test. However, I wouldn't use it for this case, since the purpose is just to force errata to be ignored. We have the "ERRATA_FORCE" environment variable for that already. You can set it yourself, e.g. $ ERRATA_FORCE=3Dy tests/its-migration or, if you plan to run all tests, then with $ ./run_tests.sh -a but that also runs nodefault tests. Maybe we should teach run_tests.sh to always set ERRATA_FORCE=3Dy when running with TCG? Thanks, drew _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7224C4708F for ; Tue, 1 Jun 2021 13:23:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DDED610A1 for ; Tue, 1 Jun 2021 13:23:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DDED610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tsHykJNQx0qEMt9mqUm4XN554H4qYxz40VjfxOFUg5Q=; b=bUFScrm7GLtcWT nr5TkbYfwAYDnT05IEIHkuoBoz58ivv4S6MaktDn+D7Y/+HfKgbd97azDSW/wLAJaoOV7OrdWYvRu bDMEzZW/nWXphVbquI3dXrXqOk93RycwujYFdw46jnUCFWWJyBaVIPu4nuwZuIja5G2r0ZKMLaTge a/CPTjFJH/XPScWY3Qu79BuaVM5zLlyIq0/bPAcVkyOCS2XCwxO/xuOBCRw14SP47Lkeo+ul9Qa2F e7vSQB+j1dEfaoABz6Z8q2SGEw7a+nQFYlY8E5Ft8PzzLVmTOLw6MIHuhwafhol1eEpU/mEyBf874 ljihUVCEp/1st3CU3Qrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo4LP-00GlDK-GN; Tue, 01 Jun 2021 13:22:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo4LL-00GlCR-U4 for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 13:22:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622553722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=HuwWQFKypFVlJUKkz/RlJ3D1nEDkuf7+2mw2A3gCsilFt4LbVCCy8j6Xmzj1d/E8LSHc8b +qPYdXSur3ybYfD3AUeEYqMEarbkCPqLbx5FrhuNZM+S0K3DfoxSYHstizIYpC4P0g7RSN zYO9rVkbHXsZsTLijnLpoePi5Qux1So= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-pfjBfoPlPBGXr9G4IOHONw-1; Tue, 01 Jun 2021 09:22:00 -0400 X-MC-Unique: pfjBfoPlPBGXr9G4IOHONw-1 Received: by mail-ed1-f69.google.com with SMTP id f12-20020a056402150cb029038fdcfb6ea2so3663236edw.14 for ; Tue, 01 Jun 2021 06:22:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ThmhXV5C1Mdx87JvqBPyBVcdeP2i7QEeRJhDPg8Jb0Y=; b=Yn9xF5M+7wQecMU23JmYp65Zsbi5znoyy1SA5n404OhVy1R0GVo+RDC6wUi2xQijvS kmQVkUK5b/4Y014V9+1OHT1MhFTC3DgP2vgUs7eFGp3YTyBEpcgDTHPCQztkDkkqlRws g6tFBPGeiZzjA6O9FU+fR1lEOiu8A310t6soQ5VyX5tpYWHHoWDoOAjC+Mhk7VAoeksG yXM+VIImGQkTI4n6z2pUmPFldUVcZPK1cSH0o/28MhNduFwISpcZrD8YwDujMNafsic/ qMhXqhIGIevCHE71APs/QnLeovUVPqoX+hLRsGXqJ2Km9IJjK8XMiH6TxpKqsXgNCqUq +C1Q== X-Gm-Message-State: AOAM532Q7m4wMhoRb5QF7lpV5iLUY/nLDTmDiJzVlCo9r1ahRAUGCVpV oWprW8mfaphzL5A6ZDDesVTXqOJR17q60pxvGCeZtJEKH2v05J4iwGdkW7X2x8jgTTi2d7yW9AX 7TiwfrlKmC2sliY6w4I2uXyTOl6GWT3pqrsM= X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558985eds.280.1622553719255; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwib9IzYrXbEw79+Z8nE2OguJl12IzGR+VIrSFD6C5CbyzCFWlk9D3q1IvxJWKKa0r/vLCqGw== X-Received: by 2002:a50:fd13:: with SMTP id i19mr7558970eds.280.1622553719129; Tue, 01 Jun 2021 06:21:59 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id nc26sm1596965ejc.106.2021.06.01.06.21.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 06:21:58 -0700 (PDT) Date: Tue, 1 Jun 2021 15:21:56 +0200 From: Andrew Jones To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: kvm@vger.kernel.org, maz@kernel.org, shashi.mallela@linaro.org, qemu-arm@nongnu.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [kvm-unit-tests PATCH v2 4/4] arm64: split its-migrate-unmapped-collection into KVM and TCG variants Message-ID: <20210601132156.qtgcfkvlr7i7rf2d@gator.home> References: <20210525172628.2088-1-alex.bennee@linaro.org> <20210525172628.2088-5-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20210525172628.2088-5-alex.bennee@linaro.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_062204_075577_FCB5D765 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 25, 2021 at 06:26:28PM +0100, Alex Benn=E9e wrote: > When running the test in TCG we are basically running on bare metal so > don't rely on having a particular kernel errata applied. > = > You might wonder why we handle this with a totally new test name > instead of adjusting the append to take an extra parameter? Well the > run_migration shell script uses eval "$@" which unwraps the -append > leading to any second parameter being split and leaving QEMU very > confused and the test hanging. This seemed simpler than re-writing all > the test running logic in something sane ;-) Yes, bash is a pain for this. I may try to get migration with more than one parameter to work at some point though. But, for generally determining if a unit test is running with tcg or with kvm, we have the QEMU_ACCEL environment variable. So you could just do getenv("QEMU_ACCEL") in the unit test. However, I wouldn't use it for this case, since the purpose is just to force errata to be ignored. We have the "ERRATA_FORCE" environment variable for that already. You can set it yourself, e.g. $ ERRATA_FORCE=3Dy tests/its-migration or, if you plan to run all tests, then with $ ./run_tests.sh -a but that also runs nodefault tests. Maybe we should teach run_tests.sh to always set ERRATA_FORCE=3Dy when running with TCG? Thanks, drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel