Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on c4681547bcce777daf576925a966ffa824edd09d] url: https://github.com/0day-ci/linux/commits/Mike-Rapoport/Remove-DISCINTIGMEM-memory-model/20210602-185609 base: c4681547bcce777daf576925a966ffa824edd09d config: x86_64-randconfig-a002-20210602 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/1800f1972bb2ae7c788d1f0f1a8a301cf3f3f86c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mike-Rapoport/Remove-DISCINTIGMEM-memory-model/20210602-185609 git checkout 1800f1972bb2ae7c788d1f0f1a8a301cf3f3f86c # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from kernel/crash_core.c:7: kernel/crash_core.c: In function 'crash_save_vmcoreinfo_init': >> kernel/crash_core.c:459:20: error: 'mem_map' undeclared (first use in this function); did you mean 'memcmp'? 459 | VMCOREINFO_SYMBOL(mem_map); | ^~~~~~~ include/linux/crash_core.h:46:67: note: in definition of macro 'VMCOREINFO_SYMBOL' 46 | vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)&name) | ^~~~ kernel/crash_core.c:459:20: note: each undeclared identifier is reported only once for each function it appears in 459 | VMCOREINFO_SYMBOL(mem_map); | ^~~~~~~ include/linux/crash_core.h:46:67: note: in definition of macro 'VMCOREINFO_SYMBOL' 46 | vmcoreinfo_append_str("SYMBOL(%s)=%lx\n", #name, (unsigned long)&name) | ^~~~ vim +459 kernel/crash_core.c 0935288c6e008c Vijay Balakrishna 2020-08-11 427 692f66f26a4c19 Hari Bathini 2017-05-08 428 static int __init crash_save_vmcoreinfo_init(void) 692f66f26a4c19 Hari Bathini 2017-05-08 429 { 203e9e41219b4e Xunlei Pang 2017-07-12 430 vmcoreinfo_data = (unsigned char *)get_zeroed_page(GFP_KERNEL); 203e9e41219b4e Xunlei Pang 2017-07-12 431 if (!vmcoreinfo_data) { 203e9e41219b4e Xunlei Pang 2017-07-12 432 pr_warn("Memory allocation for vmcoreinfo_data failed\n"); 203e9e41219b4e Xunlei Pang 2017-07-12 433 return -ENOMEM; 203e9e41219b4e Xunlei Pang 2017-07-12 434 } 203e9e41219b4e Xunlei Pang 2017-07-12 435 203e9e41219b4e Xunlei Pang 2017-07-12 436 vmcoreinfo_note = alloc_pages_exact(VMCOREINFO_NOTE_SIZE, 203e9e41219b4e Xunlei Pang 2017-07-12 437 GFP_KERNEL | __GFP_ZERO); 203e9e41219b4e Xunlei Pang 2017-07-12 438 if (!vmcoreinfo_note) { 203e9e41219b4e Xunlei Pang 2017-07-12 439 free_page((unsigned long)vmcoreinfo_data); 203e9e41219b4e Xunlei Pang 2017-07-12 440 vmcoreinfo_data = NULL; 203e9e41219b4e Xunlei Pang 2017-07-12 441 pr_warn("Memory allocation for vmcoreinfo_note failed\n"); 203e9e41219b4e Xunlei Pang 2017-07-12 442 return -ENOMEM; 203e9e41219b4e Xunlei Pang 2017-07-12 443 } 203e9e41219b4e Xunlei Pang 2017-07-12 444 692f66f26a4c19 Hari Bathini 2017-05-08 445 VMCOREINFO_OSRELEASE(init_uts_ns.name.release); 0935288c6e008c Vijay Balakrishna 2020-08-11 446 add_build_id_vmcoreinfo(); 692f66f26a4c19 Hari Bathini 2017-05-08 447 VMCOREINFO_PAGESIZE(PAGE_SIZE); 692f66f26a4c19 Hari Bathini 2017-05-08 448 692f66f26a4c19 Hari Bathini 2017-05-08 449 VMCOREINFO_SYMBOL(init_uts_ns); ca4a9241cc5e71 Alexander Egorenkov 2020-12-15 450 VMCOREINFO_OFFSET(uts_namespace, name); 692f66f26a4c19 Hari Bathini 2017-05-08 451 VMCOREINFO_SYMBOL(node_online_map); 692f66f26a4c19 Hari Bathini 2017-05-08 452 #ifdef CONFIG_MMU eff4345e7fba0a Omar Sandoval 2018-08-21 453 VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir); 692f66f26a4c19 Hari Bathini 2017-05-08 454 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 455 VMCOREINFO_SYMBOL(_stext); 692f66f26a4c19 Hari Bathini 2017-05-08 456 VMCOREINFO_SYMBOL(vmap_area_list); 692f66f26a4c19 Hari Bathini 2017-05-08 457 692f66f26a4c19 Hari Bathini 2017-05-08 458 #ifndef CONFIG_NEED_MULTIPLE_NODES 692f66f26a4c19 Hari Bathini 2017-05-08 @459 VMCOREINFO_SYMBOL(mem_map); 692f66f26a4c19 Hari Bathini 2017-05-08 460 VMCOREINFO_SYMBOL(contig_page_data); 692f66f26a4c19 Hari Bathini 2017-05-08 461 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 462 #ifdef CONFIG_SPARSEMEM a0b1280368d1e9 Kirill A. Shutemov 2018-01-12 463 VMCOREINFO_SYMBOL_ARRAY(mem_section); 692f66f26a4c19 Hari Bathini 2017-05-08 464 VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); 692f66f26a4c19 Hari Bathini 2017-05-08 465 VMCOREINFO_STRUCT_SIZE(mem_section); 692f66f26a4c19 Hari Bathini 2017-05-08 466 VMCOREINFO_OFFSET(mem_section, section_mem_map); 1d50e5d0c50524 Bhupesh Sharma 2020-05-14 467 VMCOREINFO_NUMBER(MAX_PHYSMEM_BITS); 692f66f26a4c19 Hari Bathini 2017-05-08 468 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 469 VMCOREINFO_STRUCT_SIZE(page); 692f66f26a4c19 Hari Bathini 2017-05-08 470 VMCOREINFO_STRUCT_SIZE(pglist_data); 692f66f26a4c19 Hari Bathini 2017-05-08 471 VMCOREINFO_STRUCT_SIZE(zone); 692f66f26a4c19 Hari Bathini 2017-05-08 472 VMCOREINFO_STRUCT_SIZE(free_area); 692f66f26a4c19 Hari Bathini 2017-05-08 473 VMCOREINFO_STRUCT_SIZE(list_head); 692f66f26a4c19 Hari Bathini 2017-05-08 474 VMCOREINFO_SIZE(nodemask_t); 692f66f26a4c19 Hari Bathini 2017-05-08 475 VMCOREINFO_OFFSET(page, flags); 692f66f26a4c19 Hari Bathini 2017-05-08 476 VMCOREINFO_OFFSET(page, _refcount); 692f66f26a4c19 Hari Bathini 2017-05-08 477 VMCOREINFO_OFFSET(page, mapping); 692f66f26a4c19 Hari Bathini 2017-05-08 478 VMCOREINFO_OFFSET(page, lru); 692f66f26a4c19 Hari Bathini 2017-05-08 479 VMCOREINFO_OFFSET(page, _mapcount); 692f66f26a4c19 Hari Bathini 2017-05-08 480 VMCOREINFO_OFFSET(page, private); 692f66f26a4c19 Hari Bathini 2017-05-08 481 VMCOREINFO_OFFSET(page, compound_dtor); 692f66f26a4c19 Hari Bathini 2017-05-08 482 VMCOREINFO_OFFSET(page, compound_order); 692f66f26a4c19 Hari Bathini 2017-05-08 483 VMCOREINFO_OFFSET(page, compound_head); 692f66f26a4c19 Hari Bathini 2017-05-08 484 VMCOREINFO_OFFSET(pglist_data, node_zones); 692f66f26a4c19 Hari Bathini 2017-05-08 485 VMCOREINFO_OFFSET(pglist_data, nr_zones); 692f66f26a4c19 Hari Bathini 2017-05-08 486 #ifdef CONFIG_FLAT_NODE_MEM_MAP 692f66f26a4c19 Hari Bathini 2017-05-08 487 VMCOREINFO_OFFSET(pglist_data, node_mem_map); 692f66f26a4c19 Hari Bathini 2017-05-08 488 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 489 VMCOREINFO_OFFSET(pglist_data, node_start_pfn); 692f66f26a4c19 Hari Bathini 2017-05-08 490 VMCOREINFO_OFFSET(pglist_data, node_spanned_pages); 692f66f26a4c19 Hari Bathini 2017-05-08 491 VMCOREINFO_OFFSET(pglist_data, node_id); 692f66f26a4c19 Hari Bathini 2017-05-08 492 VMCOREINFO_OFFSET(zone, free_area); 692f66f26a4c19 Hari Bathini 2017-05-08 493 VMCOREINFO_OFFSET(zone, vm_stat); 692f66f26a4c19 Hari Bathini 2017-05-08 494 VMCOREINFO_OFFSET(zone, spanned_pages); 692f66f26a4c19 Hari Bathini 2017-05-08 495 VMCOREINFO_OFFSET(free_area, free_list); 692f66f26a4c19 Hari Bathini 2017-05-08 496 VMCOREINFO_OFFSET(list_head, next); 692f66f26a4c19 Hari Bathini 2017-05-08 497 VMCOREINFO_OFFSET(list_head, prev); 692f66f26a4c19 Hari Bathini 2017-05-08 498 VMCOREINFO_OFFSET(vmap_area, va_start); 692f66f26a4c19 Hari Bathini 2017-05-08 499 VMCOREINFO_OFFSET(vmap_area, list); 692f66f26a4c19 Hari Bathini 2017-05-08 500 VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER); 692f66f26a4c19 Hari Bathini 2017-05-08 501 log_buf_vmcoreinfo_setup(); 692f66f26a4c19 Hari Bathini 2017-05-08 502 VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES); 692f66f26a4c19 Hari Bathini 2017-05-08 503 VMCOREINFO_NUMBER(NR_FREE_PAGES); 692f66f26a4c19 Hari Bathini 2017-05-08 504 VMCOREINFO_NUMBER(PG_lru); 692f66f26a4c19 Hari Bathini 2017-05-08 505 VMCOREINFO_NUMBER(PG_private); 692f66f26a4c19 Hari Bathini 2017-05-08 506 VMCOREINFO_NUMBER(PG_swapcache); 1cbf29da3628b6 Petr Tesarik 2018-04-13 507 VMCOREINFO_NUMBER(PG_swapbacked); 692f66f26a4c19 Hari Bathini 2017-05-08 508 VMCOREINFO_NUMBER(PG_slab); 692f66f26a4c19 Hari Bathini 2017-05-08 509 #ifdef CONFIG_MEMORY_FAILURE 692f66f26a4c19 Hari Bathini 2017-05-08 510 VMCOREINFO_NUMBER(PG_hwpoison); 692f66f26a4c19 Hari Bathini 2017-05-08 511 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 512 VMCOREINFO_NUMBER(PG_head_mask); 6e292b9be7f435 Matthew Wilcox 2018-06-07 513 #define PAGE_BUDDY_MAPCOUNT_VALUE (~PG_buddy) 692f66f26a4c19 Hari Bathini 2017-05-08 514 VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE); 692f66f26a4c19 Hari Bathini 2017-05-08 515 #ifdef CONFIG_HUGETLB_PAGE 692f66f26a4c19 Hari Bathini 2017-05-08 516 VMCOREINFO_NUMBER(HUGETLB_PAGE_DTOR); e04b742f74c236 David Hildenbrand 2019-03-05 517 #define PAGE_OFFLINE_MAPCOUNT_VALUE (~PG_offline) e04b742f74c236 David Hildenbrand 2019-03-05 518 VMCOREINFO_NUMBER(PAGE_OFFLINE_MAPCOUNT_VALUE); 692f66f26a4c19 Hari Bathini 2017-05-08 519 #endif 692f66f26a4c19 Hari Bathini 2017-05-08 520 692f66f26a4c19 Hari Bathini 2017-05-08 521 arch_crash_save_vmcoreinfo(); 692f66f26a4c19 Hari Bathini 2017-05-08 522 update_vmcoreinfo_note(); 692f66f26a4c19 Hari Bathini 2017-05-08 523 692f66f26a4c19 Hari Bathini 2017-05-08 524 return 0; 692f66f26a4c19 Hari Bathini 2017-05-08 525 } 692f66f26a4c19 Hari Bathini 2017-05-08 526 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org