From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B93EC4708F for ; Thu, 3 Jun 2021 01:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07304613D7 for ; Thu, 3 Jun 2021 01:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbhFCBOt (ORCPT ); Wed, 2 Jun 2021 21:14:49 -0400 Received: from mail108.syd.optusnet.com.au ([211.29.132.59]:34331 "EHLO mail108.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229620AbhFCBOs (ORCPT ); Wed, 2 Jun 2021 21:14:48 -0400 Received: from dread.disaster.area (pa49-179-138-183.pa.nsw.optusnet.com.au [49.179.138.183]) by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id D72CE1AFC81; Thu, 3 Jun 2021 11:13:03 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1lobux-008Ioc-Ce; Thu, 03 Jun 2021 11:13:03 +1000 Date: Thu, 3 Jun 2021 11:13:03 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 10/15] xfs: clean up inode state flag tests in xfs_blockgc_igrab Message-ID: <20210603011303.GI664593@dread.disaster.area> References: <162267269663.2375284.15885514656776142361.stgit@locust> <162267275227.2375284.10086521959797919134.stgit@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162267275227.2375284.10086521959797919134.stgit@locust> X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=F8MpiZpN c=1 sm=1 tr=0 a=MnllW2CieawZLw/OcHE/Ng==:117 a=MnllW2CieawZLw/OcHE/Ng==:17 a=kj9zAlcOel0A:10 a=r6YtysWOX24A:10 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=htmorksMGGV_6Zs7kA4A:9 a=CjuIK1q_8ugA:10 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Jun 02, 2021 at 03:25:52PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Clean up the definition of which inode states are not eligible for > speculative preallocation garbage collecting by creating a private > #define. The deferred inactivation patchset will add two new entries to > the set of flags-to-ignore, so we want the definition not to end up a > cluttered mess. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/xfs_icache.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Makes sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com