Re: [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares

From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Igor Russkikh <irusskikh@marvell.com>,
	Aaron Conole <aconole@redhat.com>,
	Michael Santana <maicolgabriel@hotmail.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Rasesh Mody <rmody@marvell.com>,
	Shahed Shaikh <shshaikh@marvell.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Heinrich Kuhn <heinrich.kuhn@netronome.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares
Date: Fri, 4 Jun 2021 01:29:22 +0300	[thread overview]
Message-ID: <20210604012922.63574cff@sovereign> (raw)
In-Reply-To: <20210603165512.7357-3-david.marchand@redhat.com>

2021-06-03 18:55 (UTC+0200), David Marchand:
[...]
> diff --git a/config/meson.build b/config/meson.build
> index 017bb2efbb..c6985139b4 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -172,6 +172,13 @@ if libexecinfo.found() and cc.has_header('execinfo.h')
>      dpdk_extra_ldflags += '-lexecinfo'
>  endif
>  
> +libarchive = dependency('libarchive', required: false, method: 'pkg-config')
> +if libarchive.found()
> +    dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1)
> +    add_project_link_arguments('-larchive', language: 'c')
> +    dpdk_extra_ldflags += '-larchive'
> +endif
> +

Suggestion:

diff --git a/config/meson.build b/config/meson.build
index c6985139b4..c3668798c1 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -175,7 +175,6 @@ endif
 libarchive = dependency('libarchive', required: false, method: 'pkg-config')
 if libarchive.found()
     dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1)
-    add_project_link_arguments('-larchive', language: 'c')
     dpdk_extra_ldflags += '-larchive'
 endif
 
diff --git a/lib/eal/meson.build b/lib/eal/meson.build
index 1722924f67..5a018d97d6 100644
--- a/lib/eal/meson.build
+++ b/lib/eal/meson.build
@@ -16,6 +16,7 @@ subdir(exec_env)
 subdir(arch_subdir)
 
 deps += ['kvargs']
+ext_deps += libarchive
 if not is_windows
     deps += ['telemetry']
 endif
