From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
<linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Subject: Re: [PATCH] kprobes: Print an error if probe is rejected
Date: Thu, 10 Jun 2021 13:33:46 -0400 [thread overview]
Message-ID: <20210610133346.4a55c60a@oasis.local.home> (raw)
In-Reply-To: <20210610191643.d24e7d56d102567070fe8386@kernel.org>
On Thu, 10 Jun 2021 19:16:43 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Hmm, Nack for this way, but I understand that is a problem.
> If you got the error in perf probe, which uses ftrace dynamic-event interface.
> In that case, the errors should not be output in the dmesg, but are reported
> via error_log in tracefs.
> And kprobes itself should return different error code to the caller, instead
> of printing error in dmesg. See below.
We should update perf to use libtracefs that also has an interface to
read the error_log file.
-- Steve
next prev parent reply other threads:[~2021-06-10 17:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:56 [PATCH] kprobes: Print an error if probe is rejected Naveen N. Rao
2021-06-10 10:16 ` Masami Hiramatsu
2021-06-10 17:33 ` Steven Rostedt [this message]
2021-06-11 1:50 ` Masami Hiramatsu
2021-06-11 13:55 ` Naveen N. Rao
2021-06-11 19:40 ` Steven Rostedt
2021-06-14 15:30 ` Naveen N. Rao
2021-06-18 16:15 ` Masami Hiramatsu
2021-06-21 9:36 ` Naveen N. Rao
2021-06-21 12:54 ` Masami Hiramatsu
2021-06-12 1:13 ` Masami Hiramatsu
2021-06-14 15:37 ` Naveen N. Rao
2021-06-15 5:42 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610133346.4a55c60a@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.