From: Jakub Kicinski <kuba@kernel.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
David Miller <davem@davemloft.net>,
Hemant Kumar <hemantk@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bhaumik Bhatt <bbhatt@codeaurora.org>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] bus: mhi: Add inbound buffers allocation flag
Date: Fri, 11 Jun 2021 11:31:17 -0700 [thread overview]
Message-ID: <20210611113117.23846e75@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CAMZdPi8FVWRhU69z6JygsqoqMCOJTKGfo6vTWtv35kT-Ap8Drg@mail.gmail.com>
On Fri, 11 Jun 2021 09:00:16 +0200 Loic Poulain wrote:
> > On Fri, May 21, 2021 at 03:25:19PM +0200, Loic Poulain wrote:
> > > Currently, the MHI controller driver defines which channels should
> > > have their inbound buffers allocated and queued. But ideally, this is
> > > something that should be decided by the MHI device driver instead,
> > > which actually deals with that buffers.
> > >
> > > Add a flag parameter to mhi_prepare_for_transfer allowing to specify
> > > if buffers have to be allocated and queued by the MHI stack.
> > >
> > > Keep auto_queue flag for now, but should be removed at some point.
> > >
> > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> > > Tested-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> > > Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
> > > Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > > v2: Update API in mhi_wwan_ctrl driver
> > >
> > > drivers/bus/mhi/core/internal.h | 2 +-
> > > drivers/bus/mhi/core/main.c | 11 ++++++++---
> > > drivers/net/mhi/net.c | 2 +-
> > > drivers/net/wwan/mhi_wwan_ctrl.c | 2 +-
> >
> > Since this patch touches the drivers under net/, I need an Ack from Dave or
> > Jakub to take it via MHI tree.
>
> Could you please ack|nack this patch?
Looks fine.
next prev parent reply other threads:[~2021-06-11 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 13:25 [PATCH v2] bus: mhi: Add inbound buffers allocation flag Loic Poulain
2021-05-21 16:35 ` Manivannan Sadhasivam
2021-06-11 7:00 ` Loic Poulain
2021-06-11 18:31 ` Jakub Kicinski [this message]
2021-06-12 6:47 ` Manivannan Sadhasivam
2021-06-12 6:52 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611113117.23846e75@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bbhatt@codeaurora.org \
--cc=davem@davemloft.net \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mani@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.