From: Tom Rini <trini@konsulko.com>
To: nicholas_zheng@outlook.com
Cc: bharat.gooty@broadcom.com, rayagonda.kokatanur@broadcom.com,
jagan@amarulasolutions.com, kever.yang@rock-cihps.com,
andre.przywara@arm.com, festevam@gmail.com,
patrick.delaunay@foss.st.com, tharvey@gateworks.com,
pbrobinson@gmail.com, hs@denx.de, lokeshvutla@ti.com,
d-gerlach@ti.com, u-boot@lists.denx.de
Subject: Re: [PATCH] arm: add initial support for the Phytium Pomelo Board
Date: Tue, 15 Jun 2021 08:45:12 -0400 [thread overview]
Message-ID: <20210615124512.GI9516@bill-the-cat> (raw)
In-Reply-To: <OSBPR01MB207110E2B471C456326BF506E0309@OSBPR01MB2071.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
On Tue, Jun 15, 2021 at 05:44:35PM +0800, nicholas_zheng@outlook.com wrote:
> From: weichangzheng <nicholas_zheng@outlook.com>
>
> This adds platform code and the device tree for the Phytium Pomelo Board.
> The initial support comprises the UART and the PCIE.
>
> Signed-off-by: weichangzheng <nicholas_zheng@outlook.com>
This looks better, thanks. I see you're adding <common.h> in your code,
can you drop that and only include the headers it needs? Most of
<common.h> has been removed, thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-06-15 12:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:44 [PATCH] arm: add initial support for the Phytium Pomelo Board nicholas_zheng
2021-06-15 12:45 ` Tom Rini [this message]
2021-06-15 12:59 ` Peter Robinson
-- strict thread matches above, loose matches on Subject: below --
2021-06-24 1:02 nicholas_zheng
2021-06-25 12:27 ` Andre Przywara
2021-06-21 8:36 nicholas_zheng
2021-06-21 8:31 nicholas_zheng
2021-06-21 8:18 nicholas_zheng
2021-06-16 6:16 nicholas_zheng
2021-06-09 9:34 nicholas_zheng
2021-06-09 12:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615124512.GI9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=bharat.gooty@broadcom.com \
--cc=d-gerlach@ti.com \
--cc=festevam@gmail.com \
--cc=hs@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-cihps.com \
--cc=lokeshvutla@ti.com \
--cc=nicholas_zheng@outlook.com \
--cc=patrick.delaunay@foss.st.com \
--cc=pbrobinson@gmail.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.