All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/lzlib: remove it
Date: Tue, 15 Jun 2021 21:48:27 +0200	[thread overview]
Message-ID: <20210615194827.GM2610983@scaer> (raw)
In-Reply-To: <CAB0FRss2s6ZcTpfojjcwYCKHUqi457u5o26BGOViKM4_bUuXXg@mail.gmail.com>

Fran?ois, All,

On 2021-06-15 13:30 +0200, Fran?ois Perrad spake thusly:
> Le?lun. 14 juin 2021 ??22:27, Yann E. MORIN < [1]yann.morin.1998@free.fr> a ?crit?:
>   On 2021-06-13 17:42 +0200, Francois Perrad spake thusly:
>   > Signed-off-by: Francois Perrad < [2]francois.perrad@gadz.org>
>   Removing a package should dully explained in the commit log.
>   lua-zlib that you taunt as a replcement, adertises that it is not 100%
>   percent compatible:
[--SNIP--]
>   ? ? To use this shim add the -DLZLIB_COMPAT compiler flag.
> 
> This is done by the rockspec:
> see [4]https://github.com/brimworks/lua-zlib/blob/master/rockspecs/lua-zlib-1.2-0.rockspec#L33

So, this is the kind of information that should be part of the commit
log, for example (e.g.: the rockspec file for lua-zlib automatically
enables this legacy shim, so packages autoamtically inherit it).

However, this is still not a drop-in replacement, because parts of the
API return different types than lzlib did.

So, if some packages really need that part, they can't use lua-zlib.

Additionally, it is still OK to keep an old package in the tree, at
least as long as there is no drop-in-replacement, or that there are
still in-tree users, and as long as it does not cause any build
failure, that is not much an issue...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-06-15 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13 15:42 [Buildroot] [PATCH 1/2] package/lua-zlib: new package Francois Perrad
2021-06-13 15:42 ` [Buildroot] [PATCH 2/2] package/lzlib: remove it Francois Perrad
2021-06-14 20:27   ` Yann E. MORIN
2021-06-15 11:30     ` François Perrad
2021-06-15 19:48       ` Yann E. MORIN [this message]
2021-06-14 20:32 ` [Buildroot] [PATCH 1/2] package/lua-zlib: new package Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615194827.GM2610983@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.